Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp4547395imj; Tue, 12 Feb 2019 19:03:13 -0800 (PST) X-Google-Smtp-Source: AHgI3IZ9i3ejAvKr3Mo2LJvQ2AkCerD3JkUABEpnimn75BCbrGg5Si5Q+LBk6LwcyrSMASAJZZ67 X-Received: by 2002:a62:1484:: with SMTP id 126mr7218737pfu.257.1550026993188; Tue, 12 Feb 2019 19:03:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550026993; cv=none; d=google.com; s=arc-20160816; b=RXf5/ycBRP6+ORLrO7w70Ve1RBj3yilxalnxzF/65qTVh9t6KiDKOlZ6qd0ctjRs+8 IgnQWb6iHR3MWgFZdnD5Xm29OscssBKM5tGB3nSG7PPdoqpxGuG648ZFOoOY0H1UaLn7 l/nLSH2pTYXsyZbLg2MDxGKQt7nPt4FZvgtJ9D3SQ7m4T1uxrRCAG7ge+tfaN5Sr4WlE puRoF0nmSIdfrYxv8SGbmCO4qirSlgt8SqFA9SRawM32S8q+dLVV/i8k3alVyv97OBc8 LMh16eKml85Rcg22KvjNUq5zlOXeCQWWRuYbNghP2KWZIHN8vUEsm1R8Kxd5Dq+mHbbQ p8Tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature; bh=SHDxREFjwANVKrlFk5mD/fYvoQO4Sa+mXDAIIolqCTI=; b=j6zvHI32Xra1uXgRYFwo9BEazYaGCQi7LOqn6ybMrBMpu5BfrJIGFHI46OVWsIEySx YGyM5pMEbf8Mfe1UH5SareoO0kOnsoUwWHqceZRFW/TPDfwJD1F+mfrO9zu7Nqaroh0v 424Pw4tlkvBn1zbNjFpXDV3/D0KO8I0wk84ZOflg/NfKRl9p9JouVM+ZRd/bgdRWggO6 kgHT+SqBhKoCEHhARwrx/Qj6VMCAhLTtx48mnZoRnYgieA1JY8U/SPkfWLOCCdlDm4iZ 1ICbMkwpZqxmya+1ksjtuTiTlJ8+peAKtmFLlwZTUHQQGowiY3iC0i+dMPbSNRZ8jJ9a 1tRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=OSfAKwMw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d142si15142094pfd.93.2019.02.12.19.02.56; Tue, 12 Feb 2019 19:03:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=OSfAKwMw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390332AbfBMDCL (ORCPT + 99 others); Tue, 12 Feb 2019 22:02:11 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:55258 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728440AbfBMDCF (ORCPT ); Tue, 12 Feb 2019 22:02:05 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x1D2wao2040802; Wed, 13 Feb 2019 03:01:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=SHDxREFjwANVKrlFk5mD/fYvoQO4Sa+mXDAIIolqCTI=; b=OSfAKwMwcBHn9rTjqwcp7HLHo2OBDB0o/Rbk775medm6GcWxLA+Pn7j0FaXLDPXbm/0v JAZbDJKn5NqpRNWuUVdgnPFd0fSWj3PRrr1hZmkGGyn2kyYHoaL1iB8rtittRPbwnGZ0 fhGJ4xVfGab0UL+wrJ8FR+h1FbLkKi8lMHpRoxMo1O40itfjyLstZsg2zixhhhppag72 8AYoyF+Vm/XLV5RyoclZw0CKDt9+NEh0RS6T5xVtL9l76gaIzYxr1cPbliqlHbZWaBcJ 3Nsjjayy94OjUx16b1/jT2K0n3DEwbOzEUh1s/RtMOjMph3jt5p4Zu4jth2dqiCGCS+M wA== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2130.oracle.com with ESMTP id 2qhrekfgdm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 13 Feb 2019 03:01:50 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id x1D31oba009980 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 13 Feb 2019 03:01:50 GMT Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x1D31nKs009833; Wed, 13 Feb 2019 03:01:49 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 12 Feb 2019 19:01:49 -0800 To: "chenxiang \(M\)" Cc: "Martin K. Petersen" , John Garry , , , , Subject: Re: [PATCH 1/6] scsi: hisi_sas: Add support for DIX feature for v3 hw From: "Martin K. Petersen" Organization: Oracle Corporation References: <1549450376-114929-1-git-send-email-john.garry@huawei.com> <1549450376-114929-2-git-send-email-john.garry@huawei.com> <53c516cc-cce3-a3e1-718f-6fc465b6e401@hisilicon.com> Date: Tue, 12 Feb 2019 22:01:46 -0500 In-Reply-To: <53c516cc-cce3-a3e1-718f-6fc465b6e401@hisilicon.com> (chenxiang's message of "Mon, 11 Feb 2019 19:36:01 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9165 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=908 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902130018 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org chenxiang, >>> + if (prot_flags & SCSI_PROT_REF_CHECK) >>> + return T10_CHK_APP_TAG_MSK; >> Polarity is a bit unclear here. Is this statement disabling checking of >> the app tag? > > Yes, disabling checking of app tag. > For here, 1'b0 presents the related byte in DIF will be checked, and > 1'b1 presents the related byte in DIF will not be checked. OK, thanks for the clarification! -- Martin K. Petersen Oracle Linux Engineering