Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp4823096imj; Wed, 13 Feb 2019 01:31:58 -0800 (PST) X-Google-Smtp-Source: AHgI3IYuqy++h6j/FWSR59LsnB5KZdNZ33iKEglmSs7uhRyss4EIquNLvfOqcDPDM3Wo90Im8POH X-Received: by 2002:a17:902:8643:: with SMTP id y3mr8979181plt.80.1550050318449; Wed, 13 Feb 2019 01:31:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550050318; cv=none; d=google.com; s=arc-20160816; b=FRqBN6VGFMw05ROMY/SIdhA7kHoO7rPeYvG0D1guBRhgxuGAPqaRIPl5uj1x2aNozc 9KQ26fWYUEjkDA1pH36zNfs3nP1ZP1PAytTnMF6ICVTI1yPxkICpEHhPH05GprosjK9z 8Pq74LZckWxGS0L8rUfxvfHX4BNSBG79CIgjcOjxrMwP09QXVD2MN7Bj6rftB3jtCVDY mzHb/BKVrTLRGjiiIAwpOm1IKlesqYIkpUkB0Ms/vsi6gjabaJsMtlJIpP7yJikjSr1K +Mh5sNcSXUD1aipj4RpUXhUS1SCAlxSzzJAIdRxJTIFOY+S20fX8vUWuOCt74onHcTA9 4mVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=sjarOO1fM7fl0IqS8UEWhDa9GK/T3fwQucCxiPQdsug=; b=zKmMzvLpGNPXI9sIKrumwfNGjj4EIMYpPbU/u4MKtxONY0+1mXh1hakbRYs3OMKaCG M3+FSIInc5qCHm8bbl+rJQV+CSNZBJShqioaoAQcxgtfm8cni+d30Cxz2gpGDz2z5x0U uQHS5cGZ0Pid9G6mT+KhOpk3fIWSGCK2810SUoCp3pEqAFsnzFIlgwf0zbr/HqwkJtko 80CCpUC2NJKMejAEfogNhKJY9GyNg+to/vISdT7Cif3VJfXAN4wA8r8OoT0TME1T86yX X9VtN52z4t5fpdVF+YSATlEhQdPm9uDfNQaDl57DDII7A7DUmtSiF/3ubEYDewRnJOPf wlVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=ETWGqc2M; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r17si14765539pgr.331.2019.02.13.01.31.42; Wed, 13 Feb 2019 01:31:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=ETWGqc2M; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731314AbfBMFzO (ORCPT + 99 others); Wed, 13 Feb 2019 00:55:14 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:37934 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730072AbfBMFzO (ORCPT ); Wed, 13 Feb 2019 00:55:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=sjarOO1fM7fl0IqS8UEWhDa9GK/T3fwQucCxiPQdsug=; b=ETWGqc2Mz6K29m6ztE7p4C7Hx v3WtDxQVbKYoFwFAws/oKdUtRcjJc4jq8YAW3NUxtgJ+0vQEJjvjlL7VEumfkgFGckh3Aa3/LNVTd pSH0uese0c4ZONMd9KrGCPJkMAAiL63aRdFe21yuUnBsIpz3fkUToc9ulQLXDzKTVaVYC2Si7kyPg THehrx0wIAaLOslYqSBXNydOPh9SuxiNSLLmkCfzO2GxKuBjxAXX52ZbcHl0sIzAMpI1BWU9tBJNj VNbwDHIIz6+VsVAD5V6LG9swtMhxiuochHT69j8a8JAbmjkXxTak8YEw/D5P89EfDiQi/JsLERPMH 5mBkY/KlQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1gtnVm-0002mt-6O; Wed, 13 Feb 2019 05:55:10 +0000 Date: Tue, 12 Feb 2019 21:55:10 -0800 From: Christoph Hellwig To: Anup Patel Cc: Christoph Hellwig , Anup Patel , Palmer Dabbelt , "linux-kernel@vger.kernel.org" , Atish Patra , Albert Ou , Paul Walmsley , "linux-riscv@lists.infradead.org" Subject: Re: [PATCH v2 6/6] RISC-V: Implement keepinitrd kernel parameter Message-ID: <20190213055510.GA5725@infradead.org> References: <20190119132650.9978-1-anup.patel@wdc.com> <20190119132650.9978-7-anup.patel@wdc.com> <20190212070807.GD26747@infradead.org> <20190212184505.GA10984@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 13, 2019 at 03:43:06AM +0000, Anup Patel wrote: > Sure, the keepinitrd=0 by default so it will always free-up initrd by default. > Please look at v3 patchset. > > Of course, we need separate patch to update documentation of keepinitrd. No, we need to not just blindly copy what arm did for historic reasons unless we have a very good reason of our own. In addition to not having a real need for any of this in a new setup, it also is duplicated by the retain_initrd parameter which is implemented in generic code - and for that the commit message at least has a rationale related to kexec: https://lkml.org/lkml/2006/12/7/15