Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp4838843imj; Wed, 13 Feb 2019 01:53:07 -0800 (PST) X-Google-Smtp-Source: AHgI3IZ8f1Ie574Vgvm5ZNI0XCANxhjg7isSt8rVUA3RCL2qKpwt4yAMctnYnvmVrqK/INch7EHd X-Received: by 2002:a17:902:9006:: with SMTP id a6mr8828416plp.334.1550051587920; Wed, 13 Feb 2019 01:53:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550051587; cv=none; d=google.com; s=arc-20160816; b=D6rgrGb03ZxBLeZxOzAsFlYHbc+HhVMxFOe3Gmvwzst5Sd2NufX7Ao7sasG57YQcEx 7dxlzjOSZxItHjQZiQP+ZImTsdShtSvbBf+m420hy7S+63ckG5+RaQl66yNzQtE3dYqG 1t0IGN1f6rtsaR4QxNhUp4lfzZlI0nz5z/imseuyhFsn4RoyC+Hx9a9823nudOOlB+B9 OU4SOHmQl5sgTw5E6VEyzpZ3TlAwY3mEVeGxvZfjOCsQZvc9ysfzw439tahaJ6mUZ6Xw E0bUyBo3MuKws3Iz120ssTseVE5/7Atjx9VpTzcKMJZQpRnmqzv3BMqii+RHv/5cIIfh s6kQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=BwvNPx1nbCxxl00TZ+tlGve53HbJ277SuN/3ICIDGTE=; b=fup0VH+VqCPv2GjavUb2NZ8TaLumIpUe6R61n/f/dYcq2V9Ox+I010z6dcMHPSGjVK 5/PjQAo1vTHymYzE27mJbC1GG1Mxkc9jBq6Vh4bnYdjmW5ed4Ez18zxxVbQO/yVRmq/V D2f1hc2BcsgwtWElIX44JcHUrIc7Su5AG6ysXCsiO7fMXf9aKmGCGtVGXr2C6YMyd58N oJ7nlSLB6CwCVoj7qAWW9Qf3ZgNB+AnkR7Nowgovo8oCASDRHPk0i2SuY8zJvaf+T1Z3 JpWNi6dGcVy3KDN2cxlnJssAMiZ+sZnCgXmyECtPvxJzM1Cmf6LqJXTL+rG3uTRD8+9M GBhg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=gd3tcy2j; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h17si15086967pgh.495.2019.02.13.01.52.51; Wed, 13 Feb 2019 01:53:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=gd3tcy2j; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387856AbfBMHCH (ORCPT + 99 others); Wed, 13 Feb 2019 02:02:07 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:50916 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728298AbfBMHCH (ORCPT ); Wed, 13 Feb 2019 02:02:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=BwvNPx1nbCxxl00TZ+tlGve53HbJ277SuN/3ICIDGTE=; b=gd3tcy2jYkn0mcg8NOwdCPfMad f1dWfb+/ccNK50NTO+19wpLYH2ICvugvXG6mrFreyop5PjozNTEZowrJN7Tspr02+IDXauHao7AHk PbPx7W/8UOSLmahlDFQna8bWo8c6fZHY34vtCxOHpxwZhhTB5G+M2dBL/RRjvYBClmpnCWg4C/pU9 uEqouSq/i/7HnWLqK7OG/2KH8r8kmpxiIeB5SLr1+7mgSPlF4f1Wk2SANkaA7eU7Nt8d/UXSvezCw 7G9guUBuF483VxRFM7o4bzImsepb33hRbnmbiWo1yNMNV4rBqOuZ9BRq9Myd+9Kyu0bNewI13lhto uf4wwQmA==; Received: from 089144210182.atnat0019.highway.a1.net ([89.144.210.182] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1gtoY4-0000F8-Qe; Wed, 13 Feb 2019 07:01:37 +0000 From: Christoph Hellwig To: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Olof Johansson Cc: linuxppc-dev@lists.ozlabs.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Christian Zigotzky Subject: [PATCH 01/32] net: pasemi: set a 64-bit DMA mask on the DMA device Date: Wed, 13 Feb 2019 08:01:02 +0100 Message-Id: <20190213070133.11259-2-hch@lst.de> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190213070133.11259-1-hch@lst.de> References: <20190213070133.11259-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The pasemi driver never set a DMA mask, and given that the powerpc DMA mapping routines never check it this worked ok so far. But the generic dma-direct code which I plan to switch on for powerpc checks the DMA mask and fails unsupported mapping requests, so we need to make sure the proper 64-bit mask is set. Reported-by: Christian Zigotzky Signed-off-by: Christoph Hellwig Tested-by: Christian Zigotzky --- drivers/net/ethernet/pasemi/pasemi_mac.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/pasemi/pasemi_mac.c b/drivers/net/ethernet/pasemi/pasemi_mac.c index d21041554507..a5bf46310f60 100644 --- a/drivers/net/ethernet/pasemi/pasemi_mac.c +++ b/drivers/net/ethernet/pasemi/pasemi_mac.c @@ -1716,6 +1716,7 @@ pasemi_mac_probe(struct pci_dev *pdev, const struct pci_device_id *ent) err = -ENODEV; goto out; } + dma_set_mask(&mac->dma_pdev->dev, DMA_BIT_MASK(64)); mac->iob_pdev = pci_get_device(PCI_VENDOR_ID_PASEMI, 0xa001, NULL); if (!mac->iob_pdev) { -- 2.20.1