Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp4841058imj; Wed, 13 Feb 2019 01:56:22 -0800 (PST) X-Google-Smtp-Source: AHgI3IYEJFXDPQnSUWNv79Lu/KBH7AKIs64SCRomlC8wtpgMAPi04+pLdbhaPW3Tg0ApK7yI8s78 X-Received: by 2002:a65:63d3:: with SMTP id n19mr8185618pgv.179.1550051782462; Wed, 13 Feb 2019 01:56:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550051782; cv=none; d=google.com; s=arc-20160816; b=wXR8aaDjX/h0+3q360QERedCU8cDolpFfI5t5nr42karIY3jLzhetH830HBLeBSlYU n+61pVgosjtl8oqSy+FgJujpO/45WAYjqhLnc0TR6K3T1wdM8YpTwnbuEPfDD5vmEXQf l7VET80wUUA1QKgfu82tblf1moa2NxWLpBVNE2VYNjxt7x44aU8DYP8RYiYUZgi5Jwiy ATgwetmYQTBlqo07S+MecrFa9oGifWz3DPaWtP4BSYgNArjUnrk4rSLgpwJfDSHivc/8 BYAY7Kibd7jaIbfJPXWQUvOPM7oB/C63TldfsPdQIUlQqU+OQ0vws0rVUIsI8LtahA11 ji6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=6WQFL3C23zajiNfd0kAqIeZVSaZbYE4kbbquM/AFGS8=; b=eLzhYCkY2aOMJy6l+O6CDKrZBHMEVgKxr/V3PtbIkDEToGw+19FX0v+itzZjd0aAzA wMZnHUMAe7N+K7Kri8gppZteKWgC4JiVbRrEf5JHvInLl4BnR+oQ/UHKrnw8u7DnWPuw LHhP6tf39pPvKUJMgEzgaUstCxfaPazuJeRNOGIgIL2auEq531Gf3Fu3fAaalzw9bEcc L6lCpRkWAFz3DBDbx8l6SoMhotmoYMmQnPcWBafWWV3fUaJeuPR6jwUgR/HrgE0rAxCZ 0AM0hsba8BRPCpQzp1/aBUhp5RQScAAX6lzruHQrj7ud8wNEV4WRC/AYqErL1oQWuDza cjXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=Nh6AWLdh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x9si8736029plv.413.2019.02.13.01.56.06; Wed, 13 Feb 2019 01:56:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=Nh6AWLdh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389311AbfBMHDq (ORCPT + 99 others); Wed, 13 Feb 2019 02:03:46 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:51326 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388771AbfBMHCp (ORCPT ); Wed, 13 Feb 2019 02:02:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=6WQFL3C23zajiNfd0kAqIeZVSaZbYE4kbbquM/AFGS8=; b=Nh6AWLdhKTA+H+35V3Y9F5RVff skGBg3zzTKKCnD271HT6SldgKbJmfhFTdcZxKzjoGtZ13CMSGSx+bu3FSzkCMbeFqubjDP7Sqd5Rl 9KhJ9ZVAJZgFAr8LxQ4Tk7COLMMtpbAwe4Dc8hQ3Gk+tvsy+nmtPRxQVqewiDvgnSc437hsK9fvVt V/HPsxLXp8Q7F0fmCiiuhh2UsZxPOWPXVTl+iV1Orh32JJDKLD5D7GWLbHlu63hGVJL46pCXDGsyt fPxlaSR+2LfVohQmfyHivc+i/sbrhqVjpZgCclBwI7firSJ2owWZN5vyxRAYh1412nuOLjfXI3EVa XIk9hkDQ==; Received: from 089144210182.atnat0019.highway.a1.net ([89.144.210.182] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1gtoZ0-0000ho-Dz; Wed, 13 Feb 2019 07:02:34 +0000 From: Christoph Hellwig To: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Olof Johansson Cc: linuxppc-dev@lists.ozlabs.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Christian Zigotzky Subject: [PATCH 25/32] powerpc/dma: remove dma_nommu_dma_supported Date: Wed, 13 Feb 2019 08:01:26 +0100 Message-Id: <20190213070133.11259-26-hch@lst.de> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190213070133.11259-1-hch@lst.de> References: <20190213070133.11259-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This function is largely identical to the generic version used everywhere else. Replace it with the generic version. Signed-off-by: Christoph Hellwig Tested-by: Christian Zigotzky --- arch/powerpc/include/asm/dma-mapping.h | 1 - arch/powerpc/kernel/dma-iommu.c | 2 +- arch/powerpc/kernel/dma.c | 25 +------------------------ 3 files changed, 2 insertions(+), 26 deletions(-) diff --git a/arch/powerpc/include/asm/dma-mapping.h b/arch/powerpc/include/asm/dma-mapping.h index af9a32d4fcf8..cdf70aaeafeb 100644 --- a/arch/powerpc/include/asm/dma-mapping.h +++ b/arch/powerpc/include/asm/dma-mapping.h @@ -31,7 +31,6 @@ int dma_nommu_map_sg(struct device *dev, struct scatterlist *sgl, dma_addr_t dma_nommu_map_page(struct device *dev, struct page *page, unsigned long offset, size_t size, enum dma_data_direction dir, unsigned long attrs); -int dma_nommu_dma_supported(struct device *dev, u64 mask); #ifdef CONFIG_NOT_COHERENT_CACHE /* diff --git a/arch/powerpc/kernel/dma-iommu.c b/arch/powerpc/kernel/dma-iommu.c index 4377b69a9d42..67fbfaa4e3b2 100644 --- a/arch/powerpc/kernel/dma-iommu.c +++ b/arch/powerpc/kernel/dma-iommu.c @@ -21,7 +21,7 @@ static inline bool dma_iommu_alloc_bypass(struct device *dev) { return dev->archdata.iommu_bypass && !iommu_fixed_is_weak && - dma_nommu_dma_supported(dev, dev->coherent_dma_mask); + dma_direct_supported(dev, dev->coherent_dma_mask); } static inline bool dma_iommu_map_bypass(struct device *dev, diff --git a/arch/powerpc/kernel/dma.c b/arch/powerpc/kernel/dma.c index 46afc66cc271..a3546a82f6d7 100644 --- a/arch/powerpc/kernel/dma.c +++ b/arch/powerpc/kernel/dma.c @@ -39,29 +39,6 @@ static u64 __maybe_unused get_pfn_limit(struct device *dev) return pfn; } -int dma_nommu_dma_supported(struct device *dev, u64 mask) -{ -#ifdef CONFIG_PPC64 - u64 limit = phys_to_dma(dev, (memblock_end_of_DRAM() - 1)); - - /* Limit fits in the mask, we are good */ - if (mask >= limit) - return 1; - -#ifdef CONFIG_FSL_SOC - /* - * Freescale gets another chance via ZONE_DMA, however - * that will have to be refined if/when they support iommus - */ - return 1; -#endif - /* Sorry ... */ - return 0; -#else - return 1; -#endif -} - #ifndef CONFIG_NOT_COHERENT_CACHE void *__dma_nommu_alloc_coherent(struct device *dev, size_t size, dma_addr_t *dma_handle, gfp_t flag, @@ -190,7 +167,7 @@ const struct dma_map_ops dma_nommu_ops = { .free = __dma_nommu_free_coherent, .map_sg = dma_nommu_map_sg, .unmap_sg = dma_nommu_unmap_sg, - .dma_supported = dma_nommu_dma_supported, + .dma_supported = dma_direct_supported, .map_page = dma_nommu_map_page, .unmap_page = dma_nommu_unmap_page, .get_required_mask = dma_direct_get_required_mask, -- 2.20.1