Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Anup Patel <Anup.Patel@wdc.com>
To:     Mike Rapoport <rppt@linux.ibm.com>,
        Christoph Hellwig <hch@infradead.org>
CC:     Palmer Dabbelt <palmer@sifive.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Atish Patra <Atish.Patra@wdc.com>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        "linux-riscv@lists.infradead.org" <linux-riscv@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v4 6/6] RISC-V: Free-up initrd in free_initrd_mem()
Thread-Topic: [PATCH v4 6/6] RISC-V: Free-up initrd in free_initrd_mem()
Thread-Index: AQHUw2XhneCVLsk8fkmL4zO8eU0wjqXdSEuAgAAPKgCAAALWoA==
Date:   Wed, 13 Feb 2019 07:49:39 +0000
Message-ID: <DM6PR04MB60598585C233303817F4793B8D660@DM6PR04MB6059.namprd04.prod.outlook.com>
References: <20190213063127.28703-1-anup.patel@wdc.com>
 <20190213063127.28703-7-anup.patel@wdc.com>
 <20190213064419.GA27012@infradead.org> <20190213073835.GA18267@rapoport-lnx>
In-Reply-To: <20190213073835.GA18267@rapoport-lnx>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 6efb6ebd-775f-4fd8-cd86-08d69187ce92
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Feb 2019 07:49:39.0602
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB5849
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Mike Rapoport [mailto:rppt@linux.ibm.com]
> Sent: Wednesday, February 13, 2019 1:09 PM
> To: Christoph Hellwig <hch@infradead.org>
> Cc: Anup Patel <Anup.Patel@wdc.com>; Palmer Dabbelt
> <palmer@sifive.com>; Albert Ou <aou@eecs.berkeley.edu>; Atish Patra
> <Atish.Patra@wdc.com>; Paul Walmsley <paul.walmsley@sifive.com>; linux-
> riscv@lists.infradead.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v4 6/6] RISC-V: Free-up initrd in free_initrd_mem()
>=20
> Hi,
>=20
> On Tue, Feb 12, 2019 at 10:44:19PM -0800, Christoph Hellwig wrote:
> > On Wed, Feb 13, 2019 at 06:32:24AM +0000, Anup Patel wrote:
> > > index 9cd583b6d1cd..c22b873de856 100644
> > > --- a/arch/riscv/kernel/setup.c
> > > +++ b/arch/riscv/kernel/setup.c
> > > @@ -97,8 +97,9 @@ static void __init setup_initrd(void)
> > >  	initrd_end =3D 0;
> > >  }
> > >
> > > -void free_initrd_mem(unsigned long start, unsigned long end)
> > > +void __init free_initrd_mem(unsigned long start, unsigned long end)
> > >  {
> > > +	memblock_free(__pa(start), end - start);
> >
> > I'm pretty sure this should be a call to free_reserved_area instead.
> >
> > All regions reserved using memblock_reserved and not freed before
> > initializing the MM are marked reserved and don't have valid page
> > counts, etc.
> >
> > So we need the actions in free_reserved_area to actually make the
> > memory useful.  Now every other architecture except for arm64 seems to
> > do fine without a memblock_free.  I'm not an expert on memblock (but
> > I've CCed one), but I guess the reason is that once the kernel has
> > booted we don't really care about freeing memblock area.
>=20
> This late in the boot process there should be a call to
> free_reserved_area() to give pages to the buddy allocator.
>=20
> memblock_free() is has no real effect at this point, no idea why arm64 ca=
lls it.

Thanks for the info. I will update this patch to use free_reserved_area().

Regards,
Anup