Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp75532imj; Wed, 13 Feb 2019 05:02:09 -0800 (PST) X-Google-Smtp-Source: AHgI3IbzQlXXGo6VeJZ+N9dDS9iSgeRLt6WXqJ6l2qljE2Gqil0M20wdHZpd8OLdSPW3+57f4y8n X-Received: by 2002:a17:902:2a47:: with SMTP id i65mr390609plb.237.1550062929240; Wed, 13 Feb 2019 05:02:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550062929; cv=none; d=google.com; s=arc-20160816; b=zmSajSUWoO730/j2Bp/TxLIWxs7K/EUJCBNX2W53ukngzMJGKQ2i1sMH7HqX0yClgB TuiGc0j++rcgOULozeeYme8ToN7tMGowmD19pZtBJIV5qwoDj6j11uCQANKK6XKpR45X +WJs2pArofBI6yVIU/GXMaYY2XDYHHo7Uxk0S/Y79IcqOSde/zPW1TcjgAZ1ve1hmV2S U+7Dww8cddRkYjvHIYu+DSYQFQbzi/vZt2hRp3Qy6oUCJaiwS8Qxa8rjzr6URJYDQGbt hr42wuqsEY9a1+/1oV+hRuw+Fut2B+1s2GAjtH0/W1KMpmJHq7L6j9mNiS1b2zbdkGwi loVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-disposition :content-transfer-encoding:mime-version:robot-unsubscribe:robot-id :git-commit-id:subject:to:references:in-reply-to:reply-to:cc :message-id:from:date; bh=xqVrtlhRWIsqS7q6V2V//2kYY6YCvjFccdIhhLzzL+s=; b=lwbu61q++vNYo03d6h8TGP+YVlujLHkX+2o6YFfuuxqGjHxjUPzYMogB6WD2vOcj8I m8OSJ9NvwqVJAnTvyiuAKb13JBnG5rth6APVGaF61Cwuyz5xHfs2hjl8B2k+yMvknkyl nxS+RuXoDY3/5OkPwWPHiY5Bt2pTQvNguGDNcdxewc2tVFRChEDijfMtHwZt1Qyb24Hi H66R5wMgnxW5ACxrXqy53ES+xyRCQ6ABo8YWz4YsJwvioPSPU49N+sIlvE64/udNqg5+ pWa8VKVScDQLq7xkqwnkYGpWo4jjVO2EjmEar2cjMKos0IPBOliE50fIpk/zCip7ZcoM XL3Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q10si9763842pls.280.2019.02.13.05.01.51; Wed, 13 Feb 2019 05:02:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403797AbfBMIbd (ORCPT + 99 others); Wed, 13 Feb 2019 03:31:33 -0500 Received: from terminus.zytor.com ([198.137.202.136]:49547 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733281AbfBMIbd (ORCPT ); Wed, 13 Feb 2019 03:31:33 -0500 Received: from terminus.zytor.com (localhost [127.0.0.1]) by terminus.zytor.com (8.15.2/8.15.2) with ESMTPS id x1D8VO93189390 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 13 Feb 2019 00:31:24 -0800 Received: (from tipbot@localhost) by terminus.zytor.com (8.15.2/8.15.2/Submit) id x1D8VOjm189387; Wed, 13 Feb 2019 00:31:24 -0800 Date: Wed, 13 Feb 2019 00:31:24 -0800 X-Authentication-Warning: terminus.zytor.com: tipbot set sender to tipbot@zytor.com using -f From: "tip-bot for Zhang, Jun" Message-ID: Cc: tglx@linutronix.de, jun.zhang@intel.com, hpa@zytor.com, linux-kernel@vger.kernel.org, mingo@kernel.org, paulmck@linux.ibm.com Reply-To: hpa@zytor.com, jun.zhang@intel.com, tglx@linutronix.de, linux-kernel@vger.kernel.org, mingo@kernel.org, paulmck@linux.ibm.com In-Reply-To: <88DC34334CA3444C85D647DBFA962C2735AD5F77@SHSMSX104.ccr.corp.intel.com> References: <88DC34334CA3444C85D647DBFA962C2735AD5F77@SHSMSX104.ccr.corp.intel.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:core/rcu] rcu: Prevent needless ->gp_seq_needed update in __note_gp_changes() Git-Commit-ID: 13dc7d0c7a2ed438f0ec8e9fb365a1256d87cf87 X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, T_DATE_IN_FUTURE_96_Q autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on terminus.zytor.com Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 13dc7d0c7a2ed438f0ec8e9fb365a1256d87cf87 Gitweb: https://git.kernel.org/tip/13dc7d0c7a2ed438f0ec8e9fb365a1256d87cf87 Author: Zhang, Jun AuthorDate: Wed, 19 Dec 2018 10:37:34 -0800 Committer: Paul E. McKenney CommitDate: Fri, 25 Jan 2019 15:30:00 -0800 rcu: Prevent needless ->gp_seq_needed update in __note_gp_changes() Currently, __note_gp_changes() checks to see if the rcu_node structure's ->gp_seq_needed is greater than or equal to that of the rcu_data structure, and if so, updates the rcu_data structure's ->gp_seq_needed field. This results in a useless store in the case where the two fields are equal. This commit therefore carries out this store only in the case where the rcu_node structure's ->gp_seq_needed is strictly greater than that of the rcu_data structure. Signed-off-by: "Zhang, Jun" Signed-off-by: Paul E. McKenney Link: https://lkml.kernel.org/r/88DC34334CA3444C85D647DBFA962C2735AD5F77@SHSMSX104.ccr.corp.intel.com --- kernel/rcu/tree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index 21775eebb8f0..9d0e2ac9356e 100644 --- a/kernel/rcu/tree.c +++ b/kernel/rcu/tree.c @@ -1758,7 +1758,7 @@ static bool __note_gp_changes(struct rcu_node *rnp, struct rcu_data *rdp) zero_cpu_stall_ticks(rdp); } rdp->gp_seq = rnp->gp_seq; /* Remember new grace-period state. */ - if (ULONG_CMP_GE(rnp->gp_seq_needed, rdp->gp_seq_needed) || rdp->gpwrap) + if (ULONG_CMP_LT(rdp->gp_seq_needed, rnp->gp_seq_needed) || rdp->gpwrap) rdp->gp_seq_needed = rnp->gp_seq_needed; WRITE_ONCE(rdp->gpwrap, false); rcu_gpnum_ovf(rnp, rdp);