Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp123393imj; Wed, 13 Feb 2019 05:47:45 -0800 (PST) X-Google-Smtp-Source: AHgI3IaEYtSggQdWO+Up2gMKSfCrXi2OS9lvBjQjs1ADWy1ib0+TG40plQ5mXgDRJd6dJhUSvwQh X-Received: by 2002:a63:9144:: with SMTP id l65mr569776pge.396.1550065664989; Wed, 13 Feb 2019 05:47:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550065664; cv=none; d=google.com; s=arc-20160816; b=DKfNIZmHRZZSKkRx0AYILeQb4y5RPDvQ1kVcSMgGOplq484eG3I59zL+Z4SuhX2UHO 2ks4f9WlDabV7bSe5fXJuSWIvDz3d82DZLjRFUNnjEvCawdnf0wvy6beMhOOvpqKAJtq fyuqc7xEUm1xfSF6AgV5fIBdZxoo7V+OPTmMfpcyRz8wBd1Ij3q6dPJKjRrIkTlkTJ1w fmuO82J4arOW4O9R8n9D4otCP+SUO60TiZYv0fNiu3E4AdD8Qcg9+3zOc0dH62uHOzHs 2wyKBbxJnPef1vwEr5aMku/jLJv6g1sNw7kBqBRbbH0CBDTNeVe4zwnsM0HS+5wfU+iU 9dEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=Tlg2TAeR4MP8095hnK8YmHKHg8mqrIIe7uoZ1FA7ums=; b=cgwd3i1yTcyxBjGwHuvPktxiAJEauWv+DnaxkEC3rm6hPuPnH7V+l/G+8A8BqAoHXd +V9/9UvTuOrpYm4R3NI7jy6L3uJ97g0UrjeG1vFlUD2zG8aF+3pnoZB8HQ1v5Pfj/LlI LA09F6cSr3uZiuXqKr5wv2ZmythDnXcy2v7i64yaymj6y315A4P/uB942oiDXxz7QgKV BUs3Ssr00JWNO5I6ceWrYiyGuNSiCqUPTBx9lj5xzHCp9lxK887PKggpNppfGFFmUOF2 UVChs61bM3LTp/V3IhThnkdwS20aJjer8Z91HgDjVFO9/k40Nunjuc+BlZNZ5XB4Olbo 3F0w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e67si8855591pfa.15.2019.02.13.05.47.28; Wed, 13 Feb 2019 05:47:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391584AbfBMKu5 (ORCPT + 99 others); Wed, 13 Feb 2019 05:50:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33572 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391557AbfBMKuw (ORCPT ); Wed, 13 Feb 2019 05:50:52 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EA70CC04BE25; Wed, 13 Feb 2019 10:50:51 +0000 (UTC) Received: from localhost (ovpn-8-32.pek2.redhat.com [10.72.8.32]) by smtp.corp.redhat.com (Postfix) with ESMTP id BCDAF60863; Wed, 13 Feb 2019 10:50:47 +0000 (UTC) From: Ming Lei To: Christoph Hellwig , Bjorn Helgaas , Thomas Gleixner Cc: Jens Axboe , linux-block@vger.kernel.org, Sagi Grimberg , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Keith Busch , Ming Lei Subject: [PATCH V3 0/5] genirq/affinity: add .calc_sets for improving IRQ allocation & spread Date: Wed, 13 Feb 2019 18:50:36 +0800 Message-Id: <20190213105041.13537-1-ming.lei@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 13 Feb 2019 10:50:52 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Currently pre-caculated set vectors are provided by driver for allocating & spread vectors. This way only works when drivers passes same 'max_vecs' and 'min_vecs' to pci_alloc_irq_vectors_affinity(), also requires driver to retry the allocating & spread. As Bjorn and Keith mentioned, the current usage & interface for irq sets is a bit awkward because the retrying should have been avoided by providing one resonable 'min_vecs'. However, if 'min_vecs' isn't same with 'max_vecs', number of the allocated vectors is unknown before calling pci_alloc_irq_vectors_affinity(), then each set's vectors can't be pre-caculated. Add a new callback of .calc_sets into 'struct irq_affinity' so that driver can caculate set vectors after IRQ vector is allocated and before spread IRQ vectors. V3: - don't mark 'affd' as const in related functions - add sanity check on affd->nr_sets - remove the local variable of 'nr_sets' in irq_create_affinity_masks - set .nr_sets as 2 in nvme - update comment in msi.c V2: - add .calc_sets instead of .setup_affinity() which is easy to be abused by drivers Ming Lei (5): genirq/affinity: don't mark 'affd' as const genirq/affinity: store irq set vectors in 'struct irq_affinity' genirq/affinity: add new callback for caculating set vectors nvme-pci: avoid irq allocation retrying via .calc_sets genirq/affinity: Document .calc_sets as required in case of multiple sets drivers/nvme/host/pci.c | 63 ++++++++++++----------------------------------- drivers/pci/msi.c | 34 ++++++++++++++----------- include/linux/interrupt.h | 13 +++++++--- include/linux/pci.h | 4 +-- kernel/irq/affinity.c | 26 ++++++++++++------- 5 files changed, 64 insertions(+), 76 deletions(-) -- 2.9.5