Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH -next] net: ipvlan_l3s: fix kconfig unmet dependency
 warning
To:     Randy Dunlap <rdunlap@infradead.org>,
        LKML <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Mahesh Bandewar <maheshb@google.com>,
        David Miller <davem@davemloft.net>
Cc:     Andrew Morton <akpm@linux-foundation.org>
References: <c2d5e413-01c8-8da4-aa67-9517a9518a68@infradead.org>
From:   Daniel Borkmann <daniel@iogearbox.net>
Message-ID: <1bc4ec7b-8373-12bc-5f89-3d85415bc5d7@iogearbox.net>
Date:   Wed, 13 Feb 2019 12:23:09 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <c2d5e413-01c8-8da4-aa67-9517a9518a68@infradead.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 02/13/2019 03:02 AM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Fix the kconfig warning in IPVLAN_L3S when neither INET nor IPV6
> is enabled:
> 
> WARNING: unmet direct dependencies detected for NET_L3_MASTER_DEV
>   Depends on [n]: NET [=y] && (INET [=n] || IPV6 [=n])
>   Selected by [y]:
>   - IPVLAN_L3S [=y] && NETDEVICES [=y] && NET_CORE [=y] && NETFILTER [=y]
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Mahesh Bandewar <maheshb@google.com>
> ---
> Seen in mmotm but applies to linux-next.
> 
>  drivers/net/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- mmotm-2019-0212-1537.orig/drivers/net/Kconfig
> +++ mmotm-2019-0212-1537/drivers/net/Kconfig
> @@ -147,6 +147,7 @@ config MACVTAP
>  
>  config IPVLAN_L3S
>  	depends on NETFILTER
> +	depends on INET || IPV6 # same as NET_L3_MASTER_DEV

Thanks for the fix! Lets just do the following instead ...

    depends on IPVLAN

... and we should be all set. Please submit against net-next, thanks!

>  	def_bool y
>  	select NET_L3_MASTER_DEV
>  
> 
>