Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp127440imj; Wed, 13 Feb 2019 05:51:53 -0800 (PST) X-Google-Smtp-Source: AHgI3Ibun3cEf6RIJYhBZBlj0qJwFrgmKFCYFhcYEGve7owreMT7cDEm7wD4G6itj5V+wLkQs2Ua X-Received: by 2002:a63:d104:: with SMTP id k4mr540819pgg.227.1550065913855; Wed, 13 Feb 2019 05:51:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550065913; cv=none; d=google.com; s=arc-20160816; b=w81ibry6tAPbUsq+9CCUe7H7xfea6U3K00eJb7NFUrdPCb91/bHthVNP4e3HQp1CSB VuEiM3wHw34uWezy8JU+BQin4SaLkk+JK10a8K0m0tQ7aXV0QPRAdpQjg4MrX1c/oxro Dt7FxBZ90ZYXH88ffD4RLNY8nmA+o+hCiMYZIoDzp04Y+tokVV/JIU6HN1FL3W6QyRy3 J4Y2ZGiEOeUZT2Rhwq1jK2htatQuBrTSaCyvpmNkCwziwtqcrGMoFG8qxxIEVr1LWKkq RAeRxTp4c7hDDZhBYS/c1bLl5A/ASa8GK09UdwoupeU13zfsBgMahUVTqKVq28J1VpCW eLqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=wq6rcVIEmAw1z/j1p8m0P5LG49rrL3gm4OIKQlNKR/o=; b=HXL7gHqYazQi8roZnTknusnuytjWVSdsU6f37a8KaVbrjMncvGGO4vD8UUiOyeWpjx QZljyDoNAo2Ujc4B4/5+JkxCwDOHnB8sBbwTUTO6hnKIRl+UZwpWj5amqDLx/DUp7woQ W4flY93gmpHMNJyRb4z0eqWqIhbge8WGxrDliBg/fsaYO6KmmAPfMa+EBuVEUccfM8Th QM5yDLBi8nuDOdX09RmtbDMRbw86/e3M8ex8xsxldPDv66t0/+ZRCVzT/UIyjZFPDBeg OHI1CILKjee4Eudu58RE1FT9KoB+AVaFJlokS5vLq+UothNfDGCzqiCIl7Idw04Bd8ta ABiw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d133si15460773pfd.163.2019.02.13.05.51.37; Wed, 13 Feb 2019 05:51:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391868AbfBML0s (ORCPT + 99 others); Wed, 13 Feb 2019 06:26:48 -0500 Received: from mga14.intel.com ([192.55.52.115]:45697 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727977AbfBML0r (ORCPT ); Wed, 13 Feb 2019 06:26:47 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Feb 2019 03:26:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,365,1544515200"; d="scan'208";a="133950012" Received: from sorenthe-mobl1.ger.corp.intel.com (HELO localhost) ([10.249.254.151]) by orsmga002.jf.intel.com with ESMTP; 13 Feb 2019 03:26:40 -0800 Date: Wed, 13 Feb 2019 13:26:40 +0200 From: Jarkko Sakkinen To: bsz@semihalf.com Cc: linux-efi@vger.kernel.org, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, peterhuewe@gmx.de, ard.biesheuvel@linaro.org, tweek@google.com, mingo@kernel.org, hdegoede@redhat.com, leif.lindholm@linaro.org, mw@semihalf.com Subject: Re: [PATCH 4/5] efi/libstub/tpm: Retrieve TPM event log in 2.0 format Message-ID: <20190213112640.GI7087@linux.intel.com> References: <20190211143052.3128-1-bsz@semihalf.com> <20190211143052.3128-5-bsz@semihalf.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190211143052.3128-5-bsz@semihalf.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 11, 2019 at 03:30:51PM +0100, bsz@semihalf.com wrote: > From: Bartosz Szczepanek > > Currently, the only way to get TPM 2.0 event log from firmware is to use > device tree. Introduce efi_retrieve_tpm2_eventlog_2 function to enable > retrieving it from EFI structures. > > Include lib/tpm.c into EFI stub to calculate event sizes using helper > function. > > Signed-off-by: Bartosz Szczepanek Collides with Matthew's changes. I want to land those change first because they are almost production ready. Maybe you should consider reviewing those changes to make sure that they make sense to you so that you can build these on top of after these have landed. There is not rush as I already made my v5.1 PR. These will be released earliest in v5.2. /Jarkko