Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp140397imj; Wed, 13 Feb 2019 06:04:17 -0800 (PST) X-Google-Smtp-Source: AHgI3Ibe3njB5ADI6t3CTmbj3YiA7erncOXmUk61FsXWwTt11afy9UvxYVfqu2jfdbMn2w9LqDxJ X-Received: by 2002:a17:902:4324:: with SMTP id i33mr653479pld.227.1550066657473; Wed, 13 Feb 2019 06:04:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550066657; cv=none; d=google.com; s=arc-20160816; b=SBUNg2Sr0shslMgg4cFZS5C4FmLhsZWrsIao5lmnN60dV/MNBxKjxuEZeewa/WqE7N o9JxdY2dxSyjsjA3HhNgl5/YQpuquAdP7DKn5VKgCP9GBBNA97UGob8vRhPglvU5zVT2 Ared6CInsvI4Fp4qci2K/iDzQLNIbQQwipr5ejMcvaBGoryBsBa8KYsItQASA5NEuKkq n7MGPIS3QAHj6rjn6Nc40mZpyiNImNpH5haO7/Z7tPG8+P92BZ6fNhJsSFcvvSI3ZzRe 2ny0hkysl+ojazgYdSViqihGqST83uoYns3MePvZoAdjlqOWQ7yKslFXk8383B0LQkbi 3gBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=n8CCJEE5qJrEvvsUxRv+p43JH3L72pQLMLiqZ0Ye+Eg=; b=MXfxe69QDuiuzBRPPAWcdTIpT5367s/Sr9DclEMx85HLp+GES3btIrL80EuUbLvSuQ OSaNfTtpv+w1Tu/qvkDJRC8O8NIvoxhheb0h9bAawIQMkDgpoQEEGYiKU63oncaZ5SUq zro0IECQxpaIiajtVGLsHKhDuf5+2xYmL+GTXfLTpWibsgBDIDhxELqwPXFMJyxfwRaN r0qeCOesFx2Dx2Wzlnp0Yis196wRyzMKkgxJLoHUsihbRpiFIRQJXqmnwJRIdiOF5Q2E 3XSoT9hAxDGz5sQ+0x3a+LMF2exBgTeAwyfeke2PV1wmVV23dIqU94JLMhZzXfRjpQoL qZxg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b="EX1d/sv4"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 33si1507878plk.213.2019.02.13.06.03.53; Wed, 13 Feb 2019 06:04:17 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b="EX1d/sv4"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404038AbfBMMU2 (ORCPT + 99 others); Wed, 13 Feb 2019 07:20:28 -0500 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:38180 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730329AbfBMMU1 (ORCPT ); Wed, 13 Feb 2019 07:20:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=n8CCJEE5qJrEvvsUxRv+p43JH3L72pQLMLiqZ0Ye+Eg=; b=EX1d/sv4SQuuSFiLSAvsPEHLF Pi+0IYbWcsvUMelC1fVfmO5ZrqD1tLAgPpGabfS3XXjOUndT3kvt32VezfSXwgFUbUsoKOxjeEcBM Wmzh2lVuqlPvHPhB3psqQarT8hmqIf6zc3mw1TfnyOvLWznb5FA/bBLJY8gsbnlsRBSak=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1gttWO-0004GI-LW; Wed, 13 Feb 2019 12:20:12 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id 328301128159; Wed, 13 Feb 2019 12:20:12 +0000 (GMT) Date: Wed, 13 Feb 2019 12:20:12 +0000 From: Mark Brown To: Baolin Wang Cc: robh+dt@kernel.org, mark.rutland@arm.com, orsonzhai@gmail.com, zhang.lyra@gmail.com, lanqing.liu@unisoc.com, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/3] spi: sprd: spi: sprd: Add DMA mode support Message-ID: <20190213122012.GE7540@sirena.org.uk> References: <11e55b5f9b0d83649a5b81c7e3fdb667cd3ddc5b.1550043082.git.baolin.wang@linaro.org> <3f9d23d4b250c5046f8c3411606aa9ffe807edd8.1550043082.git.baolin.wang@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="gMR3gsNFwZpnI/Ts" Content-Disposition: inline In-Reply-To: <3f9d23d4b250c5046f8c3411606aa9ffe807edd8.1550043082.git.baolin.wang@linaro.org> X-Cookie: Nothing is but what is not. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --gMR3gsNFwZpnI/Ts Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Feb 13, 2019 at 03:36:11PM +0800, Baolin Wang wrote: > +enum sprd_spi_dma_channel { > + SPI_RX, > + SPI_TX, > + SPI_MAX, > +}; It'd have been better to namespace these (SPRD_SPI_ or something) in case of conflicts. That's really minor though and everything else looks good so I'll go ahead and apply, thanks! --gMR3gsNFwZpnI/Ts Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlxkC3sACgkQJNaLcl1U h9CuBAf/dxGjyh/qcii3tgS/K0gNwj7+wo5ZZcI1DGGxewwd6fBiFLO0RRjy2Twz M/+PxIm4IZyYuCRDhhgSym5gE5LpJQZCPtIKaEladCecjWcYiOTNPwpvZwTxI/jy QgyfOn3qfQllW/xnUrvKffxxBFX30a3qwui9glhJmpmsxvMHau49wEAgOEDql+KO TiFNAckqKlBrLQagonHd36kfp2zncx1Pp4drhk0SaKJ03wu7R5Gl0LpheQDt97Ae Hs+6XbjKYjDZZmiTV1PmHUxzrHp9AHv+mgW36SDh0b4rd0JJTsaMf7Tsny3MWU0t tTZYrk5YCvvzQOcTAR4FYykSY/GrkQ== =x+WH -----END PGP SIGNATURE----- --gMR3gsNFwZpnI/Ts--