Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp171840imj; Wed, 13 Feb 2019 06:32:23 -0800 (PST) X-Google-Smtp-Source: AHgI3IbRHKTy/CdEHP2wNB2yzWEoayB/Ixj3GR5f1CW1kStRN6yeCVWkP1u//ZcY+m014r29N8gy X-Received: by 2002:a62:9f1a:: with SMTP id g26mr789242pfe.123.1550068343677; Wed, 13 Feb 2019 06:32:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550068343; cv=none; d=google.com; s=arc-20160816; b=DPKYzeyOHoE6wHQ6fOmblbPdmXYdnhYOZm4PfeNo5xxv2DKlwDvxIe17NQjHFPx//f P4uI8vwZ0FsA1AKEGQdzLRaTvenG63KdfU9AtyPKZWRIiH12gOeQhcuvnrBW+II5iPEx A2ElL5aX67IlyjD8P7N/lF8jFqcd6QHc5JnT7Gfc9RubHC3ZkcJ3AfGLLmp7dSOu+QNY Eyy2LOpWCdTXxYSdAC1qq7kx0sPu6l91X8zdZOo55aN4Fybb5JGfIe41LvXlAgWgx5Yv Sui1qebBPMpCIo7jIMCaEUg8CwFiLLzH9+E+Yd12pG+Jsfp9hGbiM7lwK2MOwlRDVXDD MFlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=OrDra6RN/nWg7yjMYeikrCFx5quEOnHc3L9yCfDUMu4=; b=TPS/2qt3wzyTwKg34DWDmfJepTuy0drjnOSBHepgpiYzNKG9DcImZCwbWnDPZfGBJW adHIWnoEcDuQmtkri/z6nfLdpOnTKhsYJlNTjwvRcC2eCmTDe05+MaFDPv/xMHV9wU1y OwvpYww88AXdF26/bcp9jPdauIisD8WFESdNhAGkR/XVJshD/+Nsmfz80RtPhVYCA57S eIvuXrk+/aEvwumL0srIYA1MTuZoFmsw8/MLgc6DF3g9I56FD3/4WJrn4FW4N2Ra5SrL vDOIXGYKhcNHTQhfo8n1BvYu9cezFTQ+czjPWweTdItjtgb73hhNhfAhvrpbEe/swmRZ 6akQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=VF5uumri; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x8si16036701plv.137.2019.02.13.06.32.07; Wed, 13 Feb 2019 06:32:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=VF5uumri; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389582AbfBMNNr (ORCPT + 99 others); Wed, 13 Feb 2019 08:13:47 -0500 Received: from merlin.infradead.org ([205.233.59.134]:42650 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730600AbfBMNNr (ORCPT ); Wed, 13 Feb 2019 08:13:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=OrDra6RN/nWg7yjMYeikrCFx5quEOnHc3L9yCfDUMu4=; b=VF5uumriixGCW2D/9JGZ+0itT mYX905LLNIna/dqB+eZD3nQepPjnzqgAM9dNnS0pZM9l5rw7mhhEF/uDNyjhEva+MunpBjnWk0hQ3 5XDJGCEVYmwENk7xueaXjZr/aFOs0aS4ctbsapyf/J66Ef2eUzJ2zxYxWoKy72mHKaqeSOjQlZ0zF bArf8l/J+fiS/m0JK3/NbqCFdR6NARor4yG93rbdEaYCHv9eZ9PKuqLwv7kalQWYYXMobaf99H7cb sh3KoRC/bZ1TN1n21n627fWWIUa2pdzwodPpJyAiYuYgiaGsBwy3J9aGpMbAOr2pxKuyuIQNCgFpv gnp07uaIg==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1gtuM2-0007xB-RH; Wed, 13 Feb 2019 13:13:35 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 9E9B720F51B12; Wed, 13 Feb 2019 14:13:33 +0100 (CET) Date: Wed, 13 Feb 2019 14:13:33 +0100 From: Peter Zijlstra To: "Rantala, Tommi T. (Nokia - FI/Espoo)" Cc: "linux-kernel@vger.kernel.org" , "gregkh@linuxfoundation.org" , "mingo@kernel.org" , "jolsa@redhat.com" , "torvalds@linux-foundation.org" , "tglx@linutronix.de" , "stable@vger.kernel.org" , "namhyung@kernel.org" , "mark.rutland@arm.com" , "acme@redhat.com" , "alexander.shishkin@linux.intel.com" , "julien.thierry@arm.com" Subject: Re: [PATCH 4.14 198/205] perf/core: Dont WARN() for impossible ring-buffer sizes Message-ID: <20190213131333.GT32494@hirez.programming.kicks-ass.net> References: <20190211141827.214852402@linuxfoundation.org> <20190211141841.367111122@linuxfoundation.org> <1eb319822aa9f75f423a7790e78315e7672036b9.camel@nokia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1eb319822aa9f75f423a7790e78315e7672036b9.camel@nokia.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 13, 2019 at 01:03:39PM +0000, Rantala, Tommi T. (Nokia - FI/Espoo) wrote: > Changing the patch like this fixes it... > > - if (order_base_2(size) >= MAX_ORDER) > + if (order_base_2(size) > MAX_ORDER) That's wrong too.. There is this queued: http://lkml.kernel.org/r/tip-528871b456026e6127d95b1b2bd8e3a003dc1614@git.kernel.org