Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261719AbUCKVZX (ORCPT ); Thu, 11 Mar 2004 16:25:23 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261729AbUCKVZX (ORCPT ); Thu, 11 Mar 2004 16:25:23 -0500 Received: from gateway-1237.mvista.com ([12.44.186.158]:2546 "EHLO av.mvista.com") by vger.kernel.org with ESMTP id S261719AbUCKVZO (ORCPT ); Thu, 11 Mar 2004 16:25:14 -0500 Message-ID: <4050D92B.7000802@mvista.com> Date: Thu, 11 Mar 2004 13:24:59 -0800 From: George Anzinger Organization: MontaVista Software User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20030225 X-Accept-Language: en-us, en MIME-Version: 1.0 To: "Amit S. Kale" CC: Tom Rini , Kernel Mailing List , Pavel Machek , kgdb-bugreport@lists.sourceforge.net Subject: Re: [KGDB PATCH][7/7] Move debugger_entry() References: <20040227212301.GC1052@smtp.west.cox.net> <200403011538.44953.amitkale@emsyssoft.com> <40453023.6000004@mvista.com> <200403031115.44125.amitkale@emsyssoft.com> In-Reply-To: <200403031115.44125.amitkale@emsyssoft.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2757 Lines: 79 Amit S. Kale wrote: > On Wednesday 03 Mar 2004 6:38 am, George Anzinger wrote: > >>Amit S. Kale wrote: >> >>>OK to checkin. >>> >>>-Amit >>> >>>On Saturday 28 Feb 2004 3:24 am, Tom Rini wrote: >>> >>>>Hello. When we use kgdboe, we can't use it until do_basic_setup() is >>>>done. So we have two options, not allow kgdboe to use the initial >>>>breakpoint or move debugger_entry() to be past the point where kgdboe >>>>will be usable. I've opted for the latter, as if an earlier breakpoint >>>>is needed you can still use serial and throw >>>>kgdb_schedule_breakpoint/breakpoint where desired. >>>> >>>>--- linux-2.6.3-rc4/init/main.c 2004-02-17 09:51:19.000000000 -0700 >>>>+++ linux-2.6.3-rc4-kgdb/init/main.c 2004-02-17 11:33:51.854388988 -0700 >>>>@@ -581,6 +582,7 @@ static int init(void * unused) >>>> >>>> smp_init(); >>>> do_basic_setup(); >>>>+ debugger_entry(); >> >>It would be nice to not need this. Could it be a side effect of >>configuring the interface or some such so we don't have to patch >>init/main.c > > > I attempted doing this when I was trying to code a netpoll independent > ethernet interface. I couldn't do without it. I needed one hook to kgdb in > init to mark completion of smp_init. If an interface was ready, that hook > called breakpoint. A similar hook was placed in interface initialization > code, it called breakpoint, if kgdb core was ready on account of smp_init > completion. > I guess the real question is why do you need to wait so long? What is it that needs to be done prior to this call? On the other hand, I have a late call (I use module init) to set up the interrupt handler for the UART, which needs to happen after malloc is working. This, however, does not cause, of it self, a break. > -Amit > > > > >>-g >> >> >>>> prepare_namespace(); >>> >>>- >>>To unsubscribe from this list: send the line "unsubscribe linux-kernel" >>>in the body of a message to majordomo@vger.kernel.org >>>More majordomo info at http://vger.kernel.org/majordomo-info.html >>>Please read the FAQ at http://www.tux.org/lkml/ > > > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- George Anzinger george@mvista.com High-res-timers: http://sourceforge.net/projects/high-res-timers/ Preemption patch: http://www.kernel.org/pub/linux/kernel/people/rml - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/