Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <3d1f18412a927f69c733b6ed31659b7770610442.1550062410.git.baolin.wang@linaro.org>
In-Reply-To: <3d1f18412a927f69c733b6ed31659b7770610442.1550062410.git.baolin.wang@linaro.org>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Wed, 13 Feb 2019 15:28:36 +0100
Message-ID: <CAK8P3a1Ad+u9DHXkAe=p6pzCm0b24wvh8NH+Y3n6RRup7maBuA@mail.gmail.com>
Subject: Re: [PATCH] mfd: sc27xx: Use SoC compatible string for PMIC devices
To:     Baolin Wang <baolin.wang@linaro.org>
Cc:     Lee Jones <lee.jones@linaro.org>, Mark Brown <broonie@kernel.org>,
        Orson Zhai <orsonzhai@gmail.com>,
        Lyra Zhang <zhang.lyra@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Feb 13, 2019 at 1:57 PM Baolin Wang <baolin.wang@linaro.org> wrote:
>
> We should use SoC compatible string in stead of wildcard string for
> PMIC child devices.
>
> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>

Looks good. I had a look at arch/arm64/boot/dts/sprd/sc2731.dtsi
as well, which contains lines such as

compatible = "sprd,sc27xx-efuse", "sprd,sc2731-efuse";

which fortunately work with both variants of the driver.
Just to make sure we have the same understanding though:

- Other drivers will leave out the 27xx part and just do
  compatible = sprd,sc2732-efuse", "sprd,sc2731-efuse";

- When you specific a generic name (such as the sc2731 part),
  the more specific one (e.g. sc2732) needs to come /first/.
  The current DT appears to have those mixed up.

      Arnd