Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp220512imj; Wed, 13 Feb 2019 07:16:26 -0800 (PST) X-Google-Smtp-Source: AHgI3IZDvW3iIEuirpvgd1OcNpujDhM88MnZvbVIqo29NlY7TsqM9SatJo+TAu5DBypdSLOmsN1J X-Received: by 2002:a63:eb41:: with SMTP id b1mr935023pgk.188.1550070986526; Wed, 13 Feb 2019 07:16:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550070986; cv=none; d=google.com; s=arc-20160816; b=RDFI/UK3TpHZFU3NgD5utZSZypYDnGLrkAdqgw8OUguwtk5MyNm4o3Rw5fMRSTUbaz oPah9i48ojMo6imYcCGDwSsFMClycRTcqVVJkaTa8h0h8Ru9qgPJ3G1rQShJprjRuj1Q g4puDBcCjk/Ygh6oVowSNSvXmHbAIYthJ3/dFr1AmAPNBgZO7uqnWuennlqM9Ol++3PU 8aE0+nmG5XmybqXSYhl/+OXqcUOXQfBLiW945Q9vfrR+0sr15SH/LjVghKqgIZroCPfz 4fAX072mLho0odOYbMG0ZC/e98NCDlBIXFV4/tz+hYPqUZJwISXtmGJy40usKdZ4jKkz QH0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=1E5DPm3qgeniIx5Gi272hRsM9mfOnn/4ZxCuFF39vOg=; b=BJyCsMbpLaTtLrKFqTIvhVNqOXZxJKkreKbespYBWhhul/x5LeDwp4RfdEIBNZBjyh 3MBDwVe1bWaIZbcNfSrgLMOI/90bO5q44tpjVl/kwuNvIvW8zz+JUo6r9/P7mROnoY/3 cfkvYggfCelVWbcPQOfvgN5AsuNBFr0eaPx0DG6dFrAzSSbOzVzN4vkH+JhRVqfrNDgw Av25frFzcF9P0YFaFxp1e1NUoeG7Td1AWLCJpae01qvm/DfVPtxjzHhnK9RCdpXzpILr HwLu5zrb9LYJCaPA4+TZc/sfuQoFxm8DrQGWwSdlxmNjsHPWjm2Vi3h8b5Qai1wzX6Zb Lb1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=noxi15mC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u131si8045445pgc.287.2019.02.13.07.16.10; Wed, 13 Feb 2019 07:16:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=noxi15mC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389596AbfBMOgL (ORCPT + 99 others); Wed, 13 Feb 2019 09:36:11 -0500 Received: from mail-pg1-f195.google.com ([209.85.215.195]:36242 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733163AbfBMOgL (ORCPT ); Wed, 13 Feb 2019 09:36:11 -0500 Received: by mail-pg1-f195.google.com with SMTP id r124so1223046pgr.3 for ; Wed, 13 Feb 2019 06:36:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=1E5DPm3qgeniIx5Gi272hRsM9mfOnn/4ZxCuFF39vOg=; b=noxi15mCVj5J1M0qcQepb/SBoqa0JfYACQW52WNKPyrf+a3v3mUnq1zNP5nkR+IbVL 0OAGEwVoR1uJwPtJUG8GcARF2PBYunnzNUIHBPtCDlZ4rxJl4PC/LwyffJLk2DjOkAAr 6jG2Yxpx1VdQDUkKg1abt0m/HM5K5xlGo48gVBsXBHg/Z9buu558QNXw1U2CviOZhgM0 IfjaOP8eA+ul6x0XoEk6c00TCKv53O0POpuVBmjU2+Wgd+KdvlQC2fd8Q2DXcWEGgEz4 xjb+yBd8Xcl6s4euiWjEhAtg/aSNWiE0PUZlhtdQ0rc9QCfOQo2bCvnmxnez7WXYMDmR EtiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1E5DPm3qgeniIx5Gi272hRsM9mfOnn/4ZxCuFF39vOg=; b=CEKqNoQ9r8DxNA5O8dkBaGmEtunWfzjuVYnlW8a+PbrWO/E4mSNdL23wf4eoD8Uere b19oXrZCLHQObmterf6QOxjQxS/w6xFz29+3erwjw7LWLUCDdMjEtMQkHDXhlqqBsox7 gvCOLwN9iK5xqWzvyGDXq9mR+ktXIowmaRsvFsHOztHwVbK5NORd8usdDDhfg3oKhbWG u0VRU51BNdXNaTPDC+sU+/Rjc7M9+aDELagP79XwTDE4vWCaWQJ+Qkmd9e0dH5ovsrIn jj6YpYth7FZhrJ8HewMs7tTBanwqrkzrsaQ2Yz0iLVDuObJhAQacd9wROUm33PQYcnTR mqaQ== X-Gm-Message-State: AHQUAua2Yh4km1818K5X2aOuYFayfNCRPm3waTPrI0vjfFojPs8sVcYK pViLPpoJDPwC9CLrlFuhUpjkSg== X-Received: by 2002:a63:89c7:: with SMTP id v190mr715030pgd.370.1550068570200; Wed, 13 Feb 2019 06:36:10 -0800 (PST) Received: from [192.168.1.121] (66.29.188.166.static.utbb.net. [66.29.188.166]) by smtp.gmail.com with ESMTPSA id e9sm74152165pfh.42.2019.02.13.06.36.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Feb 2019 06:36:09 -0800 (PST) Subject: Re: [PATCH V3 0/5] genirq/affinity: add .calc_sets for improving IRQ allocation & spread To: Ming Lei , Christoph Hellwig , Bjorn Helgaas , Thomas Gleixner Cc: linux-block@vger.kernel.org, Sagi Grimberg , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Keith Busch References: <20190213105041.13537-1-ming.lei@redhat.com> From: Jens Axboe Message-ID: Date: Wed, 13 Feb 2019 07:36:01 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190213105041.13537-1-ming.lei@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/13/19 3:50 AM, Ming Lei wrote: > Hi, > > Currently pre-caculated set vectors are provided by driver for > allocating & spread vectors. This way only works when drivers passes > same 'max_vecs' and 'min_vecs' to pci_alloc_irq_vectors_affinity(), > also requires driver to retry the allocating & spread. > > As Bjorn and Keith mentioned, the current usage & interface for irq sets > is a bit awkward because the retrying should have been avoided by providing > one resonable 'min_vecs'. However, if 'min_vecs' isn't same with > 'max_vecs', number of the allocated vectors is unknown before calling > pci_alloc_irq_vectors_affinity(), then each set's vectors can't be > pre-caculated. > > Add a new callback of .calc_sets into 'struct irq_affinity' so that > driver can caculate set vectors after IRQ vector is allocated and > before spread IRQ vectors. Much improved, thanks for doing this work. You can add Reviewed-by: Jens Axboe if you want. -- Jens Axboe