Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp246947imj; Wed, 13 Feb 2019 07:41:48 -0800 (PST) X-Google-Smtp-Source: AHgI3IYjmzBTfOW1b/2JZNGB//unPqAkgxd9iQyrz1nu0yjN1iUsbfxlKj4k8H76PCX5FghFQ8En X-Received: by 2002:a17:902:2:: with SMTP id 2mr1171009pla.228.1550072508179; Wed, 13 Feb 2019 07:41:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550072508; cv=none; d=google.com; s=arc-20160816; b=xyZK2XmFJB3/cwYoGnDudw4mG/G174kbA1wZdMgvzE5cDc2++u2TV9ZzJVpq0ghxAB HKJy8DtNeqwGG+aEiaQ9E9D42t5n6Hc9Oxg6zIaosPUlxKUjPiunuwgi8Tfe5RTBnQaI ICjORzaMCXOzmZvvOEk7cHAxB9Fcn714WbuFvB6tDtaSv0d/e1M0o0s3K/tbjyg9JBkP AFWG7DafXHVSQaCPPtUv2kB2ecqTWOVcTt+iuGBjls/ahJkkhsNgafoehfsN2gNL1KKZ +8ye2TSXLjY+ccG2rj+Fmx0okJzSFnI7uXlwJLmEzRF4/jL6mFsBUOxclW2xqNdk5JNh 8MzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=S+qAB0o1dklfD2jD0FSW2FLcpsA1s0Br73aLOSI4uec=; b=ZfIIKAT4YMr21Kc09g4M+B+1r66jtDCNzpYs+HYf+mTMNgxFcnmY0I9fzozOGbE8ml NvgCWtqpv/GRVFw/NxgLPE8yS2M2DrwbKieJXC+Pd/T5q7sxUYW5wunRncoWrggS1pB2 hKiSQpcRaxuIISyWFuk7DrjWoFCeLISGNRTrU93tWxdIIAha+SqsPg6laBUcieKf4iD8 98veoONyr1N7dVmA22dqb1hkjC9m9VtvBwnCd3tw5r1T1TWoNoRY227DZNbObzoEEHCd WGDh5hpHTPI5FZsY6XhSSmvUDcJ98qyS9Hcj0zjbyizdmcZyYzslUYGWQNWjhdzQB9t/ zTXg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j11si4135844plb.253.2019.02.13.07.41.32; Wed, 13 Feb 2019 07:41:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404197AbfBMPIG (ORCPT + 99 others); Wed, 13 Feb 2019 10:08:06 -0500 Received: from mga06.intel.com ([134.134.136.31]:11815 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726317AbfBMPIE (ORCPT ); Wed, 13 Feb 2019 10:08:04 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Feb 2019 07:08:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,365,1544515200"; d="scan'208";a="299437306" Received: from rajneesh-desk.iind.intel.com ([10.223.86.34]) by orsmga005.jf.intel.com with ESMTP; 13 Feb 2019 07:08:01 -0800 From: Rajneesh Bhardwaj To: platform-driver-x86@vger.kernel.org Cc: dvhart@infradead.org, andy@infradead.org, linux-kernel@vger.kernel.org, Rajneesh Bhardwaj , "David E. Box" , Srinivas Pandruvada Subject: [PATCH v2 04/10] platform/x86: intel_pmc_core: Fix file permissions for ltr_show Date: Wed, 13 Feb 2019 20:38:04 +0530 Message-Id: <20190213150810.32750-5-rajneesh.bhardwaj@linux.intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190213150810.32750-1-rajneesh.bhardwaj@linux.intel.com> References: <20190213150810.32750-1-rajneesh.bhardwaj@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org File permissions for ltr_show attribute should be similar to other debugfs attributes created by this driver. '0644' should be used only when there is a write operation desired such as for ltr_ignore. Cc: "David E. Box" Cc: Srinivas Pandruvada [rajneesh: folded in correct SHA1 as reported by Stephen Rothwell] Fixes: 2eb150558bb7 ("platform/x86: intel_pmc_core: Show Latency Tolerance info") Signed-off-by: Rajneesh Bhardwaj --- drivers/platform/x86/intel_pmc_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/intel_pmc_core.c b/drivers/platform/x86/intel_pmc_core.c index 80936e6bdc61..125461ca2927 100644 --- a/drivers/platform/x86/intel_pmc_core.c +++ b/drivers/platform/x86/intel_pmc_core.c @@ -702,7 +702,7 @@ static int pmc_core_dbgfs_register(struct pmc_dev *pmcdev) debugfs_create_file("ltr_ignore", 0644, dir, pmcdev, &pmc_core_ltr_ignore_ops); - debugfs_create_file("ltr_show", 0644, dir, pmcdev, &pmc_core_ltr_fops); + debugfs_create_file("ltr_show", 0444, dir, pmcdev, &pmc_core_ltr_fops); if (pmcdev->map->pll_sts) debugfs_create_file("pll_status", 0444, dir, pmcdev, -- 2.17.1