Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp266661imj; Wed, 13 Feb 2019 08:02:36 -0800 (PST) X-Google-Smtp-Source: AHgI3IYfx9UhwqXX/8hxYkO5GsJV/VVNC4h1jXJ/6IeB9nBqZTJ+pUFVvlYlRXTBj25R2ifQs2o1 X-Received: by 2002:a17:902:5a5:: with SMTP id f34mr1192296plf.161.1550073756196; Wed, 13 Feb 2019 08:02:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550073756; cv=none; d=google.com; s=arc-20160816; b=jy2re519Y2f1Vr/NdIlAds3EjvgyfypM90FrDKFoVj+z7VLlL6tiG8f9UMuzJiRHH6 DHY6drFonEvM+cBkulW0neNJm0+28Pk/B6izqMJlk/hSmAA0MxR35a+jrz+eIBPAuwpv 3LDJzJRCecfaLDvnEfr/f6MGGY2StNr04CjmsOrLe2vObUoFmZe3Pz8nwrklR+nbmPI6 82lBm+PNsxPblKO2+Zc6frR2tpFfJAvNdLwU6mntw1OiYh4eKawbIojp/UF8xq5b9fmc gl667y9qskuP1oHpZWM9X/WVabQHD1PxS6J78N32aCwJ3eQ81OXK4Ts+P2dwW5xVH2g6 985Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=lcmksHWGwSDXOrKAmTNKeWMLBrZoin/0R2U8zaZjtfM=; b=PKyM7GzPWdZr/W2S/dBOmyP4ZTlLoLuD+ZKpzeEB2ZbkWa1Uaqs3Nmgp47DC1wZXl9 /6igAqXmxLD/t16dsjkXnTF01xhrBdLbSzPsLOk89zrvdfpaLguglvMSskqbebFL5xYT A94dY+3inAIdsmI+JxH2MWzjFJzpBq3lDuxSuk817mEQ2JbZlP2MWrBusZRFTLZ+LQU4 DnFCr/tDs8zdbqbKB0RwP1RRyqxh171yrj7h0LYVaKHTcbC7N4i21DDlvRmzKv15lMuC XuuXbkg0jnYxP8eNxLWUcmwRjuhHSIu/kiym6L4sBwo2CHQmUhbs2jYGilwksgZ4Q+SY eZow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=QGGNe2M8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s7si15734643plq.237.2019.02.13.08.01.41; Wed, 13 Feb 2019 08:02:36 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=QGGNe2M8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392311AbfBMPdN (ORCPT + 99 others); Wed, 13 Feb 2019 10:33:13 -0500 Received: from mail-pl1-f193.google.com ([209.85.214.193]:44895 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730097AbfBMPdM (ORCPT ); Wed, 13 Feb 2019 10:33:12 -0500 Received: by mail-pl1-f193.google.com with SMTP id p4so1312747plq.11; Wed, 13 Feb 2019 07:33:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lcmksHWGwSDXOrKAmTNKeWMLBrZoin/0R2U8zaZjtfM=; b=QGGNe2M8ZpVaRZDHTuxtVY/7HkJzKR/ECoksK7XhNo/3cZbRTIelasU8jZAXhSv9rJ 6d+o+n8kIQ+bbegsurMol1BtY+LDVkXcBJncgWdmqmbDQMMkGLhZn3dMKkEF5kM7YJza hjFL1UpD/muK6uBB8yyFZvz3AmpwYCRc46gRqSoKGMQ76mAe5c4S6JnH4HEko/O1V7fv gyuu/9lNjapNQTRkiS02Ep8SBOmRWvLKRk2u8Ge30rsFlMnnyHrnsFMx9Lsq1Vbx2vLU viy8xv+pnz0Vd1D6iPiy0cPq6EUTF715VMZver8TwIVD4meKGPHgWAxk0Nj0FxS7bR9Z q/oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lcmksHWGwSDXOrKAmTNKeWMLBrZoin/0R2U8zaZjtfM=; b=IWh8yOZR48GIAgSqFC2MsnThKjOZwIBNsR9caXHQPPCROo67FXPsUnx9UStf+6uWI8 orpqIMaHaS3aSgHkOcR/Q58uIlz1L71SYkOeIarimXSBqPchrm2vak4CWCo8qJCSGx5F dii3Bg8l9yqukmKADwcKa7z81HGjOJGLVTp+qAxxRIXSrWzSEhOY9ofhndryD5couijG Zj3Mja6NbLJKiM8plg4iTZHn1BtCHt6EoFGh2sdDX4RaPfgPxygiIsXYAFrNy81O99yb C5KWKI09yJrUjwQemng9wKXaxC2oC8twgRzcZ0mqkAi35Cp1HwfuKbP8G9xXo2QhNLBU FmEw== X-Gm-Message-State: AHQUAubJN792V70qB9/Cw3JT1zRimlS9oJpCFON7RMqvX+gKx5vqEas5 uriMWJOL4vVq9p77tjMvtSdS4ovR3hMDBxgIGCU= X-Received: by 2002:a17:902:bc88:: with SMTP id bb8mr1150750plb.12.1550071991664; Wed, 13 Feb 2019 07:33:11 -0800 (PST) MIME-Version: 1.0 References: <20190213150810.32750-1-rajneesh.bhardwaj@linux.intel.com> In-Reply-To: <20190213150810.32750-1-rajneesh.bhardwaj@linux.intel.com> From: Andy Shevchenko Date: Wed, 13 Feb 2019 17:33:00 +0200 Message-ID: Subject: Re: [PATCH v2 00/10] ICL support and other enhancements for PMC Core To: Rajneesh Bhardwaj Cc: Platform Driver , Darren Hart , Andy Shevchenko , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 13, 2019 at 5:08 PM Rajneesh Bhardwaj wrote: > > This patch series provides Icelake support for PMC Core driver and while > doing so it introduces the Icelake Mobile to intel-family.h as per the > CPUID from below Coreboot link > https://github.com/coreboot/coreboot/blob/5ebcea3aaaa3cd358bc5bccaa156b13a6ef25df6/src/soc/intel/common/block/include/intelblocks/mp_init.h > and provides some fixes and enhancements to the driver. It's not applicable to my tree. > Changes in v2: > * Addressed review comments from Thomas > * Added tags revieved > * Folded in SHA1 suggestions from Stephen Rothwell, though Andy might want to > fix it via rebasing > * Rebased and tested with Linux v5.0.0-rc6 > > This series: > - Adds ICL U/Y CPUID to intel-family.h > - Enables PMC driver for ICL > - Introduces a new "package cstate show" feature > - Fixes a customer issue related to S0ix on latest HP laptops > - Fixes some minor bugs > > Rajneesh Bhardwaj (10): > platform/x86: intel_pmc_core: Handle CFL regmap properly > platform/x86: intel_pmc_core: Fix PCH IP sts reading > platform/x86: intel_pmc_core: Fix PCH IP name > platform/x86: intel_pmc_core: Fix file permissions for ltr_show > platform/x86: intel_pmc_core: Include Reserved IP for LTR > x86/cpu: Add Icelake to Intel family > platform/x86: intel_pmc_core: Convert to INTEL_CPU_FAM6 macro > platform/x86: intel_pmc_core: Add ICL platform support > platform/x86: intel_pmc_core: Add Package cstates residency info > platform/x86: intel_pmc_core: Quirk to ignore XTAL shutdown > > arch/x86/include/asm/intel-family.h | 2 + > drivers/platform/x86/intel_pmc_core.c | 155 +++++++++++++++++++++----- > drivers/platform/x86/intel_pmc_core.h | 14 ++- > 3 files changed, 145 insertions(+), 26 deletions(-) > > -- > 2.17.1 > -- With Best Regards, Andy Shevchenko