Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp287854imj; Wed, 13 Feb 2019 08:20:26 -0800 (PST) X-Google-Smtp-Source: AHgI3IaVEKei4pI/POzIiuy7pCa01mecuKrSXjyMYv9VfDHiRN++gKiMQ5Em+Bu7QiRQ8fKHoIZu X-Received: by 2002:a63:d50c:: with SMTP id c12mr1204647pgg.32.1550074825934; Wed, 13 Feb 2019 08:20:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550074825; cv=none; d=google.com; s=arc-20160816; b=1GMMf30WqegnsZvjA3f+h5IhOm9cSE5zzXcDjuNVCJbYk2FORMmCtsuRirzMCmI++T vW1jukKK19vNHUsb1hKQnzsp5EwUpKs2Boxy6LT5hdiY7GOLcTByHtQzvJwe52SdOCoN 0S3erQ7rr9D/Ul6EH3WWMPMDOF3cCjPftxq3TcZ9gbMSaFBpsvy2LroGItlooLKrZBxc RWwYTCIj4VXPBgRUjNX9z/TqTN96a6NogeDRH8lxA491Iga5g4/T8IdweM+VFkhtTbvN ja2I0pUr5IPjkushiUzUlOPW76ECpA6/V9nFGfAl8xP/MWUD5LX2f57fk7A0ifO3jedQ e77g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:cc:to:subject:from:message-id :dkim-signature; bh=8ErHIAMKq6v8CWQ3FEQ3Gj9oj8klOJFs8lShbzUGTeU=; b=c8ktgGlt93cCMEn5u+8L9mwAaPPP60wg6g+Vw6jlSb+eOaKsorYJHVd0lQHcEGo8Ta xp+aTCCFmLA3X2EbiZkOqdLmwYyd0ArbcHTY8SuWxRF/er7mkLA55msoxm+qZhukSqGk N64AnjIaqSn8IAWmURI0tOe6vPV1yMmGergitXlNIKwHggoORsIXvx3brobjWwoKs5kK NXHKCsnQJ8l5/OpHcWa2W+qQyrjihcrMZsHN2p5IyQA/wDfO8BAxmMj8CXzlHnosQI/S 15VpcvXOphN8te00c5b8OJob+P6MFujfY7n7v6RJeOo2Tmsiw/7oMMPik1FhR7i8oygt wUcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@c-s.fr header.s=mail header.b=Awv3v4aW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g21si16375518pfg.49.2019.02.13.08.20.04; Wed, 13 Feb 2019 08:20:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@c-s.fr header.s=mail header.b=Awv3v4aW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392270AbfBMQGW (ORCPT + 99 others); Wed, 13 Feb 2019 11:06:22 -0500 Received: from pegase1.c-s.fr ([93.17.236.30]:22216 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729649AbfBMQGW (ORCPT ); Wed, 13 Feb 2019 11:06:22 -0500 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 4404By67BYz9vKHs; Wed, 13 Feb 2019 17:06:18 +0100 (CET) Authentication-Results: localhost; dkim=pass reason="1024-bit key; insecure key" header.d=c-s.fr header.i=@c-s.fr header.b=Awv3v4aW; dkim-adsp=pass; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id JkcZxiPCcmkG; Wed, 13 Feb 2019 17:06:18 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 4404By50clz9vKHr; Wed, 13 Feb 2019 17:06:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail; t=1550073978; bh=8ErHIAMKq6v8CWQ3FEQ3Gj9oj8klOJFs8lShbzUGTeU=; h=From:Subject:To:Cc:Date:From; b=Awv3v4aWzbSnc+27jOBcFaUk6FRiJ46Y5jYMcBZTjTt6nFEqiBekG05fZYOW0qSmh GW5S09PUcYLKy3mrVYHRc6pZu0H3JrypbMujRjkoLjirv7x/yBWKHAlHhQyhudEk0l W0h140KRJJWl75ge/IAw43h31bDi8bvrE5iSQPng= Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 3F39A8B876; Wed, 13 Feb 2019 17:06:20 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id SPCs4reF-30U; Wed, 13 Feb 2019 17:06:20 +0100 (CET) Received: from po16846vm.idsi0.si.c-s.fr (po15451.idsi0.si.c-s.fr [172.25.231.2]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 231358B756; Wed, 13 Feb 2019 17:06:20 +0100 (CET) Received: by po16846vm.idsi0.si.c-s.fr (Postfix, from userid 0) id 04E2869D7C; Wed, 13 Feb 2019 16:06:19 +0000 (UTC) Message-Id: <21f171c0cbd460905a134ce9b9afc2ecb5277269.1550073540.git.christophe.leroy@c-s.fr> From: Christophe Leroy Subject: [PATCH v3 1/2] powerpc/8xx: replace most #ifdef by IS_ENABLED() in 8xx_mmu.c To: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Date: Wed, 13 Feb 2019 16:06:19 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch replaces most #ifdef mess by IS_ENABLED() in 8xx_mmu.c This has the advantage of allowing syntax verification at compile time regardless of selected options. Signed-off-by: Christophe Leroy --- v3: no change v2: left CONFIG_BDI_SWITCH change aside as it goes away in another patch arch/powerpc/mm/8xx_mmu.c | 44 +++++++++++++++++++------------------------- 1 file changed, 19 insertions(+), 25 deletions(-) diff --git a/arch/powerpc/mm/8xx_mmu.c b/arch/powerpc/mm/8xx_mmu.c index bfa503cff351..92b677faea8c 100644 --- a/arch/powerpc/mm/8xx_mmu.c +++ b/arch/powerpc/mm/8xx_mmu.c @@ -66,26 +66,22 @@ unsigned long p_block_mapped(phys_addr_t pa) void __init MMU_init_hw(void) { /* PIN up to the 3 first 8Mb after IMMR in DTLB table */ -#ifdef CONFIG_PIN_TLB_DATA - unsigned long ctr = mfspr(SPRN_MD_CTR) & 0xfe000000; - unsigned long flags = 0xf0 | MD_SPS16K | _PAGE_SH | _PAGE_DIRTY; -#ifdef CONFIG_PIN_TLB_IMMR - int i = 29; -#else - int i = 28; -#endif - unsigned long addr = 0; - unsigned long mem = total_lowmem; - - for (; i < 32 && mem >= LARGE_PAGE_SIZE_8M; i++) { - mtspr(SPRN_MD_CTR, ctr | (i << 8)); - mtspr(SPRN_MD_EPN, (unsigned long)__va(addr) | MD_EVALID); - mtspr(SPRN_MD_TWC, MD_PS8MEG | MD_SVALID); - mtspr(SPRN_MD_RPN, addr | flags | _PAGE_PRESENT); - addr += LARGE_PAGE_SIZE_8M; - mem -= LARGE_PAGE_SIZE_8M; + if (IS_ENABLED(CONFIG_PIN_TLB_DATA)) { + unsigned long ctr = mfspr(SPRN_MD_CTR) & 0xfe000000; + unsigned long flags = 0xf0 | MD_SPS16K | _PAGE_SH | _PAGE_DIRTY; + int i = IS_ENABLED(CONFIG_PIN_TLB_IMMR) ? 29 : 28; + unsigned long addr = 0; + unsigned long mem = total_lowmem; + + for (; i < 32 && mem >= LARGE_PAGE_SIZE_8M; i++) { + mtspr(SPRN_MD_CTR, ctr | (i << 8)); + mtspr(SPRN_MD_EPN, (unsigned long)__va(addr) | MD_EVALID); + mtspr(SPRN_MD_TWC, MD_PS8MEG | MD_SVALID); + mtspr(SPRN_MD_RPN, addr | flags | _PAGE_PRESENT); + addr += LARGE_PAGE_SIZE_8M; + mem -= LARGE_PAGE_SIZE_8M; + } } -#endif } static void __init mmu_mapin_immr(void) @@ -110,12 +106,10 @@ unsigned long __init mmu_mapin_ram(unsigned long top) if (__map_without_ltlbs) { mapped = 0; mmu_mapin_immr(); -#ifndef CONFIG_PIN_TLB_IMMR - patch_instruction_site(&patch__dtlbmiss_immr_jmp, PPC_INST_NOP); -#endif -#ifndef CONFIG_PIN_TLB_TEXT - mmu_patch_cmp_limit(&patch__itlbmiss_linmem_top, 0); -#endif + if (!IS_ENABLED(CONFIG_PIN_TLB_IMMR)) + patch_instruction_site(&patch__dtlbmiss_immr_jmp, PPC_INST_NOP); + if (!IS_ENABLED(CONFIG_PIN_TLB_TEXT)) + mmu_patch_cmp_limit(&patch__itlbmiss_linmem_top, 0); } else { mapped = top & ~(LARGE_PAGE_SIZE_8M - 1); } -- 2.13.3