Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261790AbUCKWdY (ORCPT ); Thu, 11 Mar 2004 17:33:24 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261792AbUCKWdY (ORCPT ); Thu, 11 Mar 2004 17:33:24 -0500 Received: from fed1mtao03.cox.net ([68.6.19.242]:59873 "EHLO fed1mtao03.cox.net") by vger.kernel.org with ESMTP id S261790AbUCKWdW (ORCPT ); Thu, 11 Mar 2004 17:33:22 -0500 Date: Thu, 11 Mar 2004 15:33:21 -0700 From: Tom Rini To: George Anzinger Cc: "Amit S. Kale" , Pavel Machek , Kernel Mailing List , kgdb-bugreport@lists.sourceforge.net Subject: Re: [Kgdb-bugreport] [PATCH] Kill kgdb_serial Message-ID: <20040311223321.GL5169@smtp.west.cox.net> References: <20040302213901.GF20227@smtp.west.cox.net> <200403031113.02822.amitkale@emsyssoft.com> <20040303151628.GQ20227@smtp.west.cox.net> <200403041011.39467.amitkale@emsyssoft.com> <20040304152729.GC26065@smtp.west.cox.net> <4047B67A.4050609@mvista.com> <20040304231737.GJ26065@smtp.west.cox.net> <4050DB34.8060704@mvista.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4050DB34.8060704@mvista.com> User-Agent: Mutt/1.5.5.1+cvs20040105i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1837 Lines: 41 On Thu, Mar 11, 2004 at 01:33:40PM -0800, George Anzinger wrote: > Tom Rini wrote: > > >>I am afraid I don't quite understand what he was saying other than early > >>init stuff. On of the problems with trying early init stuff, by the way, > >>is that a lot of things depend on having alloc up and that happens rather > >>late in the game. > > > > > >I assume you aren't talking about kgdb stuff here (or what would be the > >point of going so early) but I believe he was talking about allowing for > >stuff that could be done early, to be done early. > > One of the issues with the UART set up is registering the interrupt handler > with the kernel. It will fail if alloc is not up. The -mm patch does two > things with this. a) It tries every getchar to register the interrupt > handler, and b) it has a module init entry to register it. This last will > happen late in the bring up and is safe. a) is there to get it ASAP if you > are actually using kgdb during the bring up. There's two ways to look at this. - All the more reason to acknowledge that the earliest you can safely get into KGDB is point X, where X is where alloc works, mappings done if needed, etc, etc, and IFF we change things slightly in kgdboe so that it can call kgdb_schedule_breakpoint() if it needs to as an initial break, and handle setting kgdb_serial to the serial driver in kgdb_arch_init, or something, and remove all of the extra kludges to get us a few lines / function calls earlier on. - More and more special cases. Roughly. :) -- Tom Rini http://gate.crashing.org/~trini/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/