Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp642266imj; Wed, 13 Feb 2019 14:49:49 -0800 (PST) X-Google-Smtp-Source: AHgI3IZzAKLJ+kKJBFEJDdlS4V37GD4i08q2qYNsphJIEDWXrY7PlPro68xF5OjxIB6bhQtll4DL X-Received: by 2002:a63:65c7:: with SMTP id z190mr520370pgb.249.1550098188788; Wed, 13 Feb 2019 14:49:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550098188; cv=none; d=google.com; s=arc-20160816; b=jHgZn7XwDNnXkjuxKsc7PSDEhjj4saSbhAlQ1vf0CNR4iO9M0dKjwu/yNrgLKmd7Kz /oQL0k9FtBp28wX4hcpMwicV3UyMntO4xnL8kFKu/zevAhkU3GkMR/PKUVd14rsYJOO8 BYdPhTG7eo6F+S1iVyswWZ1Ibl/Z3Rh2FTe0xqNkFs1mi5oux3TvVweW3rZVkItn8+hy 3eapP/7hRUeeKR97jbYdWNkI2PffiCMm5rXAtR6JbyjyzNJwjBGBpQXf66uspx5rNBeg eZAQSkyjZWwqFeEZRkD8pKhpBGycO7aeaX3VwhBZcaGGBbEOoDjQs+cVWTB9u0j37iYn q9ZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:from:cc:references:message-id :subject:user-agent:in-reply-to:to:content-transfer-encoding :mime-version:dkim-signature; bh=zLgtUmUW10DVXZeanZL8BHYBbRtGzPuWhu+4tmVWzaM=; b=CJ8w8zRDcjT2Lz71Jed6TBRFTGL3Ok51DaXiILiJbcYKlOCZIHAarI661THEt3bJyj 5nZcEg5u+61t8/5KPAnTXBWl7FgpHVqMmcABT1EDGwQz7VNA685huGVVigjnL9gRazb8 jCHXtlMswwRwnz5Cmvok55y8QsRklLQ3Joo3hteO9xHqtAf0UW2HqFq9QuvJ/RBJ537/ Cih59g69BL+j5cNkXoArLgUzGE1uDUuWINjcZVxC10fxgsgP6i54XJwbaGwXL1s0IqI7 wQuhqS1azp/QMdfLpnFcxXyaTQrzF13Kex4CWsTIWN3biO11g6vCTy9zqIApV9GbXRnf v8tA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=dsQXE6Gb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d6si511768pgq.319.2019.02.13.14.49.32; Wed, 13 Feb 2019 14:49:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=dsQXE6Gb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391828AbfBMRJn (ORCPT + 99 others); Wed, 13 Feb 2019 12:09:43 -0500 Received: from mail.kernel.org ([198.145.29.99]:47352 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391657AbfBMRJl (ORCPT ); Wed, 13 Feb 2019 12:09:41 -0500 Received: from localhost (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7F7A32070B; Wed, 13 Feb 2019 17:09:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550077780; bh=zLgtUmUW10DVXZeanZL8BHYBbRtGzPuWhu+4tmVWzaM=; h=To:In-Reply-To:Subject:References:Cc:From:Date:From; b=dsQXE6Gb7jeH54YIpX6GG9p/W3Z/RhnFDG0jMHhD4La//sj4Ci86/9bABiiLm6BYM RPRjvACu2JxmY0u5FZo3m5i1zjzWdmPlwppe1oC1xb9aRiAj1lqbF7/uP5IsWJmGnM Rw4C+Wt69mYsrle7nnFQxDqYijwF2f7u0rL3MZ/w= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: Matthias Brugger , kevin-cw.chen@mediatek.com, mars.cheng@mediatek.com, matthias.bgg@kernel.org, mturquette@baylibre.com In-Reply-To: <9db1f94f-7edd-73a1-fb09-9499c5f8cfcb@gmail.com> User-Agent: alot/0.8 Subject: Re: [PATCH v3 3/3] clk: mediatek: Mark bus and DRAM related clocks as critical Message-ID: <155007777974.115909.3599235649247866271@swboyd.mtv.corp.google.com> References: <20190108121208.2473-1-matthias.bgg@kernel.org> <20190108121208.2473-4-matthias.bgg@kernel.org> <9db1f94f-7edd-73a1-fb09-9499c5f8cfcb@gmail.com> Cc: sean.wang@mediatek.com, jasu@njomotys.info, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org From: Stephen Boyd Date: Wed, 13 Feb 2019 09:09:39 -0800 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Matthias Brugger (2019-02-08 05:39:02) > Steven, Mike, any comments on that? I was waiting for Mediatek to review. I thought I said that last time? I suppose if they're not going to review it I'll just throw it into clk-next and people can fix problems if they see them. Would you mind resending one more time with a comment in the code where CLK_IS_CRITICAL is used indicating why it's critical so that we know what's going on without having to dig into the git history?