Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
To:     Michael Turquette <mturquette@baylibre.com>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>
In-Reply-To: <20190211135818.10518-1-thomas.petazzoni@bootlin.com>
User-Agent: alot/0.8
Subject: Re: [PATCH] clk: clk-gpio: add support for sleeping GPIOs in gpio-gate-clk
Message-ID: <155007806256.115909.10137511038361789251@swboyd.mtv.corp.google.com>
References: <20190211135818.10518-1-thomas.petazzoni@bootlin.com>
Cc:     linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>
From:   Stephen Boyd <sboyd@kernel.org>
Date:   Wed, 13 Feb 2019 09:14:22 -0800
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Thomas Petazzoni (2019-02-11 05:58:18)
> The current implementation of gpio-gate-clk enables/disables the clock
> using the GPIO in the ->enable() and ->disable() clock callbacks. This
> requires the GPIO to be configurable in atomic contexts. While it is
> the case for most memory-mapped GPIO controllers, it is not the case
> for GPIO expanders on I2C or SPI.
>=20
> This commit extends the gpio-gate-clk to check whether the GPIO calls
> require sleeping or not. If sleeping is not required, the current
> implementation based on ->enable()/->disable() is kept. However, if
> sleeping is needed, we instead implement the logic in the ->prepare()
> and ->unprepare() hooks. Thanks to this, a gate clock connected to a
> GPIO on a GPIO expander can be controlled with the existing driver.
>=20
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Sounds like a good idea!

> diff --git a/drivers/clk/clk-gpio.c b/drivers/clk/clk-gpio.c
> index 6a43ce420492..f5d481713c7d 100644
> --- a/drivers/clk/clk-gpio.c
> +++ b/drivers/clk/clk-gpio.c
> @@ -61,6 +61,35 @@ const struct clk_ops clk_gpio_gate_ops =3D {
>  };
>  EXPORT_SYMBOL_GPL(clk_gpio_gate_ops);
> =20
> +static int clk_sleeping_gpio_gate_prepare(struct clk_hw *hw)
> +{
> +       struct clk_gpio *clk =3D to_clk_gpio(hw);
> +
> +       gpiod_set_value_cansleep(clk->gpiod, 1);
> +
> +       return 0;
> +}
> +
> +static void clk_sleeping_gpio_gate_unprepare(struct clk_hw *hw)
> +{
> +       struct clk_gpio *clk =3D to_clk_gpio(hw);
> +
> +       gpiod_set_value_cansleep(clk->gpiod, 0);
> +}
> +
> +static int clk_sleeping_gpio_gate_is_prepared(struct clk_hw *hw)
> +{
> +       struct clk_gpio *clk =3D to_clk_gpio(hw);
> +
> +       return gpiod_get_value_cansleep(clk->gpiod);
> +}
> +
> +const struct clk_ops clk_sleeping_gpio_gate_ops =3D {

static?

> +       .prepare =3D clk_sleeping_gpio_gate_prepare,
> +       .unprepare =3D clk_sleeping_gpio_gate_unprepare,
> +       .is_prepared =3D clk_sleeping_gpio_gate_is_prepared,
> +};
> +
>  /**
>   * DOC: basic clock multiplexer which can be controlled with a gpio outp=
ut
>   * Traits of this clock: