Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp655652imj; Wed, 13 Feb 2019 15:06:07 -0800 (PST) X-Google-Smtp-Source: AHgI3IamajScyWLHNZ8zpZRqm5evHQYN/JGVL/QXzrGaO6dJIMtGjQoP82y62caSIogCui6EwlEr X-Received: by 2002:a63:2d5:: with SMTP id 204mr557146pgc.407.1550099167883; Wed, 13 Feb 2019 15:06:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550099167; cv=none; d=google.com; s=arc-20160816; b=lbia1ODIxRFf8ECStQ57csU+jXVQCSiwMHdS2GDZRukAWPNg8W7Q+Xxyuf77uBvgpa chEsSp22dWe7BJmUpKpu3OOSa55cNqcRBXVxW2o7XEbxdelHYO5cs+QZ2VvddD1jfRvH FcCsfkvgYGXZ8eDVSr7Djh7JmncWM2u9ZZoK1KiGIQCC8XzcDKuYRrQf9Io4/gaQdeKx Pqt27QfAjdaLNWYjqxpnh7L9Wbt3b+2Sk9t5islNt5+sA0iZsU1eQCv39IXnyazZQKhR Rs+HD97ZG0DDVJQNsTG9sdmQq79Cst3oWuEk31dguwzOAVexbgRbnAjAdm1DuGICO5lI Omeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=0HyvAdIePiaQK/ct8bOgBQvx+PY8saI9Hy88kMKQLl8=; b=VtWMI247pX2CT1PkUMu56V0nvtQ81mBJM/YZSsbwKranEnUkCn6gkaXggYT3FfrF7y NoGzRjjFTy32ndXAEp9ikgCsfg+RigVCRy5o8dKjCmRq63jJJ5NQs/VyvBWjj4GeDw6J WcrG4V5+OItp3lNEGQbOqZtu4LZn5Yp3IsPoExpvEKzYIj9i0Kv7OO24lgqiGhijUwez i+hHDu9vpbC9ve1Umu7mN09cxB/UiFKHvkDSkl/Yye9QJLIUtNDqfRv2jkd3J9Mel79d eqL5G4V0e8qnUJ0u+8qTF8AuEKcRhEjPSSq7Dg2lVEa91ssU2NgTbPsLK/cUDcgc8THD 5W9g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a2si630292pfb.166.2019.02.13.15.05.52; Wed, 13 Feb 2019 15:06:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392941AbfBMRZg (ORCPT + 99 others); Wed, 13 Feb 2019 12:25:36 -0500 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:57764 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733301AbfBMRZg (ORCPT ); Wed, 13 Feb 2019 12:25:36 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 13575A78; Wed, 13 Feb 2019 09:25:36 -0800 (PST) Received: from brain-police (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 780243F675; Wed, 13 Feb 2019 09:25:34 -0800 (PST) Date: Wed, 13 Feb 2019 17:25:30 +0000 From: Will Deacon To: Geert Uytterhoeven Cc: Linux-Arch , Linux Kernel Mailing List , andrew.murray@arm.com, Arnd Bergmann , Catalin Marinas Subject: Re: [PATCH 2/2] arm64: io: Hook up __io_par() for inX() ordering Message-ID: <20190213172528.GI6346@brain-police> References: <20190211174544.4302-1-will.deacon@arm.com> <20190211174544.4302-3-will.deacon@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 12, 2019 at 11:42:44AM +0100, Geert Uytterhoeven wrote: > On Mon, Feb 11, 2019 at 9:34 PM Will Deacon wrote: > > Ensure that inX() provides the same ordering guarantees as readX() > > by hooking up __io_par() so that it maps directly to __iormb(). > > > > Reported-by: Andrew Murray > > Signed-off-by: Will Deacon > > Thanks for your patch! > > > --- a/arch/arm64/include/asm/io.h > > +++ b/arch/arm64/include/asm/io.h > > @@ -121,6 +121,7 @@ static inline u64 __raw_readq(const volatile void __iomem *addr) > > : "memory"); \ > > }) > > > > +#define __io_par __iormb > > I think it makes sense to make the parameter passing explicit, for > documentation purposes: > > #define __io_par(v) __iormb(v) Thanks, I'll make that change for v2. Will