Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     Hou Tao <houtao1@huawei.com>, <linux-kernel@vger.kernel.org>,
        <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] fat: enable .splice_write to support splice on O_DIRECT file
References: <20190210094754.56355-1-houtao1@huawei.com>
        <871s4b7gkj.fsf@mail.parknet.co.jp>
Date:   Thu, 14 Feb 2019 02:19:28 +0900
In-Reply-To: <871s4b7gkj.fsf@mail.parknet.co.jp> (OGAWA Hirofumi's message of
        "Thu, 14 Feb 2019 02:18:20 +0900")
Message-ID: <87wom361y7.fsf@mail.parknet.co.jp>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> writes:

> Hou Tao <houtao1@huawei.com> writes:
>
>> Now splice() on O_DIRECT-opened fat file will return -EFAULT, that is
>> because the default .splice_write, namely default_file_splice_write(),
>> will construct an ITER_KVEC iov_iter and dio_refill_pages() in dio path
>> can not handle it.
>>
>> Fix it by implementing .splice_write through iter_file_splice_write().
>>
>> Spotted by xfs-tests generic/091.
>>
>> Signed-off-by: Hou Tao <houtao1@huawei.com>
>> ---
>>  fs/fat/file.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/fs/fat/file.c b/fs/fat/file.c
>> index 13935ee99e1e..b3bed32946b1 100644
>> --- a/fs/fat/file.c
>> +++ b/fs/fat/file.c
>> @@ -214,6 +214,7 @@ const struct file_operations fat_file_operations = {
>>  #endif
>>  	.fsync		= fat_file_fsync,
>>  	.splice_read	= generic_file_splice_read,
>> +	.splice_write	= iter_file_splice_write,
>>  	.fallocate	= fat_fallocate,
>>  };
>
> Looks good.
>
> Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
>
> Thanks.

Forgot to include akpm to addresses.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>