Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp1140350imj; Thu, 14 Feb 2019 01:49:19 -0800 (PST) X-Google-Smtp-Source: AHgI3IZJUPClNuufpB9obQXvnS7P2n4SGmHh4XYYx5aud1aortIDHu8pONiVLb/o6rT2dB5j+k21 X-Received: by 2002:a63:fa51:: with SMTP id g17mr2941005pgk.66.1550137759241; Thu, 14 Feb 2019 01:49:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550137759; cv=none; d=google.com; s=arc-20160816; b=00XTLq7mSPbZApBaqKIDarowl8zTLMLu51kVYsh24dTLJ5abTs50wZz88GRV94Ogw7 MefQ3n/QFKnSPCarmexJGuzGK52ZDCxJ/yhTgC57fZ4A0DKlEvyTykYMcPmT8OYxOJJC k3LBjE33uxwMyBvaIbfSTajY2vVAohZYF7P9iGABCYe/+EFeP41O1o1yvi0A43YT3D0L QYnYWVumO/FEbMoJoKS/lGG0lQ0XYXRbEXHf974FgPJJcegrCEhgtCxTPxbFcajWjkpk /G/N0b8PD3JzRQrBzE0udMMckeqzc/mv5VqMiX+uL9APUY6RORGfCWj0yJW5rsShyJ9f 9JSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=9G4DF3q+5icpiTz4hOMAQMmQFgj6icVQZaXabGjRcus=; b=pHKVi8o9Ke1NepKjDC+ExoomDwrh0DB/CzCxWvZ6YLnZtD6xIHsXPPZy61cACH1W6X ctN0TxT1uUGvZ4dkYGOXusvsFWzyn3uFBsztCrGC6DYRi+b+eZd++G6Hu+grQJUbH6rL plIzkCp6VYrwPb5TuA3eloQoHhPVy2zhJEp/jf0xzjoHNrKFYjt1xmsFg8SIo6L/JgXd SvTmq+y5HdGkhTU2DYTi7jOiRXxxtJiFsAZBIXwMf9U1P4b2R9LXEaOC/RsVO0Uv1Mob 7VitLG7kuvD7BrsdDkudT0zKYrAAv1Ahu0K07+XOVFKySZ/POyRgBysVhqF9wr+FY94J qFYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=tNBRJUno; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d188si1909767pgc.97.2019.02.14.01.49.03; Thu, 14 Feb 2019 01:49:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=tNBRJUno; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392991AbfBMXpD (ORCPT + 99 others); Wed, 13 Feb 2019 18:45:03 -0500 Received: from mail.kernel.org ([198.145.29.99]:53028 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730326AbfBMXpD (ORCPT ); Wed, 13 Feb 2019 18:45:03 -0500 Received: from devnote (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5F4672229F; Wed, 13 Feb 2019 23:45:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550101502; bh=Wnc8yA/bMRVMOlaDVr9KHYpXiySYH6At+CYbzsXZbTE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tNBRJUnoQIUHenUPhIy6T2aGiqPh3lj4WOUkvdClNcvFWAASqa15oKkSakwqpfypK NeaPqS7bJ4qXHJfN/sdkRMFKzestciH+X39tZ9dsbHVwaKHfNqBFAesst/dHouAJrS +ZkbUq0ZaooA/Jcl1CLo3tmMegHQbTTGcjpaRil4= Date: Thu, 14 Feb 2019 08:44:58 +0900 From: Masami Hiramatsu To: Ingo Molnar Cc: Ingo Molnar , peterz@infradead.org, Mathieu Desnoyers , linux-kernel , Andrea Righi , Steven Rostedt Subject: Re: [PATCH -tip v3 05/10] kprobes: Search non-suffixed symbol in blacklist Message-Id: <20190214084458.2b2d89f971201f0f67774461@kernel.org> In-Reply-To: <20190213071711.GB121801@gmail.com> References: <154998785011.31052.1475728497912659748.stgit@devbox> <154998799234.31052.6136378903570418008.stgit@devbox> <20190213071316.GA121801@gmail.com> <20190213071711.GB121801@gmail.com> X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 13 Feb 2019 08:17:11 +0100 Ingo Molnar wrote: > > * Ingo Molnar wrote: > > > > > * Masami Hiramatsu wrote: > > > > > Newer gcc can generate some different instances of a function > > > with suffixed symbols if the function is optimized and only > > > has a part of that. (e.g. .constprop, .part etc.) > > > > > > In this case, it is not enough to check the entry of kprobe > > > blacklist because it only records non-suffixed symbol address. > > > > > > To fix this issue, search non-suffixed symbol in blacklist if > > > given address is within a symbol which has a suffix. > > > > > > Note that this can cause false positive cases if a kprobe-safe > > > function is optimized to suffixed instance and has same name > > > symbol which is blacklisted. > > > But I would like to chose a fail-safe design for this issue. > > > > > > Signed-off-by: Masami Hiramatsu > > > > Why did you not add Steven's Reviewed-by tag? > > The series looks fine otherwise, so I applied it with Steve's reviewed-by > tag added. Oops, sorry! I missed to add that. :-( Thank you, > > Thanks, > > Ingo -- Masami Hiramatsu