Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] erofs: fix memleak of node's shared xattr array
To:     Sheng Yong <shengyong1@huawei.com>
CC:     <yuchao0@huawei.com>, <gregkh@linuxfoundation.org>,
        <linux-erofs@lists.ozlabs.org>, <devel@driverdev.osuosl.org>,
        <linux-kernel@vger.kernel.org>, <chao@kernel.org>
References: <20190214093754.14339-1-shengyong1@huawei.com>
From:   Gao Xiang <gaoxiang25@huawei.com>
Message-ID: <23bb86d7-817f-5447-eb2c-5e384d3a462b@huawei.com>
Date:   Thu, 14 Feb 2019 09:53:49 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <20190214093754.14339-1-shengyong1@huawei.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Sheng,

On 2019/2/14 17:37, Sheng Yong wrote:
> If it fails to read a shared xattr page, the node's shared xattr array

node -> inode since erofs doesn't have 'node' concept like f2fs...

> is not freed. The next time the node's xattr is accessed, the previously
> allocated array is leaked.
> 

Good catch! I think it's a valid object memory leak.
the subject should be fixed as [PATCH] staging: erofs: fix memleak of inode's shared xattr array
                                              ^

Thanks,
Gao Xiang

> Signed-off-by: Sheng Yong <shengyong1@huawei.com>
> ---
>  drivers/staging/erofs/xattr.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/erofs/xattr.c b/drivers/staging/erofs/xattr.c
> index 80dca6a4adbe..e3f8b904a680 100644
> --- a/drivers/staging/erofs/xattr.c
> +++ b/drivers/staging/erofs/xattr.c
> @@ -92,8 +92,11 @@ static int init_inode_xattrs(struct inode *inode)
>  
>  			it.page = erofs_get_meta_page(sb,
>  				++it.blkaddr, S_ISDIR(inode->i_mode));
> -			if (IS_ERR(it.page))
> +			if (IS_ERR(it.page)) {
> +				kfree(vi->xattr_shared_xattrs);
> +				vi->xattr_shared_xattrs = NULL;
>  				return PTR_ERR(it.page);
> +			}
>  
>  			it.kaddr = kmap_atomic(it.page);
>  			atomic_map = true;
>