Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp1186252imj; Thu, 14 Feb 2019 02:37:43 -0800 (PST) X-Google-Smtp-Source: AHgI3IYCIV5wKkhvO1hzLwzMpI+I0yRRdCOlmo2xhuBax/Rp9eARn+rwjrPwXZDV9wO51PImNmj2 X-Received: by 2002:a65:46c7:: with SMTP id n7mr3161743pgr.182.1550140663091; Thu, 14 Feb 2019 02:37:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550140663; cv=none; d=google.com; s=arc-20160816; b=KJq3UXHliOn3x7Okio+kw4eL3xbwwDxiTxZeWL7vO6icpSoEnP3T9mWODAbIjqDWPH 7zDCT6oSwBcZ1E1urJde5pP5eG92yq0upPSg/clzeOosVVJnmdficP78smaw0fv2Ko66 8Wn6/FB0CrVE2lEsGpmr5kRchm2+OOCj8RufTuaI81JyAVzcAMxYD7vX4Z9PloU4uTU5 gyHsN0wCFLGdgFfiZxiY4KhjF/GOB+P/xac3Mwac3ZkqtGRPw0Kf2Pbq+q7cb/OHoAh+ FXrVaFw+oKRCsqU9JfAO8ykn1sHS1VJ1ban6C7zeABbOcNygzka/cxc6CueaODT3chlB F8yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature; bh=c5taJN954cutuswTWfG5U+CDpxpAV+VcPXKP5vYMc6U=; b=zJ9YHIi0yq26s+Z9GrQLIAlL98eDp6797X2T5AQeD5m3Ds/W0iOx6zsPg9+zjdOlu9 zuaApNhGPq7X6gB97tD5I/qTOQbY6w87sBXPSaHaHHtVsf2PtzoftVItxyM3v89u9xj3 tbCLThtIGNsOq8iXw3N2w0J2uzw+Z8QzNzRJMurIDWZjpuO/MLuPB7wt/gIyl0wm4f2l SyP5NTodXbZjoFplkuA6fhpmQN7agmblLpFShxpxxskfUwh0e3290k7+0eIGF+3eafh4 xjbdO/ghmbGZelCmjAsqwmkvgbXvY0G5GlsjLlwWPQCwEvds4Py2NCnrfYR2GYNTAtlY t/Pg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=A5N9JxXi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 128si944401pfe.4.2019.02.14.02.37.26; Thu, 14 Feb 2019 02:37:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=A5N9JxXi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404346AbfBNCcM (ORCPT + 99 others); Wed, 13 Feb 2019 21:32:12 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:34138 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726325AbfBNCcM (ORCPT ); Wed, 13 Feb 2019 21:32:12 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x1E2NtBo195745; Thu, 14 Feb 2019 02:32:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=c5taJN954cutuswTWfG5U+CDpxpAV+VcPXKP5vYMc6U=; b=A5N9JxXi6NQbXGVEDCLradKDIStkSxEnjXQmQczdWtpy48Us8UHDgqGnJ5904zJPOfRl s/1vocU5HexSPfKkEgEwCVqshQ4aPW1kyOOXJI7LlLks3aZEhXaFxrQhxrEdU8oppkpH 7zqy3GH1Q/ECI77u9aXRuqgDFCtSDvnz2qCnSy9pO0qAqarSxkrhf25c2Gt6N75Cl80I 7l7K8MjfFPigqLTGVARasD4R97FvxlvMeeZGD4n0ukAhECMN3SLHD2Phwg86JlLaUmZJ M6/GhJoAPfeaBdyzvIYwrVWbJpYPC+Orl61E13kYn7HWceGiv/+DeR+uPN6Yn+lHDz/+ kw== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2120.oracle.com with ESMTP id 2qhree5g6q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 14 Feb 2019 02:32:05 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id x1E2VxQZ024714 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 14 Feb 2019 02:31:59 GMT Received: from abhmp0022.oracle.com (abhmp0022.oracle.com [141.146.116.28]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x1E2Vx2Y026853; Thu, 14 Feb 2019 02:31:59 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 13 Feb 2019 18:31:58 -0800 To: Evan Green Cc: Jens Axboe , Bart Van Assche , Gwendal Grignou , Martin K Petersen , Alexis Savery , Ming Lei , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] loop: Report EOPNOTSUPP properly From: "Martin K. Petersen" Organization: Oracle Corporation References: <20190207205730.199332-1-evgreen@chromium.org> <20190207205730.199332-2-evgreen@chromium.org> Date: Wed, 13 Feb 2019 21:31:54 -0500 In-Reply-To: <20190207205730.199332-2-evgreen@chromium.org> (Evan Green's message of "Thu, 7 Feb 2019 12:57:28 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9166 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=683 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902140017 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Evan, > Properly plumb out EOPNOTSUPP from loop driver operations, which may > get returned when for instance a discard operation is attempted but > not supported by the underlying block device. Before this change, > everything was reported in the log as an I/O error, which is scary and > not helpful in debugging. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering