Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp1190884imj; Thu, 14 Feb 2019 02:42:53 -0800 (PST) X-Google-Smtp-Source: AHgI3IYRuqj7SE3Wlb0G3xaw04OcNNUEPuUkKEuGGpacfDGOapwo5USpm+L6bEXf4kOLZjirBaGJ X-Received: by 2002:a62:ee0e:: with SMTP id e14mr3295809pfi.201.1550140973678; Thu, 14 Feb 2019 02:42:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550140973; cv=none; d=google.com; s=arc-20160816; b=LyEjxJuEfGbRT6Kfv+NwdRZGOp2BpmrmQa951TI1yO/MIWaqEATcEisN6KVYfxRNLi lfd1SWWKkf6tHRWnBuwJyV2QQXWtc9Va7Qe3qACUqGRSizriaowmIwEceJZ2/5ILnTiC gWlOfOznpiYrmWi2KIs5BbCiS4SbR47LllMiAqAbc+SDKy3FMw8Qsc2wijEYz8/ZwiVV wgMOuDH3gDQS9GklnBbzFWMFcpn9SQEo5ZKNC1j3ALK6bBkqqjUf8QwPlMrp7aAWIeCS r2pqwdsc44GOIr+ZqkDloMVSey367HcvBPC+RvqTXOM40FYjlE3e/T6AFNk9ESWf0k7C uW/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=zOUKEyltExsjxF4ZbPNg+DUw0mbiw9l7x8DDJkpI9qE=; b=TMnnH25QI3RviQ+s9kVqQ5u75iLVpebYhXdg8WzXZVThUi3PvwBBOHN7vUHEcdW+tW 8t94lRmlRBcYWPJkGNjlhD12PBQRIZzbmWomvicLZdVfNNTssho+DdtguGbZoiAnVGOR E1dvWmYNNfPMkt+JRKyQfCpMH37Mda99sJwpIVoy5Mbpx0vNoad6c5sKRMUJzs361Nn4 SKkmHF87jbQjGbAAtRbQlMK02sPt5ezB1QtzbMnykxw4loVtmLVkJc6BnYaNAX3vz9pd byheb+R9WmoXPpskuTX9A3fPQW/8lNBk5uw/g9tlisJ3cq+JMlSGbxnxd6nKZBrHJPuv xbdA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@lunn.ch header.s=20171124 header.b=dfVhiG3U; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n4si2083728pgh.427.2019.02.14.02.42.37; Thu, 14 Feb 2019 02:42:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@lunn.ch header.s=20171124 header.b=dfVhiG3U; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393622AbfBNDHm (ORCPT + 99 others); Wed, 13 Feb 2019 22:07:42 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:51079 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388285AbfBNDHm (ORCPT ); Wed, 13 Feb 2019 22:07:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=zOUKEyltExsjxF4ZbPNg+DUw0mbiw9l7x8DDJkpI9qE=; b=dfVhiG3UIWzRGzzAQ8Fl94+R0V Ju/cDsFia9vyhyaVH3Kij98+aXegzQkkVmLCRAZX7nAGifn4jw60RzP5w0HTHppqc2JBsRYGmHI+Q 2X/vbc/UADPqy2hjLxEShmlEZAgD/BrN/9Wfs59atnqkXVNx7C3Uxo64EEIq6zX3nwmI=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1gu7N7-00055E-MN; Thu, 14 Feb 2019 04:07:33 +0100 Date: Thu, 14 Feb 2019 04:07:33 +0100 From: Andrew Lunn To: Federico Vaga Cc: Peter Korsgaard , Peter Rosin , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 0/5] i2c: ocores: improvements Message-ID: <20190214030733.GG24589@lunn.ch> References: <20190211164913.5988-1-federico.vaga@cern.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190211164913.5988-1-federico.vaga@cern.ch> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 11, 2019 at 05:49:08PM +0100, Federico Vaga wrote: > This patch set provides improvements to the i2c-ocore driver. > > [V5 -> V6] > - remove redundant code introduced in V5 (double read control register) > > [V4 -> V5] > - deterministic status of IEN bit in register "CONTROL" at the end of > ocores_init() > - more style fixes > > [V3 -> V4] > - add reviews-by/tested-by > - add comment to justify the formula in > udelay((8 * 1000) / i2c->bus_clock_khz); Hi Federico It looks like all the reviewed-by: tags disappeared from v5. Can you add them back again, and then we can probably merge this patchset. Thanks Andrew