Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Mime-Version: 1.0
Subject: RE: Re: [PATCH v4 6/6] RISC-V: Free-up initrd in free_initrd_mem()
Reply-To: chandan.vn@samsung.com
From:   CHANDAN VN <chandan.vn@samsung.com>
To:     Mike Rapoport <rppt@linux.ibm.com>,
        Christoph Hellwig <hch@infradead.org>
CC:     Anup Patel <Anup.Patel@wdc.com>,
        Palmer Dabbelt <palmer@sifive.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Atish Patra <Atish.Patra@wdc.com>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        "linux-riscv@lists.infradead.org" <linux-riscv@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Laura Abbott <labbott@redhat.com>,
        Will Deacon <will.deacon@arm.com>
In-Reply-To: <20190213180557.GA15270@rapoport-lnx>
Message-ID: <20190214050004epcms5p4d2157380c40e9b218fb0eeb376b3cb7c@epcms5p4>
Date:   Thu, 14 Feb 2019 10:30:04 +0530
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <20190213180557.GA15270@rapoport-lnx>
        <20190213063127.28703-1-anup.patel@wdc.com>
        <20190213063127.28703-7-anup.patel@wdc.com>
        <20190213064419.GA27012@infradead.org> <20190213073835.GA18267@rapoport-lnx>
        <20190213175415.GA11635@infradead.org>
        <CGME20190213180621epcas4p44685b5689a3fcfbe63453e808f502548@epcms5p4>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

> On=C2=A0Wed,=C2=A0Feb=C2=A013,=C2=A02019=C2=A0at=C2=A009:54:15AM=C2=A0-08=
00,=C2=A0Christoph=C2=A0Hellwig=C2=A0wrote:=0D=0A>=20>=C2=A0On=C2=A0Wed,=C2=
=A0Feb=C2=A013,=C2=A02019=C2=A0at=C2=A009:38:36AM=C2=A0+0200,=C2=A0Mike=C2=
=A0Rapoport=C2=A0wrote:=0D=0A>=20>=C2=A0>=C2=A0memblock_free()=C2=A0is=C2=
=A0has=C2=A0no=C2=A0real=C2=A0effect=C2=A0at=C2=A0this=C2=A0point,=C2=A0no=
=C2=A0idea=C2=A0why=C2=A0arm64=0D=0A>=20>=C2=A0>=C2=A0calls=C2=A0it.=0D=0A>=
=20>=C2=A0=0D=0A>=20>=C2=A0Looks=C2=A0like=C2=A0the=C2=A0call=C2=A0was=C2=
=A0added=C2=A0fairly=C2=A0recently=C2=A0by:=0D=0A>=20>=C2=A0=0D=0A>=20>=C2=
=A0commit=C2=A005c58752f9dce11e396676eb731a620541590ed0=0D=0A>=20>=C2=A0Aut=
hor:=C2=A0CHANDAN=C2=A0VN=C2=A0<chandan.vn=40samsung.com>=0D=0A>=20>=C2=A0D=
ate:=C2=A0=C2=A0=C2=A0Mon=C2=A0Apr=C2=A030=C2=A009:50:18=C2=A02018=C2=A0+05=
30=0D=0A>=20>=C2=A0=0D=0A>=20>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0arm64:=C2=A0To=
=C2=A0remove=C2=A0initrd=C2=A0reserved=C2=A0area=C2=A0entry=C2=A0from=C2=A0=
memblock=0D=0A>=20>=C2=A0=0D=0A>=20>=C2=A0which=C2=A0claims=C2=A0it=C2=A0is=
=C2=A0to=C2=A0work=C2=A0around=C2=A0the=C2=A0initrd=C2=A0being=C2=A0display=
ed=C2=A0in=0D=0A>=20>=C2=A0/sys/kernel/debug/memblock/reserved.=0D=0A>=20>=
=C2=A0=0D=0A>=20>=C2=A0I=C2=A0really=C2=A0think=C2=A0we=C2=A0need=C2=A0to=
=C2=A0have=C2=A0common=C2=A0behavior=C2=A0there=C2=A0-=C2=A0either=C2=A0do=
=C2=A0this=0D=0A>=20>=C2=A0for=C2=A0all=C2=A0architectures=C2=A0or=C2=A0non=
e.=C2=A0=C2=A0I've=C2=A0just=C2=A0sent=C2=A0a=C2=A0series=C2=A0that=0D=0A>=
=20>=C2=A0consolidates=C2=A0all=C2=A0but=C2=A0a=C2=A0handful=C2=A0of=C2=A0t=
he=C2=A0free_initrd_mem,=C2=A0so=C2=A0implementing=0D=0A>=20>=C2=A0any=C2=
=A0common=C2=A0behavior=C2=A0on=C2=A0top=C2=A0of=C2=A0that=C2=A0would=C2=A0=
be=C2=A0good.=0D=0A>=C2=A0=0D=0A>=20I've=C2=A0just=C2=A0started=C2=A0to=C2=
=A0look=C2=A0into=C2=A0it=C2=A0today=C2=A0:)=0D=0A>=20I'll=C2=A0reply=C2=A0=
on=C2=A0that=C2=A0thread.=0D=0A=0D=0AINITRD=20reserved=20area=20entry=20is=
=20not=20removed=20from=20memblock=0D=0Aeven=20though=20initrd=20reserved=
=20area=20is=20freed.=20The=20same=20can=20be=0D=0Achecked=20from=20/sys/ke=
rnel/debug/memblock/reserved.=0D=0AWe=20did=20not=20face=20this=20issue=20o=
n=20arm32=20architecture.=0D=0AThough=20the=20changes=20which=20i=20had=20s=
ubmitted=20does=20not=20fix=20any=20memory=20leak,=0D=0Ait=20does=20make=20=
sure=20that=20the=20entries=20freed=20from=20memblock=20are=20actually=20re=
moved=0D=0Afrom=20the=20sys=20entry=20as=20well.=20=0D=0AAlso=20the=20imple=
mentation=20of=20arm64=20is=20quite=20different=20from=20arm32.=20I=20feel=
=20a=20generic=20=0D=0Aimplementation=20can=20be=20taken=20up=20only=20if=
=20its=20a=20real=20necessity.