Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Zhou, David(ChunMing)" <David1.Zhou@amd.com>
To:     Bo YU <tsu.yubo@gmail.com>,
        "Deucher, Alexander" <Alexander.Deucher@amd.com>,
        "Koenig, Christian" <Christian.Koenig@amd.com>,
        "airlied@linux.ie" <airlied@linux.ie>,
        "daniel@ffwll.ch" <daniel@ffwll.ch>, "Zhu, Rex" <Rex.Zhu@amd.com>,
        "Grodzovsky, Andrey" <Andrey.Grodzovsky@amd.com>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     "amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>
Subject: RE: [PATCH] drm/amdgpu: Error handling issues about CHECKED_RETURN
Thread-Topic: [PATCH] drm/amdgpu: Error handling issues about CHECKED_RETURN
Thread-Index: AQHUxCB7Uf9Sg9+2AEejhLZiKhxoGKXevnsw
Date:   Thu, 14 Feb 2019 05:09:45 +0000
Message-ID: <DM6PR12MB2908A5B2BD12B9139C5DAB01B4670@DM6PR12MB2908.namprd12.prod.outlook.com>
References: <20190214044628.26759-1-tsu.yubo@gmail.com>
In-Reply-To: <20190214044628.26759-1-tsu.yubo@gmail.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: amd.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: c302e863-1d42-4123-de21-08d6923aa2e4
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2019 05:09:45.7009
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3228
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Bo YU <tsu.yubo@gmail.com>
> Sent: Thursday, February 14, 2019 12:46 PM
> To: Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian
> <Christian.Koenig@amd.com>; Zhou, David(ChunMing)
> <David1.Zhou@amd.com>; airlied@linux.ie; daniel@ffwll.ch; Zhu, Rex
> <Rex.Zhu@amd.com>; Grodzovsky, Andrey
> <Andrey.Grodzovsky@amd.com>; dri-devel@lists.freedesktop.org; linux-
> kernel@vger.kernel.org
> Cc: Bo Yu <tsu.yubo@gmail.com>; amd-gfx@lists.freedesktop.org
> Subject: [PATCH] drm/amdgpu: Error handling issues about
> CHECKED_RETURN
>=20
> From: Bo Yu <tsu.yubo@gmail.com>
>=20
> Calling "amdgpu_ring_test_helper" without checking return value

We could need to continue to ring test even there is one ring test failed.

-David

>=20
> Signed-off-by: Bo Yu <tsu.yubo@gmail.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> index 57cb3a51bda7..48465a61516b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> @@ -4728,7 +4728,9 @@ static int gfx_v8_0_cp_test_all_rings(struct
> amdgpu_device *adev)
>=20
>  	for (i =3D 0; i < adev->gfx.num_compute_rings; i++) {
>  		ring =3D &adev->gfx.compute_ring[i];
> -		amdgpu_ring_test_helper(ring);
> +		r =3D amdgpu_ring_test_helper(ring);
> +		if (r)
> +			return r;
>  	}
>=20
>  	return 0;
> --
> 2.11.0