Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp1232845imj; Thu, 14 Feb 2019 03:22:56 -0800 (PST) X-Google-Smtp-Source: AHgI3IZeEQUmG9umMcoygPE1pFz1OUiN1M5MWrRrwDMm79XP2G4my5u23mKo4l1TkXzZE+e71Xwp X-Received: by 2002:a17:902:6909:: with SMTP id j9mr3540207plk.196.1550143376590; Thu, 14 Feb 2019 03:22:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550143376; cv=none; d=google.com; s=arc-20160816; b=yDdx1HrAAUmFFPPNCVXYg0dpm0U3qGokzjqo8gPr/gAX6ZMziCeFr0W5VX5mqnnmpx cnuJ/eU1gQCIRETncR+RpU/vZHV8dkHkyejqKIVe7BfUvEBGsENDzZxNrDe4mwaVzAn5 wPrP0TYUkuQqZfkjJOveQqJRw5O7HG2A/QfwVzLHoSKIdDpq//Q8b5SytRypr23TbSma AciHrpStKkoMkJZCPhvCbPGa85M/RgJf9MpovxsSmpE8Q6qeTShEGF7by2UVPMUFjSu+ 2V0AUkaBqQHdRPNN0Y9K8iAmqCGqa5GzjSXz7LKLE8GQCVqBnwX9hqQjzKgOMrhZnKFx ljXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=xV9eYAs/eynFhWztoLCxyfjOuukFREJFLaWAuTpROTY=; b=H5SV1BMN83EGpYg+B68dhts69/dTi3jsGm40SFr0GHI9KiqRn4GXK/J3VPZuVCaozK 47f8lZ26Mu/WeQ213UgTSXgFj8PqNXs3z6/2sKd2hxyMrP2aPwkPR+2c7TlADjja7tTE Z2L32DNDeTZqjzHb0q0+kY4SpzGs5Enr+TQ+tZ7/M6qNTLq7+O/fso283Ow6FYYqUmLe pQdHlT/+3ssFiWlOJqJ9H20Y4wb5eDm8UCNtOpLmoRVb5Du26eYbUiFsbYYoil1BXrts 3cwX9T5UjZUX4uqzs6Y0RIkk13hbCz+r9qP9uAVs7lloJPIe3zZxa9LGigokiVO8Aj8Q +6KQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z29si2197802pfi.9.2019.02.14.03.22.40; Thu, 14 Feb 2019 03:22:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405804AbfBNGjT (ORCPT + 99 others); Thu, 14 Feb 2019 01:39:19 -0500 Received: from mxhk.zte.com.cn ([63.217.80.70]:34278 "EHLO mxhk.zte.com.cn" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387576AbfBNGjT (ORCPT ); Thu, 14 Feb 2019 01:39:19 -0500 Received: from mse01.zte.com.cn (unknown [10.30.3.20]) by Forcepoint Email with ESMTPS id 782346DA692048CECA2B; Thu, 14 Feb 2019 14:39:16 +0800 (CST) Received: from notes_smtp.zte.com.cn ([10.30.1.239]) by mse01.zte.com.cn with ESMTP id x1E6dCnS048823; Thu, 14 Feb 2019 14:39:12 +0800 (GMT-8) (envelope-from huang.zijiang@zte.com.cn) Received: from fox-host8.localdomain ([10.74.120.8]) by szsmtp06.zte.com.cn (Lotus Domino Release 8.5.3FP6) with ESMTP id 2019021414394212-26035282 ; Thu, 14 Feb 2019 14:39:42 +0800 From: Huang Zijiang To: isdn@linux-pingi.de Cc: davem@davemloft.net, natechancellor@gmail.com, yuehaibing@huawei.com, baijiaju1990@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, wang.yi59@zte.com.cn, Huang Zijiang Subject: [PATCH] isdn:hisax: Replace dev_kfree_skb_any by dev_consume_skb_any Date: Thu, 14 Feb 2019 14:39:59 +0800 Message-Id: <1550126399-28063-1-git-send-email-huang.zijiang@zte.com.cn> X-Mailer: git-send-email 1.8.3.1 X-MIMETrack: Itemize by SMTP Server on SZSMTP06/server/zte_ltd(Release 8.5.3FP6|November 21, 2013) at 2019-02-14 14:39:42, Serialize by Router on notes_smtp/zte_ltd(Release 9.0.1FP7|August 17, 2016) at 2019-02-14 14:39:00, Serialize complete at 2019-02-14 14:39:00 X-MAIL: mse01.zte.com.cn x1E6dCnS048823 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The skb should be freed by dev_consume_skb_any() in hfcpci_fill_fifo() when bcs->tx_skb is still used. The bcs->tx_skb is be replaced by skb_dequeue(&bcs->squeue), so the original bcs->tx_skb should be consumed(not drop). Signed-off-by: Huang Zijiang --- drivers/isdn/hisax/hfc_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/isdn/hisax/hfc_pci.c b/drivers/isdn/hisax/hfc_pci.c index ea0e4c6..7f9e8cc 100644 --- a/drivers/isdn/hisax/hfc_pci.c +++ b/drivers/isdn/hisax/hfc_pci.c @@ -657,7 +657,7 @@ hfcpci_fill_fifo(struct BCState *bcs) schedule_event(bcs, B_ACKPENDING); } - dev_kfree_skb_any(bcs->tx_skb); + dev_consume_skb_any(bcs->tx_skb); bcs->tx_skb = skb_dequeue(&bcs->squeue); /* fetch next data */ } test_and_clear_bit(BC_FLG_BUSY, &bcs->Flag); -- 1.8.3.1