Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp1233273imj; Thu, 14 Feb 2019 03:23:22 -0800 (PST) X-Google-Smtp-Source: AHgI3IaI6TPqSLflmfCkX3jy4wxRvMk+v58ty+ZbTEGRCdPpM24RkYC/NafdV1FnF8H5luNmUmOi X-Received: by 2002:a17:902:1d4a:: with SMTP id u10mr3495717plu.122.1550143401942; Thu, 14 Feb 2019 03:23:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550143401; cv=none; d=google.com; s=arc-20160816; b=QMYabAxS/7VweJbx51acV0geYzoMudj2syMoIceVZNGOvyrGtXVjWKLZOdEZTt6dRM s/zjFX57j5F4gb4cdJdRbzgzo0p8q0jJTsnxUBApCFQKbhaKzxUzNAByEmefDyvzekwr kPPecO9sMIG0NiI1or0Sj91TaxelXII0+Hl3rnetBwahS+kiaQV9mVTQdtZhtPqThgvt I9iEkHXX/uoUe2oisd7J2q2A3zdlICoB19cKQ6sf9uL8eoCgLVDY3HYO3TO1lnUHNYP1 L3lOkcRh9xusAmmewxOFOAN8NwCJudcSQWCk70vL/XvlSyTMBHOhUgp5czSe0jmavZXr THqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=f9+9V2RaTOwYsVghddPn5lb0k05h+t2qygSvTfEVs58=; b=TXlR9Tr+E54wlT7juGm1th5QoDPCNabJJcUaYXPb2SGBsqXTOu8mPyresAMaChWt5H wMzkICJCFvYWjFyuqt0zglV3PP5Rn3SMj2Vj2Ca+cJnyeKuPzp4LPr4+lZQUrR/120Ii 8wRdi4Vj5ldhE08g5+361sGqG3H0L6GL6IE4PS8wapxScf5wbkpBm2AzCvNqdHwQwVdD Eo/lbWwdgb0wLIUUIzuMzb+IcwbuiG9rG02nY88ezFE2dIH1EmxAZCqOQN+0/5fjm11h rRBos9E4ObTOJXSFny60+Z8YACpWCqhgY8kJROHyPCWcPKkk/xLoZQbACyLh8/RNgMAv C+Pw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y20si2042857pgk.498.2019.02.14.03.23.06; Thu, 14 Feb 2019 03:23:21 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2436519AbfBNGkm (ORCPT + 99 others); Thu, 14 Feb 2019 01:40:42 -0500 Received: from out1.zte.com.cn ([202.103.147.172]:35172 "EHLO mxct.zte.com.cn" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387576AbfBNGkm (ORCPT ); Thu, 14 Feb 2019 01:40:42 -0500 Received: from mse01.zte.com.cn (unknown [10.30.3.20]) by Forcepoint Email with ESMTPS id 3D69082C464ABCCA13AB; Thu, 14 Feb 2019 14:40:39 +0800 (CST) Received: from notes_smtp.zte.com.cn ([10.30.1.239]) by mse01.zte.com.cn with ESMTP id x1E6e9fb050089; Thu, 14 Feb 2019 14:40:09 +0800 (GMT-8) (envelope-from huang.zijiang@zte.com.cn) Received: from fox-host8.localdomain ([10.74.120.8]) by szsmtp06.zte.com.cn (Lotus Domino Release 8.5.3FP6) with ESMTP id 2019021414403968-26035615 ; Thu, 14 Feb 2019 14:40:39 +0800 From: Huang Zijiang To: davem@davemloft.net Cc: quentin.monnet@netronome.com, jakub.kicinski@netronome.com, henrik@austad.us, dsahern@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, wang.yi59@zte.com.cn, Huang Zijiang Subject: [PATCH] net:dl2k: Replace dev_kfree_skb_irq by dev_consume_skb_irq Date: Thu, 14 Feb 2019 14:40:56 +0800 Message-Id: <1550126456-28233-1-git-send-email-huang.zijiang@zte.com.cn> X-Mailer: git-send-email 1.8.3.1 X-MIMETrack: Itemize by SMTP Server on SZSMTP06/server/zte_ltd(Release 8.5.3FP6|November 21, 2013) at 2019-02-14 14:40:39, Serialize by Router on notes_smtp/zte_ltd(Release 9.0.1FP7|August 17, 2016) at 2019-02-14 14:39:58, Serialize complete at 2019-02-14 14:39:58 X-MAIL: mse01.zte.com.cn x1E6e9fb050089 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org dev_consume_skb_irq() should be called when skb xmit done.It makes drop profiles more friendly. Signed-off-by: Huang Zijiang --- drivers/net/ethernet/dlink/dl2k.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/dlink/dl2k.c b/drivers/net/ethernet/dlink/dl2k.c index f0536b1..21810bf 100644 --- a/drivers/net/ethernet/dlink/dl2k.c +++ b/drivers/net/ethernet/dlink/dl2k.c @@ -843,7 +843,7 @@ rio_free_tx (struct net_device *dev, int irq) desc_to_dma(&np->tx_ring[entry]), skb->len, PCI_DMA_TODEVICE); if (irq) - dev_kfree_skb_irq(skb); + dev_consume_skb_irq(skb); else dev_kfree_skb(skb); -- 1.8.3.1