Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp1234435imj; Thu, 14 Feb 2019 03:24:32 -0800 (PST) X-Google-Smtp-Source: AHgI3IYZw3sWk/prlnHWa74auBhVrB/s8qnx1vRhGDJXPCOA96n6GrKfnl2rH5b/y5guYf/QnidU X-Received: by 2002:a17:902:2a0a:: with SMTP id i10mr3505459plb.323.1550143472851; Thu, 14 Feb 2019 03:24:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550143472; cv=none; d=google.com; s=arc-20160816; b=zSEonxBO+Gww6ZYiBx3SGmipzk4I0C8hFkN1eDjsyJMLvt46DTqp+1Lb+BEs6DnHtP 63K56EKbUyaErj97HdB7gPKLI5OrUpA4P0FkS8uc2o5Kr/vBUPlbv2/f6Mma5k0U50Pa lzlTpLFbJ1za2kR+1hTY779is/rHioQkbj0wYT7W+SpaNPFYFa/WawDLYR4HUSUGucCs XIc5D/sbmow3nFi+RFZqnTR3evx0if5a/AAn62FJAehlnDnZQHUO5vVQgKy6473O7OeB LeVrkbvnupL1uY66sJ1I1VUJ/WP+mbFT1ItDvNO0EXjqTt1rJpJXfzfwjaPgB2pq61OA Giag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=mEUprc5EMqaRA8NzTH5eij6EqXtSnvG7q1EVPwMO4pQ=; b=0VcK/om3IwagdR1obOFdTu+cEIRhey7LB4VFKKxJf8zyhTBSFX01LeuSGJ/3uY8Fq7 bya9lCSHSUwXx9uDqz3azWkUpqGTrzyuib/dUrk71cL7AsayN1JZTPyTVOgHtjaP7Kod EOS+/GZLhKhnvtxz2pCPU/RNyk/u8upK3YiTMSoM4a4jCkZ7J6g0EqBT9rEqNT0KMlBX qyUMuOf6B2ByyjHIxtjk+zbKjjxkUHglw5pHK3n/AI3A0J0ziER0a791FNU8DvxOBMJ4 A+iUPy6NQxpeKnTX/Os4+XZx8N0luS7DzNJb54rKijWfLx5xBnGeuIXV7uw8s9dvR4Jr umRQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 19si2125841pgq.215.2019.02.14.03.24.17; Thu, 14 Feb 2019 03:24:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2436904AbfBNGlg (ORCPT + 99 others); Thu, 14 Feb 2019 01:41:36 -0500 Received: from out1.zte.com.cn ([202.103.147.172]:35868 "EHLO mxct.zte.com.cn" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2394037AbfBNGlg (ORCPT ); Thu, 14 Feb 2019 01:41:36 -0500 Received: from mse01.zte.com.cn (unknown [10.30.3.20]) by Forcepoint Email with ESMTPS id 97654A10604BA685D497; Thu, 14 Feb 2019 14:41:31 +0800 (CST) Received: from notes_smtp.zte.com.cn ([10.30.1.239]) by mse01.zte.com.cn with ESMTP id x1E6fQej051178; Thu, 14 Feb 2019 14:41:26 +0800 (GMT-8) (envelope-from huang.zijiang@zte.com.cn) Received: from fox-host8.localdomain ([10.74.120.8]) by szsmtp06.zte.com.cn (Lotus Domino Release 8.5.3FP6) with ESMTP id 2019021414415656-26036134 ; Thu, 14 Feb 2019 14:41:56 +0800 From: Huang Zijiang To: linux-net-drivers@solarflare.com Cc: ecree@solarflare.com, bkenward@solarflare.com, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, wang.yi59@zte.com.cn, Huang Zijiang Subject: [PATCH 2/2] net: Replace dev_kfree_skb_any by dev_consume_skb_any Date: Thu, 14 Feb 2019 14:42:13 +0800 Message-Id: <1550126533-28462-1-git-send-email-huang.zijiang@zte.com.cn> X-Mailer: git-send-email 1.8.3.1 X-MIMETrack: Itemize by SMTP Server on SZSMTP06/server/zte_ltd(Release 8.5.3FP6|November 21, 2013) at 2019-02-14 14:41:56, Serialize by Router on notes_smtp/zte_ltd(Release 9.0.1FP7|August 17, 2016) at 2019-02-14 14:41:15, Serialize complete at 2019-02-14 14:41:15 X-MAIL: mse01.zte.com.cn x1E6fQej051178 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The skb should be freed by dev_consume_skb_any() efx_tx_tso_fallback() when skb is still used. The skb is be replaced by segments, so the original skb should be consumed(not drop). Signed-off-by: Huang Zijiang --- drivers/net/ethernet/sfc/tx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/sfc/tx.c b/drivers/net/ethernet/sfc/tx.c index c3ad564..ed551f0 100644 --- a/drivers/net/ethernet/sfc/tx.c +++ b/drivers/net/ethernet/sfc/tx.c @@ -471,7 +471,7 @@ static int efx_tx_tso_fallback(struct efx_tx_queue *tx_queue, if (IS_ERR(segments)) return PTR_ERR(segments); - dev_kfree_skb_any(skb); + dev_consume_skb_any(skb); skb = segments; while (skb) { -- 1.8.3.1