Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp1601563imj; Thu, 14 Feb 2019 09:01:00 -0800 (PST) X-Google-Smtp-Source: AHgI3IaL4f0n+c/V6av8gUNP4qHX6h6r82RiEnt2NpJ9iQeLcU4OB91B11ZDY9EokUOV94zPo1b7 X-Received: by 2002:a63:d444:: with SMTP id i4mr4653262pgj.237.1550163659951; Thu, 14 Feb 2019 09:00:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550163659; cv=none; d=google.com; s=arc-20160816; b=e0Xh1K7WD4w/kp+aZJSuk3eGUiuL3VZZSPMYmlC8n4T3gr81/z48E0+5o90w+IWBTZ wNtJ5R4+9kc7SfPnWdvSrzNf0vno3sYcTmnNzVZpQm4EGsyDSoJVG8544TGyDoUnkTcc zpZsC/+/kq7B1tgK9VZNGu+3ePBcNZ0stLSup+KEx1xXzht+Yzrtqez0sIqF//ErzXoD gWu/EZvy804vhpcK0qw4ALash6XvYgpndJLvwYjnUEoNtlpBXChEDRrUKbUKJK0Mwlk2 uu+T+rfuxl85olJ8gdnPWFKCpvrDQf4i4SRFlVHXZdH1Sjy+AdfdWv4wDn8P6pv6OB2A TY0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=bheLtZPV7pm0gY8PJ5wrEfJzea3Duu04eNSgouxwohA=; b=CMBC5KlSlgByIo6krqC7Op/hGGkBF+XON8YpsFMqxi/Ifv2ea+vXoVGkTVClQrUq1p OgNTsKdkdvKfuSyAiPYr3dLM9jiOJxwlDryvHpzXBVi/rrZ6PuYMXMuqve2/uIwPLgsT sgTyb8Kk5cfcWKMoyu+fd4GZl2VVitKA70Udo5hqRLOzM+BGPIQArmaIuKW+sO3xqnrN 5duskbFDYMFiFfxZUNjvsdZxFGZY3JXV7jQl6dxsozdFPBMm5sx2RBcmmE9p/4SZF7NY YAx1urCNfvi5o0aID523cFIJXKvs6d5KOIBlNfJAnZijUU53dvEYcvRVqUcy70p9+UR/ x3zQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=ICpS4Jyy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z22si2901675pfd.197.2019.02.14.09.00.41; Thu, 14 Feb 2019 09:00:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=ICpS4Jyy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437438AbfBNHs0 (ORCPT + 99 others); Thu, 14 Feb 2019 02:48:26 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:41524 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437428AbfBNHsZ (ORCPT ); Thu, 14 Feb 2019 02:48:25 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x1E7i48V029171; Thu, 14 Feb 2019 07:48:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=bheLtZPV7pm0gY8PJ5wrEfJzea3Duu04eNSgouxwohA=; b=ICpS4Jyynk4Mw0HFyYC9iCHp7VY0oDsKLIr2LWp8TxIfJPx402bJr8maqICi4faCKRil 8MzDnuLcMLG+NRodudXpi2Ac9BZyVmeDypZW0HgtxV+j0cDcaPen/FaKiesJrPHpgqYa eza/Hn3YsbQ2vB6sH9ufJeoLiUlMA4ZCADQoDLkSjt65CZE34vrFufQfQrScF5H13RMM y2SC0mF9LJjSR6niJE471AUqHz31tRDVYxUKZosJP3VpfsxAo25uujP1OgXW41fLPvv3 2dvFY9WwMBNZWiCi+NMxlWvmQQYvNDupaqUknSW5ywQ6GJBAFXnygemx1qrFQyKqiJ5b Tg== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2120.oracle.com with ESMTP id 2qhree6csb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 14 Feb 2019 07:48:11 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id x1E7mAjx020057 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 14 Feb 2019 07:48:11 GMT Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x1E7mA6v024127; Thu, 14 Feb 2019 07:48:10 GMT Received: from kadam (/41.202.241.28) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 14 Feb 2019 07:48:09 +0000 Date: Thu, 14 Feb 2019 10:48:01 +0300 From: Dan Carpenter To: Julia Lawall Cc: Jan Harkes , coda@cs.cmu.edu, codalist@telemann.coda.cs.cmu.edu, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] fs/coda: get rid of CODA_ALLOC() Message-ID: <20190214074801.GC2304@kadam> References: <20190214065848.GB21768@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9166 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=601 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1902140058 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 14, 2019 at 08:04:43AM +0100, Julia Lawall wrote: > > > On Thu, 14 Feb 2019, Dan Carpenter wrote: > > > These days we have kvzalloc() so we can delete CODA_ALLOC(). > > Maybe it would be better to get rid fo CODA_FREE as well? > Actually, you're right. CODA_FREE() is especially weird without a CODA_ALLOC(). But let me send that as a second patch. regards, dan carpenter