Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp1609973imj; Thu, 14 Feb 2019 09:07:27 -0800 (PST) X-Google-Smtp-Source: AHgI3IZdawAqnQvq8rv4qXgtPPvj+nA1zLCbMh1EN/GWCwj7E/jLUAEsLQ1Dp/J30rlTOsvgMzvH X-Received: by 2002:a17:902:f20b:: with SMTP id gn11mr5109672plb.274.1550164046841; Thu, 14 Feb 2019 09:07:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550164046; cv=none; d=google.com; s=arc-20160816; b=lPEaomGae4C4cijX725Z2t84gPwZDIeuQlto8oiSUNXirWZDqIN6cf8kop7vdPZpyx D2TTni+qFuF7Wm6gk7F4sO/t0KLUCzMqYXV+aUOz3UgDf8Xbu601OngHEC3oCjavPmyb w3D1RQ6qWl/sADsDL+Kc18a0VKsRJAf/xCuaegaDfELsgFiHG4mwaveUZO4pz5Hh6Zsm YsLoH8fLbbjOrgWec2a4IBo0kQNzy0/5QuMK8GTe7e92A4W7pe7tvhqcUOj+RRTJQ1rD 3vLBOplGUtz03OIULmFD3dk6+dYF1OWsq5MYDKskl7HTYhQqDZyGbnogWTMhdwDBj8Is OVhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=zhCnZvf23aeo06nIRSdaHF4egKBLiYeTJxSjOgwTDYc=; b=Rijp6qVQitYsb5PamghSobBeVg4P2cAX1MdS0dZdInvLimEDRnnIwGoUFIpoICTmT/ DRTEyrzlyUyIA326dGhYVN1yip6ufTMLAGsmZK4XZMD2TC3CBuf3Z+MRwa1QDiHS4xFn 4pkWJtdW+H+zhXhjcSG7HuYFxkqeAQ0f681JtRZAyPhwSxtYAu23z0+0yIxWnQUUZWfN 6w3k9j2/XoX0LzIRiMqbykAcZWRT1Gr1bAjUq3f/8rz7iRI9fm72fxnO9+aT+Oe1v8ZE NGfX7OB+VsYz+eQnogFDKq3RQemyxMitf4VHyVlZI8/WzdSXSKizokYRgoiFc4t4ngMW nnAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@brainfault-org.20150623.gappssmtp.com header.s=20150623 header.b=XKrJ9+pB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u10si2779183pgi.515.2019.02.14.09.07.10; Thu, 14 Feb 2019 09:07:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@brainfault-org.20150623.gappssmtp.com header.s=20150623 header.b=XKrJ9+pB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437494AbfBNI2z (ORCPT + 99 others); Thu, 14 Feb 2019 03:28:55 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:54796 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388304AbfBNI2z (ORCPT ); Thu, 14 Feb 2019 03:28:55 -0500 Received: by mail-wm1-f67.google.com with SMTP id a62so5294288wmh.4 for ; Thu, 14 Feb 2019 00:28:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brainfault-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zhCnZvf23aeo06nIRSdaHF4egKBLiYeTJxSjOgwTDYc=; b=XKrJ9+pBjGPkXDmUzz4oN+e+A16SNuQde6dQsKxEmM5tWCWdAQNdGYwIz3NaP8t5XZ bAVPl89OWKreVzDzPzItjlcir/pZqRItpGNPN6iFmxlRFwpn8M2aDqh0464VaVAsRK8W wMzReVl6xLnrnSd8xO+SM0H4vwftkROmNAoYyxvO81FxRjjxDOlkwyPq7Y3Nt9jU5Lg9 AUzIMrKaoQXwtLmyUDS1m0DKmX31bC4vprp+5LE2fOnATIQ6DN3blenE+C/mspP6cL45 q0hYlBnkrzZ9+O2NqACS2OV1MCeFlW4moNgPa0h7cih+dgh29xlZkgk+oxJjk+2PAdsi GfBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zhCnZvf23aeo06nIRSdaHF4egKBLiYeTJxSjOgwTDYc=; b=pME094OFUY/iVxsXVw8DK7XRslIDE3sEd1C2r2tZ6kxu81V4RU5efNNWaQbZrkMhX0 VT0qAGhGH12LYnhje6/i9lQAmJAs6fycgW8eWloz52ot6nz51ouAPiKNv7XEYWeMhct+ 09E4NIiuXX4TYYHxSvmZB4e047INJBqQx8S228lYGx1uWmQlxicaIgqsV1/v8HoKI2Rg K77OTnvxhftj1JYBjoTB8jqy/awZZMXTAuPexHe8/bvDX29DnC+E0NpGmx9bhpLuD2PC Q/w4xEQd3utYTqoT+k8BjuY7/sF8epZ98r7Gj9j6goHUyEhR582eGCb3hpFW6rYFTpPF 7sEQ== X-Gm-Message-State: AHQUAuZWTirdlmNdB9Ev4dQBZ1dYhy1FnRy2uIdFj8QtyybKUjJqwUEb PxXtmVgWq2sWSowMPPZotkTTLT34fsT0syb2b6Bp/g== X-Received: by 2002:a1c:a3c3:: with SMTP id m186mr1685443wme.16.1550132931258; Thu, 14 Feb 2019 00:28:51 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Anup Patel Date: Thu, 14 Feb 2019 13:58:39 +0530 Message-ID: Subject: Re: [PATCH v2 0/6] Fixmap support and MM cleanups To: Palmer Dabbelt Cc: Anup Patel , Albert Ou , Atish Patra , Paul Walmsley , Christoph Hellwig , linux-riscv@lists.infradead.org, "linux-kernel@vger.kernel.org List" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 14, 2019 at 6:07 AM Palmer Dabbelt wrote: > > On Wed, 13 Feb 2019 00:21:43 PST (-0800), anup@brainfault.org wrote: > > On Wed, Feb 13, 2019 at 4:45 AM Palmer Dabbelt wrote: > >> > >> On Sat, 19 Jan 2019 05:27:53 PST (-0800), Anup Patel wrote: > >> > This patchset does: > >> > 1. Moves MM related code from kernel/setup.c to mm/init.c > >> > 2. Implements compile-time fixed mappings > >> > > >> > Using fixed mappings available, we can now get earlyprints > >> > even without SBI calls. For example, we can use kernel > >> > parameter "earlycon=uart8250,mmio,0x10000000" to get early > >> > prints on QEMU virt machine without using SBI calls. > >> > > >> > The patchset is tested on QEMU virt machine. It is based on > >> > Linux-5.0-rc2 and can be found at riscv_fixmap_v2 branch of: > >> > https://github.com/avpatel/linux.git. > >> > > >> > Changes since v1: > >> > - Use more characters per line in changelog of PATCH3 > >> > - Removed #ifndef __ASSEMBLY__ from PATCH5 > >> > - Use more characters per line in commets of PATCH5 > >> > - Added PATCH6 to implement keepinitrd kernel parameter > >> > > >> > Anup Patel (6): > >> > RISC-V: Move free_initrd_mem() to kernel/setup.c > >> > RISC-V: Setup init_mm before parse_early_param() > >> > RISC-V: Move setup_bootmem() to mm/init.c > >> > RISC-V: Move setup_vm() to mm/init.c > >> > RISC-V: Implement compile-time fixed mappings > >> > RISC-V: Implement keepinitrd kernel parameter > >> > > >> > arch/riscv/Kconfig | 3 + > >> > arch/riscv/include/asm/fixmap.h | 44 +++++++++++ > >> > arch/riscv/include/asm/pgtable.h | 1 + > >> > arch/riscv/kernel/setup.c | 114 ++++++---------------------- > >> > arch/riscv/mm/init.c | 124 ++++++++++++++++++++++++++++++- > >> > 5 files changed, 189 insertions(+), 97 deletions(-) > >> > create mode 100644 arch/riscv/include/asm/fixmap.h > >> > >> I'm getting some git issue when trying to merge the third patch via email > >> > >> $ mhng-pipe-show_stdout 4 | git am -s > >> Applying: RISC-V: Move setup_bootmem() to mm/init.c > >> error: patch failed: arch/riscv/kernel/setup.c:163 > >> error: arch/riscv/kernel/setup.c: patch does not apply > >> Patch failed at 0001 RISC-V: Move setup_bootmem() to mm/init.c > >> Use 'git am --show-current-patch' to see the failed patch > >> When you have resolved this problem, run "git am --continue". > >> If you prefer to skip this patch, run "git am --skip" instead. > >> To restore the original branch and stop patching, run "git am --abort". > >> > >> can you send a PR with a signed tag? I'll include this as part of the next > >> merge window. > >> > >> Reviewed-by: Palmer Dabbelt > > > > Okay, I will prepare a PR with following patchsets: > > 1. Fixmap support and MM cleanups (Author: Anup Patel) > > 2. riscv: minor fixes and cleanups (Author: Johan Hovold) > > 3. RISC-V related changes from "Various SMP related fixes" (Author: Atish Patra) > > > > All above patchsets touch same source files so this will > > help you. > > Thanks. There's also a handful of comments from Christoph that I agree with > about the keepinitrd stuff. I have sent PR with Fixmap patches only. Johan and Atish will rebase their patches based on your tree. Regards, Anup