Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 14 Feb 2019 16:27:30 +0800
From:   Tom Li <tomli@tomli.me>
To:     Aaro Koskinen <aaro.koskinen@iki.fi>
Cc:     linux-mips@vger.kernel.org, Jiaxun Yang <jiaxun.yang@flygoat.com>,
        Huacai Chen <chenhc@lemote.com>,
        Ralf Baechle <ralf@linux-mips.org>,
        Paul Burton <paul.burton@mips.com>,
        James Hogan <jhogan@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/1] mips: loongson64: move EC header to
 include/asm/mach-loongson64
Message-ID: <20190214082729.GA24527@localhost.localdomain>
References: <20190210130617.8392-1-tomli@tomli.me>
 <20190210132505.GA22242@darkstar.musicnaut.iki.fi>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="yrj/dFKFPuw6o+aM"
Content-Disposition: inline
In-Reply-To: <20190210132505.GA22242@darkstar.musicnaut.iki.fi>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--yrj/dFKFPuw6o+aM
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> Hi,
> > Yifeng Li (1):
> >   mips: loongson64: move EC header to include/asm/mach-loongson64
>=20
> This probably should be MFD driver under drivers/mfd. It's a longer
> road, though...
>=20
> A.

The problem of converting it to a MFD driver, is that there's still
something doesn't fit together.

The core CPU idle code in loongson64/common calls the platform code
in arch/mips/loongson64/lemote-2f to set up an interrupt handler in
i8259, and inspect if the source of interrupt is an lid open event by
querying the ENE KB3310B controller. But normally an MFD driver is
only used to share the underlying hardware between multiple drivers
in each subsystem, not to provide shared utilily functions.

But after reading drivers/mfd for a while, apparently we do have drivers
that "EXPORT_SYMBOL()" to other parts of the kernel. So I think it's
a matter of fact that can be discussed with MFD maintainers.

So yes, I'm converting all the EC code to a MFD driver. I have withdrawn
this patch, do not merge it. The new MFD patch is coming soon.

Thanks,
Tom Li

--yrj/dFKFPuw6o+aM
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEJVIRsjlaWj4OSKDx+tPrBeiOjW0FAlxlJmwACgkQ+tPrBeiO
jW0gZRAAsr0VmeZ+3F9pjcwFriDKNfVLB0QxKTakR8SiubPGzoylkskeMqo+ZQcM
2xSE2WgsSH7nKXRhHPsdm5G1C4QEBWE7eaNXVhHwQICawQRPOcrdShIGr3w73NAw
KlHQ8g4ICW+eNLnRmz5aFoPW2FD7VCaCiVAH978jQMz2y0ZTAS6WPwddM9GUsT3Q
U0baHWyUL1eEbQFMSx8j4aMhIqey7ZcT3V93EhsJk5NjmDZmaS+ws7TrXkcrsV+j
Swj3IFexpmSvJn5K7ljv2TV2BxjWSdmXqHoP2j4YgI4VfADjRu0nnvRcAlkm+TX8
bqz7lFZCg7DRAwKsubfieEz2Gt5R7GqpQjto5qkpHT7BGD47Fg7zEb02ogWMcrII
DpHW+OgCVdSpfxZCIG4AQuQ45iGrHPMMHyn1dNuesfLPn4POW+NuVjNfnm1FQ7Eg
YkKZ9khDN6HLk98BeI11FavdircdKQ2BZSdL22SG8TMtqmpSMYHa3gI//Hl2n4R7
rLmbcLbyWywwNbKiNs0vAxf2T9ob4vQD4yBlQwAh+jhiwpar5/OWK4CUaTo5v0Fd
6D/Dbmrzi3OgDzUuQhVmlXSUk6grpdM83Abfhkv4w6F+uCgsfwUY0+tuxBNUnfS5
EbaQs04daYoS6Wclcugw26pUeOXFAXTWSCyTrJZvrgzQnwpX00o=
=jQzt
-----END PGP SIGNATURE-----

--yrj/dFKFPuw6o+aM--