Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 2/2] net: Replace dev_kfree_skb_any by dev_consume_skb_any
To:     Huang Zijiang <huang.zijiang@zte.com.cn>,
        linux-net-drivers@solarflare.com
Cc:     ecree@solarflare.com, bkenward@solarflare.com, davem@davemloft.net,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        wang.yi59@zte.com.cn
References: <1550126533-28462-1-git-send-email-huang.zijiang@zte.com.cn>
From:   Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Message-ID: <c523a131-3177-00d8-099f-023c949d6932@cogentembedded.com>
Date:   Thu, 14 Feb 2019 12:13:08 +0300
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.0
MIME-Version: 1.0
In-Reply-To: <1550126533-28462-1-git-send-email-huang.zijiang@zte.com.cn>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hello!

On 14.02.2019 9:42, Huang Zijiang wrote:

> The skb should be freed by dev_consume_skb_any() efx_tx_tso_fallback()
                                                   ^ in?

> when skb is still used. The skb is be replaced by segments, so the
                                   ^^ will?

> original skb should be consumed(not drop).
> 
> Signed-off-by: Huang Zijiang <huang.zijiang@zte.com.cn>
[...]

MBR, Sergei