Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 2/2] net: Replace dev_kfree_skb_any by dev_consume_skb_any
To:     Huang Zijiang <huang.zijiang@zte.com.cn>,
        <linux-net-drivers@solarflare.com>
CC:     <ecree@solarflare.com>, <davem@davemloft.net>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <wang.yi59@zte.com.cn>
References: <1550126533-28462-1-git-send-email-huang.zijiang@zte.com.cn>
From:   Bert Kenward <bkenward@solarflare.com>
Message-ID: <f0f1b6ea-9568-c3e9-a92e-43fc87d253c4@solarflare.com>
Date:   Thu, 14 Feb 2019 09:34:21 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.4.0
MIME-Version: 1.0
In-Reply-To: <1550126533-28462-1-git-send-email-huang.zijiang@zte.com.cn>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 14/02/2019 06:42, Huang Zijiang wrote:
> The skb should be freed by dev_consume_skb_any() efx_tx_tso_fallback()
> when skb is still used. The skb is be replaced by segments, so the
> original skb should be consumed(not drop).
> 
> Signed-off-by: Huang Zijiang <huang.zijiang@zte.com.cn>

Sergei's commit message fixups look good, but apart from that:

Acked-by: Bert Kenward <bkenward@solarflare.com>

> ---
>  drivers/net/ethernet/sfc/tx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/sfc/tx.c b/drivers/net/ethernet/sfc/tx.c
> index c3ad564..ed551f0 100644
> --- a/drivers/net/ethernet/sfc/tx.c
> +++ b/drivers/net/ethernet/sfc/tx.c
> @@ -471,7 +471,7 @@ static int efx_tx_tso_fallback(struct efx_tx_queue *tx_queue,
>  	if (IS_ERR(segments))
>  		return PTR_ERR(segments);
>  
> -	dev_kfree_skb_any(skb);
> +	dev_consume_skb_any(skb);
>  	skb = segments;
>  
>  	while (skb) {
>