Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Jaehoon Chung <jh80.chung@samsung.com>
To:     linux-usb@vger.kernel.org
Cc:     hminas@synopsys.com, gregkh@linuxfoundation.org,
        linux-kernel@vger.kernel.org, m.szyprowski@samsung.com,
        Jaehoon Chung <jh80.chung@samsung.com>
Subject: [PATCH] usb: dwc2: hcd: call dwc2_is_controller_alive under
 spinlock
Date:   Thu, 14 Feb 2019 19:03:42 +0900
Message-Id: <1550138622-10761-1-git-send-email-jh80.chung@samsung.com>
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <CGME20190214100344epcas1p316a40d88f3b52a10745c95cc3d16a0ed@epcas1p3.samsung.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

This patch is referred to Robert's patch
commit cf54772b913b ("usb: dwc2: call dwc2_is_controller_alive() under spinlock")

During running sdb with otg mode, the usb is hung sometime.

The one of SDB hang issues should be fixed with this patch.
After hang, it doesn't never trigger the usb interrupt.

Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
---
 drivers/usb/dwc2/hcd_intr.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/dwc2/hcd_intr.c b/drivers/usb/dwc2/hcd_intr.c
index 88b5dcf..8d3b155 100644
--- a/drivers/usb/dwc2/hcd_intr.c
+++ b/drivers/usb/dwc2/hcd_intr.c
@@ -2222,13 +2222,13 @@ irqreturn_t dwc2_handle_hcd_intr(struct dwc2_hsotg *hsotg)
 	u32 gintsts, dbg_gintsts;
 	irqreturn_t retval = IRQ_NONE;
 
+	spin_lock(&hsotg->lock);
+
 	if (!dwc2_is_controller_alive(hsotg)) {
 		dev_warn(hsotg->dev, "Controller is dead\n");
-		return retval;
+		goto out;
 	}
 
-	spin_lock(&hsotg->lock);
-
 	/* Check if HOST Mode */
 	if (dwc2_is_host_mode(hsotg)) {
 		gintsts = dwc2_read_core_intr(hsotg);
@@ -2276,6 +2276,7 @@ irqreturn_t dwc2_handle_hcd_intr(struct dwc2_hsotg *hsotg)
 		}
 	}
 
+out:
 	spin_unlock(&hsotg->lock);
 
 	return retval;
-- 
2.7.4