Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp1663820imj; Thu, 14 Feb 2019 09:58:36 -0800 (PST) X-Google-Smtp-Source: AHgI3IaWNarCZJrl9JLeMrsuDF5izTQcZGV5ZUqHOSUBDo4r96jM+vyW3j66XqS6ejwGGosYCS/D X-Received: by 2002:a62:1303:: with SMTP id b3mr5471339pfj.147.1550167116566; Thu, 14 Feb 2019 09:58:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550167116; cv=none; d=google.com; s=arc-20160816; b=uNrm4aXbhG9cKRaO1G3KFn2lIMYpaPsdYb8sakNSQkTtA28saQuf1hRyZ4sC2uZS7i IWUI6coi7MftQSfxucQTGugbBQRbF9UXPOdCzXCXuIQZ15Gw38trsPfU6+XaCiOmX62n X68yF4m1vwtiFA9mfSzffM1rgMjLigZSdArr5Ym2ZeBxDiht3NHeY6OsZKvwlm5mW9ra QJAhURFll5PS8CCs9Kz1w7owH4qt1+Io3RNXQ8rs2ytrnAsFjbCBkD3Z68DYcf4hP1K4 kCJkLA34oSKyAGfJWEdM9P6YD8Bz7Fx1QrzbSeWhzUfD+pzXn5D3nFoD3bLj8P4N8ti8 3DYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=c0kFHfZ84l6hN8EV9uyA/B2ofXSPwbG72w/+ZdCqcD0=; b=URUIxok+geC8BvQfm9+fDKxRG+sbbvdl4eQ6Vm+SiKrhhzX5WQ4zzGogF62KbKAwzB 0QP7p0KSwA7j/nPKo+Qd8I5xbADFZCfwyKMAKImgczi3ZdDwlu5/wwm9Drlqq69Ry226 kS+zjtGw0JOG6m0JnbvNLnYvgdlasxiIptr8GhEMbaR1AFNdw4PcOrjSg6KsACWBjzjc Tpej2JXBAubeOKIkkvB4QHMdXZMJXpOiAmmgGFniNdBo2HWngPEvkFIzXV17ibQ3itC/ k7VKxKwWLrHllSuhyEzl1F+FzC6+NbQcgtw2SB4sxaiwe8KSMV1cCGiq6/5LYpED8zp+ L+fg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b="g/ponYXH"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o184si3133920pfb.72.2019.02.14.09.58.21; Thu, 14 Feb 2019 09:58:36 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b="g/ponYXH"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388348AbfBNKTN (ORCPT + 99 others); Thu, 14 Feb 2019 05:19:13 -0500 Received: from merlin.infradead.org ([205.233.59.134]:53990 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727061AbfBNKTN (ORCPT ); Thu, 14 Feb 2019 05:19:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=c0kFHfZ84l6hN8EV9uyA/B2ofXSPwbG72w/+ZdCqcD0=; b=g/ponYXHA78ychLKY1mGZ/yXH nNrAmpYw5l8MP5O5jovQqausTg7/zPIrpVjKj0NgBA2PNNWAkq3ZcMTmBy+aJryDnCyg45pKk3yGb qO1cThnn8FBmxVhVMCU8/dR0Hb07aD2kbVfLwNj+t488P6To9vGFLC3fKlwS5eLKHp+aCYrE5yiGm 9LaYfuRoFNu+CigGjCLNhqxxw2mPtWHX+agTqdObvVMQ8CRVBep/NYwKWigf2P+UK/PrLXLTXNXjJ h4LVW1lRheTqm/hwCHdmek6WPki+pwbP3O8oHcHyQP+V5/EQMU8pvqn64ksYtPihUrDrGYMTRU1nS RFNGYv3VQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1guE6n-0000h5-Qp; Thu, 14 Feb 2019 10:19:10 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 6DCEF20298375; Thu, 14 Feb 2019 11:19:07 +0100 (CET) Date: Thu, 14 Feb 2019 11:19:07 +0100 From: Peter Zijlstra To: Huang Zijiang Cc: mingo@redhat.com, linux-kernel@vger.kernel.org, wang.yi59@zte.com.cn Subject: Re: [PATCH] sched/core: Remove BUG_ON() Message-ID: <20190214101907.GE32494@hirez.programming.kicks-ass.net> References: <1550126557-28530-1-git-send-email-huang.zijiang@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1550126557-28530-1-git-send-email-huang.zijiang@zte.com.cn> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 14, 2019 at 02:42:37PM +0800, Huang Zijiang wrote: > pick_next_task is never return NULL because idle task > will return when cpu is idle. And to be sure it does; we have that BUG_ON :-)