Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.2\))
Subject: Re: [PATCH] mm/shmem: make find_get_pages_range() work for huge page
From:   William Kucharski <william.kucharski@oracle.com>
In-Reply-To: <20190212235743.GB95899@google.com>
Date:   Thu, 14 Feb 2019 04:18:24 -0700
Cc:     Matthew Wilcox <willy@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Amir Goldstein <amir73il@gmail.com>,
        Dave Chinner <david@fromorbit.com>,
        "Darrick J . Wong" <darrick.wong@oracle.com>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Souptick Joarder <jrdr.linux@gmail.com>,
        Hugh Dickins <hughd@google.com>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 7bit
Message-Id: <404C0A0A-F145-4622-B3EB-492D0FFB7CB6@oracle.com>
References: <20190110030838.84446-1-yuzhao@google.com>
 <A7BE64E0-8F88-46AC-A330-E1AB23A50073@oracle.com>
 <20190212235743.GB95899@google.com>
To:     Yu Zhao <yuzhao@google.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> On Feb 12, 2019, at 4:57 PM, Yu Zhao <yuzhao@google.com> wrote:
> 
> It seems to me it's pefectly fine to use fields of xas directly,
> and it's being done this way throughout the file.

Fair enough.

Reviewed-by: William Kucharski <william.kucharski@oracle.com>