Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp1708269imj; Thu, 14 Feb 2019 10:39:47 -0800 (PST) X-Google-Smtp-Source: AHgI3IbC3h32QCaMuWZRdZtNuU2RrE+uk0gP18e1lEdhw6zEYD2qSwZB0bjy8NwE6UoXl+eai7kI X-Received: by 2002:a62:2cf:: with SMTP id 198mr5511537pfc.67.1550169587416; Thu, 14 Feb 2019 10:39:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550169587; cv=none; d=google.com; s=arc-20160816; b=VTpKSn1rhpWy7SCAF4dsBqTdK7Wg5XR2fwmTdqmYlbPFfICTZ3RhQ60g1eZZjHqYrC MUXDHGimDTmtsEPhtmMEcfF5ANlb4B6q5DifLbagdsfT2wINZHokRjzc3JPOrmwG3NTy KuFfqCWpNufWKGnJmxJoMbC5ib/Bu4fsW/dWtQRICnvVv7aKuRQXRT5djVqjhciGXUiE Qc7dz1Clh9MB0czQrLmJA68WVtFy8hz60TgnFih5CHhIMzVDH1EUUu1+q0IpkZXj+Gr9 0QIpo41MkrpzPXyvbiDMp1E54nYqp15QHY6aMkot88pAOPk+EUP+hlw+b9cKOCEIRrji mk4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:subject:cc:to:from:date:dkim-signature; bh=nmwfSFeC4FsqEsRAQeWk8q7Q6CO3g44fKSuw4zQ0SnU=; b=FLC7EfPfMOCC9+7EMhf8fA9lc5w+Z32aCEMptOKZixlvhLj7R/ALkxviVAKrewrosZ vjbSndMq037nyh8x36Ygq8V4S6RchOCFS4cI7nCG5heeH4Wmm+/YcgRZ3/WNgUUlC+eH QaqK4kCVgeu0/ZNOwg6n+KJ9RYigqSLBnABvH2Dpb6JnMYDVaul85wBzJMmHjDStd7Yb SBVNVXJs7Ak+mYXqewzsAf7g5S/6AVhgWz4xnaTuDc6y8nEu8PfZE/zVROKmi3SbmemL ZJScXFENLLNA1y1Oc+pSKyGdEzH9EiJjOXOvJacGJIkDZQxaxfWjmPX7AdgJR9zcPwht Db2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=RD525zH2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y35si3074541pgl.569.2019.02.14.10.39.31; Thu, 14 Feb 2019 10:39:47 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=RD525zH2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404858AbfBNLbU (ORCPT + 99 others); Thu, 14 Feb 2019 06:31:20 -0500 Received: from mail-pg1-f196.google.com ([209.85.215.196]:40102 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387558AbfBNLbU (ORCPT ); Thu, 14 Feb 2019 06:31:20 -0500 Received: by mail-pg1-f196.google.com with SMTP id z10so2932423pgp.7 for ; Thu, 14 Feb 2019 03:31:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version :content-transfer-encoding; bh=nmwfSFeC4FsqEsRAQeWk8q7Q6CO3g44fKSuw4zQ0SnU=; b=RD525zH2ap13pMVTMSqQug5kuY/j9rZnobPuh/auwCflvOvw1nA+62upri7KNjTCZP /yGR2o+vf6ba10sdeAqCqvEtx3RbD+HLOVARiCHicyNBa4sIFW4WNWm4SNcDLtDFOtBa xxOY9bUaektdwWyRR3IaCkhEyOcu0CpK2V8p6lQZ7v5tO7O3mfR0hgRDbwlNi4WtEvCW GPxKfpokd9amxet1Xv2wWdUnMiBQHOrFHZSF5y8riR6x3cOfG7/+DvV8OwkW3m7Y5xgL RCWXbR+6eGlR5Z6QCtIhUj2/d1so3ENqe9MHeC+dTSNosJZoQYKnSG5sfF+oMH/1MM2F xrZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-transfer-encoding; bh=nmwfSFeC4FsqEsRAQeWk8q7Q6CO3g44fKSuw4zQ0SnU=; b=nmBnxl/EW8BdLk0Yk9KeGzbu+xqbTa2LLqVq01GPo3RajeSmuK3bk8qrhn7e9pGYB2 nh75vN9t1PkM+EG3w+NCETFZg9hX3QaD9/7QQcTOyIiLV5hvLa+MYN+46nPLGalF9vNP Kvr3Kf8sCE3A+0e3ezn0s7q+lrG0Oxm/PbpDI+L6iObf8mDSh2BRtdJ/NeUskbvUFRHt V+IMUD18+JdNBQE4JHQT5w/+Hzd4wEbL4PmT6g/st9R+bFJEBCcIJ0fRZQOCynp1L27D UkbavLANwODfoQ29HlC2i253cvpburgY0s75v05yjK6//rhu8N6Sup1Scq4BOHekGGMp 3HrA== X-Gm-Message-State: AHQUAuZjIoXR8VPh7omgU7ByadG901SwlWhSwSZevBjOiNQn0jfhJbef YrJV2JuPHHdCbpjxCY+qlS159kNGn5Q= X-Received: by 2002:a63:480c:: with SMTP id v12mr3370440pga.115.1550143879410; Thu, 14 Feb 2019 03:31:19 -0800 (PST) Received: from localhost ([218.189.10.173]) by smtp.gmail.com with ESMTPSA id p2sm2795864pfp.125.2019.02.14.03.31.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 14 Feb 2019 03:31:18 -0800 (PST) Date: Thu, 14 Feb 2019 19:31:13 +0800 From: Yue Hu To: anton@enomsg.org, ccross@android.com, tony.luck@intel.com, keescook@chromium.org Cc: linux-kernel@vger.kernel.org Subject: [PATCH] pstore/ram: Avoid possible failure of dummy device unregister Message-ID: <20190214193113.0000609f.zbestahu@gmail.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org =46rom 08ac260f36b4c11eb33fa58466462a5e1027bdb3 Mon Sep 17 00:00:00 2001 From: Yue Hu Date: Thu, 14 Feb 2019 19:34:16 +0800 Subject: [PATCH] pstore/ram: Avoid possible failure of dummy device unregis= ter If create dummy platform device failed, dummy variable should not been set as NULL. Because the following platform_device_unregister() will judge if the dummy is NULL or not, if dummy is NULL nothing happen for unregister flow. Signed-off-by: Yue Hu --- fs/pstore/ram.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c index 4a06675..61bc573 100644 --- a/fs/pstore/ram.c +++ b/fs/pstore/ram.c @@ -994,7 +994,6 @@ static void __init ramoops_register_dummy(void) if (IS_ERR(dummy)) { pr_info("could not create platform device: %ld\n", PTR_ERR(dummy)); - dummy =3D NULL; ramoops_unregister_dummy(); } } --=20 1.9.1