Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp56448imj; Thu, 14 Feb 2019 15:15:21 -0800 (PST) X-Google-Smtp-Source: AHgI3IYk/xkhOZXqXO7TdxHEg3eN4yZ4AumfDKfK3m1f4RnMKGpWW9DWx8MqP5XF2017db1mPrxR X-Received: by 2002:a62:1706:: with SMTP id 6mr6603076pfx.28.1550186121807; Thu, 14 Feb 2019 15:15:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550186121; cv=none; d=google.com; s=arc-20160816; b=E5Of38dz7a1Z7LHqaDXMm4kPvPLgUJf4U9oODQ7BJ5Cxie8nI2FeR5J7KcZvgCdVVX 2hKuxEDdC/eZpnXQMinGPcnJGIhFLJVp5oBAWfdxyuTYfhL4LnPWvg45Aet1XfsWZH1H +E5zlzt26o/S5g9b5tTC3+5QNtN8nS/6XsLocII7iQqkvo3ZP68C+ygHNbZbemLxTiyL W2zAw+OVAdPlaJLlxeZ5pa9lTC0nCE9HDHelqTFq9I3v57Mr1aVIkj52iqX5IXtCXxhH Y5EGJgK9Y0ThZ3YxgqMqqo2A1COjyYaRuBLZpnVy7BAWr4+IDuKo4O6DSu6xlatqvN40 uAZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=CRKoP2+3xcm03hhxlu406Bu+0b2xDbHzdmoD6tZjvWQ=; b=heNifT8vAaWoqFUxV5uxJDTQTLl/DuhDqS3YLI6hfbaLhqoG7WWn6GRmSGmV31Zo+5 p8m5J4QTcJot/vMY3glgscxk35Z2ncZuVGqi82aEkTIcslwhFHqwQEznJ3NitprepnkU CXj+hewdeHyujlpMavwkuyax69oY6IaAGIT1Cmj0wYC82zqD1olDezpk+GItWA8Nn9U9 2xU4fIlXTdyLvJ2U+LdtyTB2rOksuQzx0MGGxuW/F8UM8x8RclMlISrA5FsdBwQGWo8X LX8mlErwUiCNeHLiIaO4+bofJzX5N3VgmMTJX2etnTnZcWDPdiUOj759gK4FOeY9+O8o ysiw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o6si3739414plh.23.2019.02.14.15.15.05; Thu, 14 Feb 2019 15:15:21 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394604AbfBNMdP (ORCPT + 99 others); Thu, 14 Feb 2019 07:33:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37306 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726097AbfBNMdO (ORCPT ); Thu, 14 Feb 2019 07:33:14 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 97857C01DDE2; Thu, 14 Feb 2019 12:33:14 +0000 (UTC) Received: from krava (unknown [10.43.17.161]) by smtp.corp.redhat.com (Postfix) with SMTP id EA9701A7CE; Thu, 14 Feb 2019 12:33:12 +0000 (UTC) Date: Thu, 14 Feb 2019 13:33:11 +0100 From: Jiri Olsa To: Song Liu Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, kernel-team@fb.com, peterz@infradead.org, acme@redhat.com Subject: Re: [PATCH 5/9] perf, bpf: save bpf_prog_info in a rbtree in perf_env Message-ID: <20190214123311.GA7465@krava> References: <20190209011705.2160185-1-songliubraving@fb.com> <20190209011705.2160185-6-songliubraving@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190209011705.2160185-6-songliubraving@fb.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 14 Feb 2019 12:33:14 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 08, 2019 at 05:17:01PM -0800, Song Liu wrote: > bpf_prog_info contains information necessary to annotate bpf programs. > This patch saves bpf_prog_info for bpf programs loaded in the system. > > perf-record saves bpf_prog_info information as headers to perf.data. > A new header type HEADER_BPF_PROG_INFO is introduced for this data. please move those 2 changes into separate patches then it's hard to make comments when I don't see the rest of the patches on the list please resend the patchset thanks, jirka