Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 14 Feb 2019 08:03:02 -0800
From:   Tony Lindgren <tony@atomide.com>
To:     Lee Jones <lee.jones@linaro.org>
Cc:     linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
        Florian Vaussard <florian.vaussard@epfl.ch>,
        Peter Ujfalusi <peter.ujfalusi@ti.com>
Subject: Re: [PATCH] mfd: twl6040: Fix device init errors for ACCCTL register
Message-ID: <20190214160302.GE5720@atomide.com>
References: <20190211225726.38355-1-tony@atomide.com>
 <20190214092045.GD13737@dell>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190214092045.GD13737@dell>
User-Agent: Mutt/1.11.2 (2019-01-07)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

* Lee Jones <lee.jones@linaro.org> [190214 09:21]:
> On Mon, 11 Feb 2019, Tony Lindgren wrote:
> > +		ret = regcache_sync(twl6040->regmap);
> > +		if (ret) {
> > +			dev_err(twl6040->dev, "%s register write failed: %i\n",
> > +				__func__, ret);
> 
> Please drop the __func__ and just use the standard format.
> 
> Wouldn't something a little more forthcoming be better?
> 
> "Failed to sync with the HW" ?

Sure I'll send an updated patch.

Regards,

Tony