Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp131688imj; Thu, 14 Feb 2019 17:01:07 -0800 (PST) X-Google-Smtp-Source: AHgI3Iah4+GtEqa5hVT3OfH+7mblJlkFV558+T53NuR6eUPDFuNAycS5SfbmPocroFiJxfJzO6n6 X-Received: by 2002:a65:514c:: with SMTP id g12mr2698855pgq.169.1550192467843; Thu, 14 Feb 2019 17:01:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550192467; cv=none; d=google.com; s=arc-20160816; b=qqh540s195Wj7IXjUaO+mURvQ3vQ8bfqsCGwsZAaxpHuD6OYa9jhD60Py9PDSIzd4c IH/hi/EJNWJpZM013UzRN05KTBmpz0XH5lBEDFIZUrnUYmP4BkLaN/bEvpGxVbuxDMDy W3krt7enxGRSMizeGo212R9CIkHmJDAynFBC/3Lj/cWj6sQF0wLrmIR8jZ4k9Li5Hw2Y 4NdFsDvzMQWVkuGnHEn4XvBFxO/hhENXsTWodKA5uhbWuIy9f90egKDvsVyTA1wTqLV+ OI+esVoO3FpZgx1LIru3QFdgsVlMDW973fC4tmC5v+SsmsjiNXBDxai+DW0MG2IIpk13 +ccw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=Am8Jz9jc3gLiC8JdupVQMgvQ++aHmjpLhtdY4gHFRm8=; b=KupeheUQkEusbbgfVCxi10t/6E4OKb6HnQJaVCCDZrk8zkPxVccTxfXTN0NvU0S3TO AwSDroJ4FQByVhKuhXTmjcos1SYqqct8KhR7WAvBEjSJ7CNdE/WgxgNUtfCABzshNgWI KDRi2R0k5XthuQWxNRrf4dDYqQ7JjeJ3GSffHHncrGuAQ/ivILAlne+nyDUX427JNRfL n0MrKX2B1jLRnkjbRnC364xJmfWt/9WBxWZp3/QO/DG2YQBNdsOh1Q3RLB/6EaxG1VCg BoseiyOHPo220JbKAzEfzVwiToyuGIgK51wwDhpQS0/F8zhMRpek7OOsTJaN6PojhA7M aHww== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x29si3698685pgl.584.2019.02.14.17.00.52; Thu, 14 Feb 2019 17:01:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732157AbfBNRCd (ORCPT + 99 others); Thu, 14 Feb 2019 12:02:33 -0500 Received: from sauhun.de ([88.99.104.3]:54220 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727648AbfBNRCd (ORCPT ); Thu, 14 Feb 2019 12:02:33 -0500 Received: from localhost (unknown [83.221.228.209]) by pokefinder.org (Postfix) with ESMTPSA id 5E4372C2817; Thu, 14 Feb 2019 18:02:31 +0100 (CET) Date: Thu, 14 Feb 2019 18:02:30 +0100 From: Wolfram Sang To: John Sperbeck Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, mingo@redhat.com, rostedt@goodmis.org Subject: Re: [PATCH v3] i2c: core-smbus: don't trace smbus_reply data on errors Message-ID: <20190214170230.dvm4i2wxmgxij4bg@ninjato> References: <20190213034057.244716-1-jsperbeck@google.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="phfr5v3ila4kfyxj" Content-Disposition: inline In-Reply-To: <20190213034057.244716-1-jsperbeck@google.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --phfr5v3ila4kfyxj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 12, 2019 at 07:40:57PM -0800, John Sperbeck wrote: > If an smbus transfer fails, there's no guarantee that the output > buffer was written. So, avoid trying to show the output buffer when > tracing after an error. This was 'mostly harmless', but would trip > up kasan checking if left-over cruft in byte 0 is a large length, > causing us to read from unwritten memory. >=20 > Signed-off-by: John Sperbeck Applied to for-next, thanks! --phfr5v3ila4kfyxj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAlxlnyYACgkQFA3kzBSg KbZaEw/+NZvurPqjr3PWQqctg8PTGEw4RgkftxoIXmazaed8cCYoj3XpqQ0EP8jZ Ur+GbUtMaPpO7bUjSG2jmlMeKW8kxJXFy9HwtSlZYBMK6GH/Yy4UqqPEPK+FAQt9 sIPzrnRMeGb4yxQY7fH9E/O0xHoR35cszDdwkwfhF31dpIrZAuFwDumSP6LdHeTs 9QKK/R1+gCegEArc4n+mb0Xpla7FLV03VD8DlEnUY8vvhWQyprmr1UK6SZ1r+HvD AHTrM34kgrSBXSD28GP5s+r9AvdUgMvMRmHol9Ph8Mt2sp9ndwMs+IRL3OEsHBAw 22eBPJI7UixhQHWw03dbJ5jsd9J3SmTvD6KWoF5jyTqW9sd01vknob8fdOkH5Ec6 jnXSG4ixes9ILqHO+B+MQfhOnHxgXPE4NJGbktzdKCOHvajKiIplSDhZsBgTvmL9 ELj4tuBcifBfYGbeZDO6hwSLacwULrcGqMv4iMRMyQRnHWFvvHjpZPqucHgRCbJP DSxaINCgfcsS4W8Cmd1FhrmsaHgk1WbbN0MkfuqjEkGtuGH6ld+10ENZArnxZU6F kOZtyYKuj5oKw/Ayx0LJbHcDPNTYMjLqypmPjOrxtMMwDzG+qGqX2gaS1bQy6QP8 O52fD4NVHNkcIAtA+ROjGeqeOHYM3nWWBu01F2VmmER/s+yAx3Q= =uqJ3 -----END PGP SIGNATURE----- --phfr5v3ila4kfyxj--