Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp136807imj; Thu, 14 Feb 2019 17:06:58 -0800 (PST) X-Google-Smtp-Source: AHgI3Ibg1oU4vRqPjyFiqj0725GY4qRwz8oPq7AEIffnaprfNCMXpqEescZGDnoiciMeJ/GOpiXW X-Received: by 2002:a63:354a:: with SMTP id c71mr2797692pga.150.1550192818207; Thu, 14 Feb 2019 17:06:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550192818; cv=none; d=google.com; s=arc-20160816; b=TEAPUIoQVQoR1t4Uoj85F8yA4qdaXkDCHoMULIJiT8xrsh7Bm38TbYYslwhomcV6hv bVpcyoIVjuMft1duthtmZhCdKDo5P8NhWP7zUPkvBT1G05m/AcRyrJake0Y0Z/FWtojG /H9GECzdoJT2Bn1ht+nQYP3ksHtoxwIlL5ToG9yRPVzIMTuiULvREq5QThEl4Br+v3iN sT4kBNs7+1lwC7tmVqRyFf5LtDgL3CSO6ia0GniqQgOtnMH0lfLKZNQA1ISNIExG5LyK mplZ7lJU7c/89eXnrOa/QJVRZowc6klKah8B8FAAhS+vH+eRFVoz0SwbmopPdtGwpAEu ///g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=t/dv7bMndtHCGyOI7f8ilfX9ymigW3m1mv5NPEqUtys=; b=qP+1WdFenfITzXP6uR5XuWm785eoh0/krHzWC77ejNYbe2NqbYlBIB3rOhjpluZ2xU hn7QZFD/alqDhEStM88E4cIFsdrNg8SpsK4Se8VJNoYoHpo9ivTXcbzgm2cm5IVGSFrk htMelAq0pmejUve/Zb1f1bs5SJTovw/XP44Loi+E1CnSHSHWyVHp22jQB4GB9Qpwhf5c 7J8RQxoIESWZdkVA738hOHp1MYqkAWz8ypKBKKQHcgCxSczDQGxSykEv17MmM3jYLTrc Fh8R8CCzjqiC4sDtVUUsr+UuYQZY8DfYnOb3OJu7luE1FpEiqdMQMxOfUKuOtXKE3DgY k0AQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r10si311389pgk.234.2019.02.14.17.06.42; Thu, 14 Feb 2019 17:06:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389873AbfBNRWW (ORCPT + 99 others); Thu, 14 Feb 2019 12:22:22 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:56900 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726160AbfBNRWW (ORCPT ); Thu, 14 Feb 2019 12:22:22 -0500 Received: from localhost (96-89-128-221-static.hfc.comcastbusiness.net [96.89.128.221]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 8FBE014D4F4F4; Thu, 14 Feb 2019 09:22:21 -0800 (PST) Date: Thu, 14 Feb 2019 09:22:20 -0800 (PST) Message-Id: <20190214.092220.667100849624830283.davem@davemloft.net> To: huang.zijiang@zte.com.cn Cc: isdn@linux-pingi.de, natechancellor@gmail.com, yuehaibing@huawei.com, baijiaju1990@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, wang.yi59@zte.com.cn Subject: Re: [PATCH] isdn:hisax: Replace dev_kfree_skb_any by dev_consume_skb_any From: David Miller In-Reply-To: <1550126399-28063-1-git-send-email-huang.zijiang@zte.com.cn> References: <1550126399-28063-1-git-send-email-huang.zijiang@zte.com.cn> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 14 Feb 2019 09:22:21 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Huang Zijiang Date: Thu, 14 Feb 2019 14:39:59 +0800 > The skb should be freed by dev_consume_skb_any() in hfcpci_fill_fifo() > when bcs->tx_skb is still used. The bcs->tx_skb is be replaced by > skb_dequeue(&bcs->squeue), so the original bcs->tx_skb should > be consumed(not drop). > > Signed-off-by: Huang Zijiang Applied, thanks.