Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp138260imj; Thu, 14 Feb 2019 17:08:53 -0800 (PST) X-Google-Smtp-Source: AHgI3Ia8TgtG1Ftz/0UIIjCvsEOiYmSbhWs+sV1R9tK5M4ukgIgQ8KP9dH3EJ5vJhYWO96tcghlW X-Received: by 2002:a62:31c1:: with SMTP id x184mr7259859pfx.204.1550192933615; Thu, 14 Feb 2019 17:08:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550192933; cv=none; d=google.com; s=arc-20160816; b=Fwcz2cki+XYuGEqzB0KkrWlLTtVb9tX8d1n3HuhqdciupMTfPE274l307dDbxiPGeL 8HXRfD4Q3B1Qb6C24d2D2iVpPIT0+tlzjGlNVUano03Qnx72Hc2OhcZPeGTysfeSKO6I 4rqgyp7H28AtZOp9XL8Z5Z4QnZvwGBf9KeNBfBd6453owOaVw8z/hellKKJQt68umb+6 G+bWgpD/DfpW2wHTsnXZecKxWYQM7XOuEcX/nckFqBvyHxZbJNJJUbuCKxyBn0fFAiWL 3AowP9Ng1v7wj/zLEaUET9DuwKvUfFL3gkrBbDIzkwJRhgEm1VHvi7EIXLQXu1sc6mIT nKSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=hBcBKs1QgfePDCvKu4Erf+Ad6Z6GHEgxNtWKAv1RAco=; b=gXP/H5gzCn4kvvGrfxyWunbkbyQa6Qw+M+ebTiPLCXZkGPE86R308qNyvQjZRIuOKE BgTaubfCqYyYAKOiejxlkb/10ZijKVpyVM4RgoS1ylFi5vzCVBVAUhVDzy+uFBR13N8O o/QKiz3e71OIjlUu+U5CG8tQG46VHVuIMn+5oG2prnbSZkIaOEQd2vQXU2Y01BGBh4di S9qtq9wlu5NBZFMDhFoqzokb+O/r5SsDTGcVSqz4WWJHNP4EC9f79guYnBGph3xJ82NW TYgcwzDN+M621jGm/lvpEFmcjFDkGuV5oP5UrgafQz1X1AekkdgXyTOlifDK06z5kn5O 6dwg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p24si3913988pgl.117.2019.02.14.17.08.37; Thu, 14 Feb 2019 17:08:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2395097AbfBNR2I (ORCPT + 99 others); Thu, 14 Feb 2019 12:28:08 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:57026 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2394962AbfBNR2I (ORCPT ); Thu, 14 Feb 2019 12:28:08 -0500 Received: from localhost (96-89-128-221-static.hfc.comcastbusiness.net [96.89.128.221]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 5ADF014D634C5; Thu, 14 Feb 2019 09:28:07 -0800 (PST) Date: Thu, 14 Feb 2019 09:28:06 -0800 (PST) Message-Id: <20190214.092806.319582154343691855.davem@davemloft.net> To: huang.zijiang@zte.com.cn Cc: linux-net-drivers@solarflare.com, ecree@solarflare.com, bkenward@solarflare.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, wang.yi59@zte.com.cn Subject: Re: [PATCH 2/2] net: Replace dev_kfree_skb_any by dev_consume_skb_any From: David Miller In-Reply-To: <1550126533-28462-1-git-send-email-huang.zijiang@zte.com.cn> References: <1550126533-28462-1-git-send-email-huang.zijiang@zte.com.cn> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 14 Feb 2019 09:28:07 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Huang Zijiang Date: Thu, 14 Feb 2019 14:42:13 +0800 > The skb should be freed by dev_consume_skb_any() efx_tx_tso_fallback() > when skb is still used. The skb is be replaced by segments, so the > original skb should be consumed(not drop). > > Signed-off-by: Huang Zijiang Applied with Sergei's suggested commit message fixups. Thanks.