Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp139083imj; Thu, 14 Feb 2019 17:09:59 -0800 (PST) X-Google-Smtp-Source: AHgI3IZryBi+45dSXlZT1blQXO9+6TjSAfBRS47uUNnt21ReW8/Qe65pZ4WjmG2/xWuY0cavqGm8 X-Received: by 2002:a62:2ad6:: with SMTP id q205mr7026953pfq.243.1550192998930; Thu, 14 Feb 2019 17:09:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550192998; cv=none; d=google.com; s=arc-20160816; b=TPI/cx+VUBrcc/3eBUCPAQhICq3vmeaRLBr4eQ6qncZHm//FwnIQQj6f7O/C18U7qi mdxjWjpAfMn3TRRkIEKO2M77g93pX2DFvSE4NE39Hvkd8v5UKT8QpYo/rAzYsrp/59Lg PdNfg3b4OSnjayJikaWSvoLXs2qt36V7dJ/rbmdFCzBWPrIaCsEUZ8UYQZXy8p2n32zY OhyZMUDdbROgavnfuIZkD1bPztR9RABOCLhIkByFhidkrVZ4+Gb/cnW2rlbBz/K4rl8L Bfsao0N9CA+lcWllJc4z2NRbX0myaCOYWhhfr/Cxu4wBnZb2F/W+Npnjksd16fsfsduo sr1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=+ckEqVvm4zS45vce4WVGfI9GLX79sAf+3YzOAUQYJ8E=; b=GNoEq//+l4b7tZVoSyMVSvwX+r5M3K17VLrs61VWShHGArPmz2zEZ1HQhpJ2ctSRUr nXf6u3Be1WdyOIF1+YDl/t7XQLypQNaI/VhWVWPTAptmOvGLPcAYB70jTmSMtfbNUdON K49/V4FgDqBpA2kUKuuyxx/K7CdSxoQ+07JbRVTgo5tTXv4xQxEM+q69TU1YrODwpSbZ HSJFmU6G9UoFGpp4dhFcQ8C8dd3lLyIvpP9T5U21B+emsCUzhUeX2sE322qhYbpDlfIL InvPXqvbbx5mvOYQnckLJPvDL/xwlAdONpo1VWiAcNc7GnXtQuV7ecr4MpDxp0phZK0z hKqg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u10si278465pgi.515.2019.02.14.17.09.43; Thu, 14 Feb 2019 17:09:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2395012AbfBNR17 (ORCPT + 99 others); Thu, 14 Feb 2019 12:27:59 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:57004 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2394962AbfBNR1z (ORCPT ); Thu, 14 Feb 2019 12:27:55 -0500 Received: from localhost (96-89-128-221-static.hfc.comcastbusiness.net [96.89.128.221]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 536E514D634BE; Thu, 14 Feb 2019 09:27:55 -0800 (PST) Date: Thu, 14 Feb 2019 09:27:54 -0800 (PST) Message-Id: <20190214.092754.683198985772100818.davem@davemloft.net> To: huang.zijiang@zte.com.cn Cc: nicolas.ferre@microchip.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, wang.yi59@zte.com.cn Subject: Re: [PATCH 1/2] net:ethernet:cadence: Replace dev_kfree_skb_any by dev_consume_skb_any From: David Miller In-Reply-To: <1550126478-28316-1-git-send-email-huang.zijiang@zte.com.cn> References: <1550126478-28316-1-git-send-email-huang.zijiang@zte.com.cn> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 14 Feb 2019 09:27:55 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Huang Zijiang Date: Thu, 14 Feb 2019 14:41:18 +0800 > The skb should be freed by dev_consume_skb_any() in macb_pad_and_fcs() > when *skb is still used. The *skb is be replaced by nskb, so the > original *skb should be consumed(not drop). > > Signed-off-by: Huang Zijiang Applied.