Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 14 Feb 2019 11:58:55 -0800
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Johannes Weiner <hannes@cmpxchg.org>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        =?UTF-8?Q?=C5=81ukasz?= Siudut <lsiudut@fb.com>,
        linux-kernel@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH] psi: avoid divide-by-zero crash inside virtual machines
Message-Id: <20190214115855.76869aecd777fbd37d48f45c@linux-foundation.org>
In-Reply-To: <20190214193157.15788-1-hannes@cmpxchg.org>
References: <20190214193157.15788-1-hannes@cmpxchg.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 14 Feb 2019 14:31:57 -0500 Johannes Weiner <hannes@cmpxchg.org> wrote:

> --- a/kernel/sched/psi.c
> +++ b/kernel/sched/psi.c
> @@ -322,7 +322,7 @@ static bool update_stats(struct psi_group *group)
>  	expires = group->next_update;
>  	if (now < expires)
>  		goto out;
> -	if (now - expires > psi_period)
> +	if (now - expires >= psi_period)
>  		missed_periods = div_u64(now - expires, psi_period);
>  
>  	/*

It seems appropriate to use time_after64() and friends in this code.