Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp198921imj; Thu, 14 Feb 2019 18:31:01 -0800 (PST) X-Google-Smtp-Source: AHgI3IZI5M1toDn2kA5LTiIGhWidjBqqu5DVfGJEOt6tNXa6zuNVItykSIZaJGpPzB8EPzurUdWN X-Received: by 2002:a63:7503:: with SMTP id q3mr2867194pgc.98.1550197861710; Thu, 14 Feb 2019 18:31:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550197861; cv=none; d=google.com; s=arc-20160816; b=m835AwNaY8se8cjTeG0rzNxjNaHk9t+nnWNsp2txdrYaMxj99MeViQ0avY9vhOrAzX 55tNYQL/039Qpsnu/zlv51rBUtyg0BjJdEr6FWNTXQlR7TiqzWRaxCOb5gaCBKe9swv/ V8kLqNFzmXPkFx7fpuclbBVYNju2BccxzF4DHqFRFXCB36X7llPeWon9AR2uCHP/Wvey iFtHPb6l4zwmZv1zD92l1fshM7hu0dpWa5NtLV5t8B2f5AAn0MUfInZPKfxX20OM5Mpb lCTFKvPOUb90PGEBMdgyJKA9hBCdrITo/ueFXGrrOHf6Ls5PP+wbl4vienhqg1Jau7iF AKOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=1NLI2eIIIYHgMgUMXaKxEpmcwoqlsQvcH5WNL0a4Rh0=; b=tAigb3BN2hW5AK6eAXhQ9hHtz4cp0Tx8qDNxsgHHt84eZnsLHujBCG3hiwGcqXPTnP EEAET/SwB/FYjiqyjSVd4xDOn7aRTHOIfO9SPdOE4MuOcSlAM62smgeH3VzMa6lmddE9 qUCstzDylyzS4fPqtwlEGporddu3ZOwWbCLhta3NutIYVNG6N/UYQBStvX9FHD6/R9g3 rP+khQRVIUL6/iQPAM3EE2AneIflZR81Kf2ekm4+HHIaxuc6/t0I6PXcx2bAVhUoy27D S0k7YLCdgWydywmtckK7Lg/HcT6asdahsHQv9pPTBjIapWYrjQPFORmn5IICUGYkW1D4 gz2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="xx3+Z2/v"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q6si4019883pgq.442.2019.02.14.18.30.45; Thu, 14 Feb 2019 18:31:01 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="xx3+Z2/v"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731910AbfBOCKs (ORCPT + 99 others); Thu, 14 Feb 2019 21:10:48 -0500 Received: from mail.kernel.org ([198.145.29.99]:50888 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731885AbfBOCKp (ORCPT ); Thu, 14 Feb 2019 21:10:45 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7E27421B68; Fri, 15 Feb 2019 02:10:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550196644; bh=80UibNHn3+S3eohnIQUujkkcClnzYCmjQXC9fG/y2LY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xx3+Z2/vy2KqVctbHvXoeFUwllzPCZMwm6SGXJLJSMyhaFxhYCemCx6A2bb08ZhfS 8xlQT5Txx4dDRbx7nDcv25N7ux6rNA8/LlGF6/JO3kTVLGSIR8cWNFh5eQ6O0qbVU+ hn9lDdvVBDOtU+ubFsl07x0Bb8LmfIQoYN2SeFpg= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Douglas Anderson , Rob Clark , Sasha Levin , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org Subject: [PATCH AUTOSEL 4.20 63/77] drm/msm: Fix A6XX support for opp-level Date: Thu, 14 Feb 2019 21:08:41 -0500 Message-Id: <20190215020855.176727-63-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190215020855.176727-1-sashal@kernel.org> References: <20190215020855.176727-1-sashal@kernel.org> MIME-Version: 1.0 X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Douglas Anderson [ Upstream commit a3c5e2cd79753121f49a8662c1e0a60ddb5486ca ] The bindings for Qualcomm opp levels changed after being Acked but before landing. Thus the code in the GPU driver that was relying on the old bindings is now broken. Let's change the code to match the new bindings by adjusting the old string 'qcom,level' to the new string 'opp-level'. See the patch ("dt-bindings: opp: Introduce opp-level bindings"). NOTE: we will do additional cleanup to totally remove the string from the code and use the new dev_pm_opp_get_level() but we'll do it in a future patch. This will facilitate getting the important code fix in sooner without having to deal with cross-maintainer dependencies. This patch needs to land before the patch ("arm64: dts: sdm845: Add gpu and gmu device nodes") since if a tree contains the device tree patch but not this one you'll get a crash at bootup. Fixes: 4b565ca5a2cb ("drm/msm: Add A6XX device support") Signed-off-by: Douglas Anderson Reviewed-by: Jordan Crouse Signed-off-by: Rob Clark Signed-off-by: Sasha Levin --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c index d4e98e5876bc..00b2e6e94689 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c @@ -939,7 +939,7 @@ static u32 a6xx_gmu_get_arc_level(struct device *dev, unsigned long freq) np = dev_pm_opp_get_of_node(opp); if (np) { - of_property_read_u32(np, "qcom,level", &val); + of_property_read_u32(np, "opp-level", &val); of_node_put(np); } -- 2.19.1