Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp206452imj; Thu, 14 Feb 2019 18:41:01 -0800 (PST) X-Google-Smtp-Source: AHgI3Iat26kYep28QdfGJeQSBk79c0BEmudlRh+Cp4xYy6xGtGbkUE51WJcX9zalbhshUU4TdoIY X-Received: by 2002:a65:6553:: with SMTP id a19mr3123060pgw.267.1550198461444; Thu, 14 Feb 2019 18:41:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550198461; cv=none; d=google.com; s=arc-20160816; b=Q6y2qN8/XkXrcP+Hzq1maoVa6ODXVGzECWLUwquKuB1Rlh0lgEntPKyjDiQmw2M7Pf uOWHZRQp32jmDcL4qKjCTR+iqP3Q/nbLvL2V+tj/9qc9Ene3zuSOU9fM6UQMHvDiPmcA DdP/H1noHyIl77DVy+fgp4IIeYPdJBfA9enMr8vqK2AoUqv3awB+9E9m5nzD53h93KqJ jtlaU6TT7GY3Mj2GmzloCcQ3Lhdk8IvVwUWDq0inOc+U3NweDwqbVwS9HcaJTmsKtXv4 PRvobgU4snilGfsXBuaqlHugdtL4JaQaNrMdvHpMgPADAjpPCw791XoquPI8PkFe4FfI gQww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=fKLBgrRqswKjAqSMBhXGmeszeZ8c8chK+/2FqaIONsA=; b=VeqSB5j3WmRkzm3aWJK6QOIhAs/4TnViJ5+rxRNJ/ADeTBb1P1KEGXcT/IP4Ub6bPY gQisG4CjMi70SZVRtvvzhzMXoHpA6otVUCLwVHOgYktqelgsgCde4FjDOd1jXLDzHWku kQTDhmCMnnQPEkPLCgfTFnCi9olWKD9tYVxTEwNtCuW+TQQrDUfajjZMmC3pDvAI0CqC Q370B/z5WsBXeegdn+rjGOnbNwvAhHYn6Ot9jEf7p5XFVJC8n23r2c+NMRnnPAaZtabi OjcQ8MWaQjnxDVTvmV7R0/gtk3L5wm+o4A5lk3Xg/kAKRozcqjmZLPIEuzFjjCXEwA2/ unoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=jaTe6fJR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x38si4141042pgl.419.2019.02.14.18.40.45; Thu, 14 Feb 2019 18:41:01 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=jaTe6fJR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390195AbfBOCKO (ORCPT + 99 others); Thu, 14 Feb 2019 21:10:14 -0500 Received: from mail.kernel.org ([198.145.29.99]:50332 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390110AbfBOCKM (ORCPT ); Thu, 14 Feb 2019 21:10:12 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 260DD222D4; Fri, 15 Feb 2019 02:10:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550196611; bh=e/h8C4M3EzC/+wvYTgQB3vp9NjAx6Ohx09kOImO2ogc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jaTe6fJRHHLNxwIGSR4R83WgsS5cQh/Uz9kEWJlo30r61efrwG8BzjWOF60+vQdjr 1IdXgrko9sGWY6RPoGQBkwE6iDvcDggrl5+MmyzsFBAHYyCGnaXfgwhPTC6g+/Lmu4 a3+GD5kw1yPVGOriWvkWeQUO0rWQmNNU8G6Qo/qY= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Matthias Kaehlcke , Greg Kroah-Hartman , Sasha Levin , linux-serial@vger.kernel.org Subject: [PATCH AUTOSEL 4.20 44/77] tty: serial: qcom_geni_serial: Allow mctrl when flow control is disabled Date: Thu, 14 Feb 2019 21:08:22 -0500 Message-Id: <20190215020855.176727-44-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190215020855.176727-1-sashal@kernel.org> References: <20190215020855.176727-1-sashal@kernel.org> MIME-Version: 1.0 X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Matthias Kaehlcke [ Upstream commit e8a6ca808c5ed1e2b43ab25f1f2cbd43a7574f73 ] The geni set/get_mctrl() functions currently do nothing unless hardware flow control is enabled. Remove this arbitrary limitation. Suggested-by: Johan Hovold Fixes: 8a8a66a1a18a ("tty: serial: qcom_geni_serial: Add support for flow control") Signed-off-by: Matthias Kaehlcke Reviewed-by: Johan Hovold Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/tty/serial/qcom_geni_serial.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c index d3b5261ee80a..76e0ad7251e1 100644 --- a/drivers/tty/serial/qcom_geni_serial.c +++ b/drivers/tty/serial/qcom_geni_serial.c @@ -221,7 +221,7 @@ static unsigned int qcom_geni_serial_get_mctrl(struct uart_port *uport) unsigned int mctrl = TIOCM_DSR | TIOCM_CAR; u32 geni_ios; - if (uart_console(uport) || !uart_cts_enabled(uport)) { + if (uart_console(uport)) { mctrl |= TIOCM_CTS; } else { geni_ios = readl_relaxed(uport->membase + SE_GENI_IOS); @@ -237,7 +237,7 @@ static void qcom_geni_serial_set_mctrl(struct uart_port *uport, { u32 uart_manual_rfr = 0; - if (uart_console(uport) || !uart_cts_enabled(uport)) + if (uart_console(uport)) return; if (!(mctrl & TIOCM_RTS)) -- 2.19.1