Received: by 2002:ac0:946b:0:0:0:0:0 with SMTP id j40csp838683imj; Fri, 15 Feb 2019 07:38:48 -0800 (PST) X-Google-Smtp-Source: AHgI3IZaykqm2NPDHQo1XJEwsGHM1J+PZgA4EZK39crIB4PnCbSrJf2oqJ+MLR1hLNU8sMrSMQNN X-Received: by 2002:a63:b70b:: with SMTP id t11mr5876019pgf.404.1550245128901; Fri, 15 Feb 2019 07:38:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550245128; cv=none; d=google.com; s=arc-20160816; b=egL7U4quGzpBZy75GZ+WyFxC3NSKuPh53EeQb0QKypSXr7zg2TnVYU64XYGj38uVFT oPFBbGDwJHw0LP/gx2/9Wr5tBoh+gLVwG8dxT8bfUY4+WMxsUFFUsyCbBGVlBTj3x0+F spJfs6O0gH1U+tfbqNaoUxidT5OhvqBAbmQwP/MTVQUAiFxDhl9+kRT8btKdcyjzetHh suG3uuoxgJE1+S3BG0x+Kr3Epx3wUJhUaj9yHDqkukd/hjX5dpD03gYQAWgkwtmL/va8 1xqCSmkwj+wP10rZXteuCK37XYefgCBJMrj6IZOoxNAAhOndHpdpwHpECrUrO+BKhkDw d1Sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature:dkim-filter; bh=ipwSqGKOtUHrs33U6yO/OuzKAUWDmn9Er4eFuQ213OY=; b=OvsfNVm1FX5byh4PteR6d9u/Zj6dI2HAGmbzZ6Kxv+FALsTPE28bLkDlNxlW2++qwC VCzkCJsmGQsgNoBzDQcnvfDXOQd+I0Ag639izrD12wGvT4h4thIXwYLefj7TnVGNBkm0 vm1UkqQWhocnVeGndE1L1NEMa03dNTW7AZswS5eQIQxJsk+YRESi1BakiKLNmWw3S8Ij MaLYnqXk9Qjfbdo8Bj04Jgf2gdzVOnjZqePhAZgaUMErclkMe2B2kwi8NQwVD1U7w5e6 S0QsY9gGt/vF3cEK1jjrcubZkiCpb48trFCnriIeeRQSdEXn1saM8Fjsri5dX8z5KVyY 9rRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b="r/G/c1Qj"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s7si204629plq.61.2019.02.15.07.38.33; Fri, 15 Feb 2019 07:38:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b="r/G/c1Qj"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404405AbfBOInM (ORCPT + 99 others); Fri, 15 Feb 2019 03:43:12 -0500 Received: from conssluserg-06.nifty.com ([210.131.2.91]:38789 "EHLO conssluserg-06.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404378AbfBOInM (ORCPT ); Fri, 15 Feb 2019 03:43:12 -0500 Received: from mail-vk1-f179.google.com (mail-vk1-f179.google.com [209.85.221.179]) (authenticated) by conssluserg-06.nifty.com with ESMTP id x1F8h2p9029419; Fri, 15 Feb 2019 17:43:03 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-06.nifty.com x1F8h2p9029419 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1550220183; bh=ipwSqGKOtUHrs33U6yO/OuzKAUWDmn9Er4eFuQ213OY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=r/G/c1QjnEcKDOxcndklNUbzkPiWtjsSbxgkEJ5xCNVkeX4P2KgnfHMInSbRR3lm5 aAqJ3tzTmmbbGnWbuYFqTKyWcNWeneBxGFpbqqXR7+aum1qTdHkM2s4LUZl5oYEjvn T1DN9rwPJBquAbBPYuagGLoaWgQ+SKYPoz8jF56yNKMiRUevGmgImo36p6h6C9DS/B qa1Ky8H4/1zbvcAb7pDHueVkenmzjKI2gEOS7uzRfxbS7fy4otG9BY+FkkwErRUc68 md+TwLZuLDcyQw4JKbeozXTSkB8OXaZmDRz6ANlprYiFWFw4eTuffn6VDkVSahW9LB 0xta5NWD51prA== X-Nifty-SrcIP: [209.85.221.179] Received: by mail-vk1-f179.google.com with SMTP id l136so2063076vke.2; Fri, 15 Feb 2019 00:43:03 -0800 (PST) X-Gm-Message-State: AHQUAuaOMHXNYsANPZ81vzk8jkBcdMbusPbkeFB0WuOfLLVaOGWo41W7 Z+14lXP1vIQIZMVynpn2bUyKbVfXC/x7UDinZ8Y= X-Received: by 2002:a1f:1ac3:: with SMTP id a186mr4404252vka.34.1550220182039; Fri, 15 Feb 2019 00:43:02 -0800 (PST) MIME-Version: 1.0 References: <20190213174005.28785-1-hch@lst.de> <20190213174005.28785-9-hch@lst.de> In-Reply-To: <20190213174005.28785-9-hch@lst.de> From: Masahiro Yamada Date: Fri, 15 Feb 2019 17:42:25 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 08/11] lib: consolidate the GENERIC_BUG symbol To: Christoph Hellwig Cc: linux-xtensa@linux-xtensa.org, linux-s390 , Linux Kbuild mailing list , Linux Kernel Mailing List , linux-riscv@lists.infradead.org, linuxppc-dev Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 14, 2019 at 2:40 AM Christoph Hellwig wrote: > > And just let the architectures that want it select the symbol. > Same for GENERIC_BUG_RELATIVE_POINTERS. > > Signed-off-by: Christoph Hellwig This slightly changes the behavior of GENERIC_BUG_RELATIVE_POINTERS for arm64, riscv, x86. Previously, GENERIC_BUG_RELATIVE_POINTERS was enabled only when BUG=y. Having said that, this is not a big deal. When CONFIG_GENERIC_BUG=n, CONFIG_GENERIC_BUG_RELATIVE_POINTERS is actually don't care. If you change this, could you add some comments in commit description? > --- > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index c39dac831f08..913b2ca7ec22 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -85,6 +85,8 @@ config ARM64 > select FRAME_POINTER > select GENERIC_ALLOCATOR > select GENERIC_ARCH_TOPOLOGY > + select GENERIC_BUG if BUG > + select GENERIC_BUG_RELATIVE_POINTERS Precisely, select GENERIC_BUG_RELATIVE_POINTERS if BUG > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig > index 732614eb3683..c410ed896567 100644 > --- a/arch/riscv/Kconfig > +++ b/arch/riscv/Kconfig > @@ -19,6 +19,8 @@ config RISCV > select ARCH_WANT_FRAME_POINTERS > select CLONE_BACKWARDS > select COMMON_CLK > + select GENERIC_BUG if BUG > + select GENERIC_BUG_RELATIVE_POINTERS if 64BIT Precisely, select GENERIC_BUG_RELATIVE_POINTERS if 64BIT && BUG > diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig > index 15ccdd04814e..2a5c12be633e 100644 > --- a/arch/s390/Kconfig > +++ b/arch/s390/Kconfig > @@ -17,12 +17,6 @@ config ARCH_HAS_ILOG2_U64 > config GENERIC_HWEIGHT > def_bool y > > -config GENERIC_BUG > - def_bool y if BUG > - > -config GENERIC_BUG_RELATIVE_POINTERS > - def_bool y > - Hmm, s390 enables GENERIC_BUG_RELATIVE_POINTERS irrespective of BUG... > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index 1bd4f19b6b28..f4cb31174e1b 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -91,6 +91,8 @@ config X86 > select DCACHE_WORD_ACCESS > select EDAC_ATOMIC_SCRUB > select EDAC_SUPPORT > + select GENERIC_BUG if BUG > + select GENERIC_BUG_RELATIVE_POINTERS if X86_64 Precisely, select GENERIC_BUG_RELATIVE_POINTERS if X86_64 && BUG -- Best Regards Masahiro Yamada